From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Hector Palacios <hector.palacios@digi.com>,
linus.walleij@linaro.org, brgl@bgdev.pl, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org
Cc: andy@kernel.org, conor+dt@kernel.org, shawnguo@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, linux-imx@nxp.com, stefan@agner.ch,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] dt-bindings: gpio: vf610: add optional 'ngpios'
Date: Wed, 17 Jan 2024 09:55:09 +0100 [thread overview]
Message-ID: <7b51e7b4-7a08-4a7c-a30c-17447583eff8@linaro.org> (raw)
In-Reply-To: <20240117083251.53868-3-hector.palacios@digi.com>
On 17/01/2024 09:32, Hector Palacios wrote:
> Some SoCs, such as i.MX93, don't have all 32 pins available
> per port. Allow optional generic 'ngpios' property to be
> specified from the device tree and default to 32 if the
> property does not exist.
>
> Signed-off-by: Hector Palacios <hector.palacios@digi.com>
> ---
This is a friendly reminder during the review process.
It seems my or other reviewer's previous comments were not fully
addressed. Maybe the feedback got lost between the quotes, maybe you
just forgot to apply it. Please go back to the previous discussion and
either implement all requested changes or keep discussing them.
Thank you.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-01-17 8:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-17 8:32 [PATCH v3 0/3] gpio: support i.MX93 truly available GPIO pins Hector Palacios
2024-01-17 8:32 ` [PATCH v3 1/3] gpio: vf610: add support to DT 'ngpios' property Hector Palacios
2024-01-17 20:51 ` Andy Shevchenko
2024-01-18 8:25 ` Hector Palacios
2024-01-18 9:03 ` Andy Shevchenko
2024-01-18 12:03 ` Bartosz Golaszewski
2024-01-18 12:44 ` Hector Palacios
2024-01-18 12:59 ` Bartosz Golaszewski
2024-01-17 8:32 ` [PATCH v3 2/3] dt-bindings: gpio: vf610: add optional 'ngpios' Hector Palacios
2024-01-17 8:55 ` Krzysztof Kozlowski [this message]
2024-01-17 8:32 ` [PATCH v3 3/3] arm64: dts: imx93: specify available 'ngpios' per GPIO port Hector Palacios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b51e7b4-7a08-4a7c-a30c-17447583eff8@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andy@kernel.org \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=hector.palacios@digi.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).