[PATCH 0/4] ARM: dts: qcom: apq8074-dragonboard enable DSI and remoteproc

[PATCH 0/4] ARM: dts: qcom: apq8074-dragonboard enable DSI and remoteproc

[Dmitry Baryshkov]

Enable GPU, DSI panel and remoteprocs on the APQ8074 dragonboard device.

Dmitry Baryshkov (4):
  ARM: dts: qcom: msm8974: add ocmem clock to GPU
  ARM: dts: qcom: apq8074-dragonboard: Set DMA as remotely controlled
  ARM: dts: qcom: apq8074-dragonboard: enable adsp and MSS
  ARM: dts: qcom: apq8074-dragonboard: enable DSI panel

 .../arm/boot/dts/qcom-apq8074-dragonboard.dts | 83 +++++++++++++++++++
 arch/arm/boot/dts/qcom-msm8974.dtsi           |  3 +-
 2 files changed, 85 insertions(+), 1 deletion(-)

-- 
2.39.2

[PATCH 1/4] ARM: dts: qcom: msm8974: add ocmem clock to GPU

[Dmitry Baryshkov]

To get GPU working with the OCMEM, the oxili_ocmemgx_clk clock should be
enabled. Pass it to the GPU to get it to work on apq8074/msm8974 boards.

Fixes: fe079442db63 ("ARM: dts: qcom: msm8974: add gpu support")
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 arch/arm/boot/dts/qcom-msm8974.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi
index 834ad95515b1..fb661c1bd3d5 100644
--- a/arch/arm/boot/dts/qcom-msm8974.dtsi
+++ b/arch/arm/boot/dts/qcom-msm8974.dtsi
@@ -2104,8 +2104,9 @@ gpu: adreno@fdb00000 {
 
 			clocks = <&mmcc OXILI_GFX3D_CLK>,
 				 <&mmcc OXILICX_AHB_CLK>,
+				 <&mmcc OXILI_OCMEMGX_CLK>,
 				 <&mmcc OXILICX_AXI_CLK>;
-			clock-names = "core", "iface", "mem_iface";
+			clock-names = "core", "iface", "mem", "mem_iface";
 
 			sram = <&gmu_sram>;
 			power-domains = <&mmcc OXILICX_GDSC>;
-- 
2.39.2

Re: [PATCH 1/4] ARM: dts: qcom: msm8974: add ocmem clock to GPU

[Konrad Dybcio]

On 7.05.2023 21:07, Dmitry Baryshkov wrote:
> To get GPU working with the OCMEM, the oxili_ocmemgx_clk clock should be
> enabled. Pass it to the GPU to get it to work on apq8074/msm8974 boards.
> 
> Fixes: fe079442db63 ("ARM: dts: qcom: msm8974: add gpu support")
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
Uhh.. this clock should be managed by RPM with:

type = MEM
id = 2

just like it's defined for 8994 today.

Could you try adding it in rpmcc and confirming?

Konrad
>  arch/arm/boot/dts/qcom-msm8974.dtsi | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi
> index 834ad95515b1..fb661c1bd3d5 100644
> --- a/arch/arm/boot/dts/qcom-msm8974.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi
> @@ -2104,8 +2104,9 @@ gpu: adreno@fdb00000 {
>  
>  			clocks = <&mmcc OXILI_GFX3D_CLK>,
>  				 <&mmcc OXILICX_AHB_CLK>,
> +				 <&mmcc OXILI_OCMEMGX_CLK>,
>  				 <&mmcc OXILICX_AXI_CLK>;
> -			clock-names = "core", "iface", "mem_iface";
> +			clock-names = "core", "iface", "mem", "mem_iface";
>  
>  			sram = <&gmu_sram>;
>  			power-domains = <&mmcc OXILICX_GDSC>;

Re: [PATCH 1/4] ARM: dts: qcom: msm8974: add ocmem clock to GPU

[Dmitry Baryshkov]

On 08/05/2023 11:30, Konrad Dybcio wrote:
> 
> 
> On 7.05.2023 21:07, Dmitry Baryshkov wrote:
>> To get GPU working with the OCMEM, the oxili_ocmemgx_clk clock should be
>> enabled. Pass it to the GPU to get it to work on apq8074/msm8974 boards.
>>
>> Fixes: fe079442db63 ("ARM: dts: qcom: msm8974: add gpu support")
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> ---
> Uhh.. this clock should be managed by RPM with:
> 
> type = MEM
> id = 2
> 
> just like it's defined for 8994 today.
> 
> Could you try adding it in rpmcc and confirming?

There is an RPM_SMD_OCMEMGX_CLK clk already, it is a bus clock for the 
ocmemnoc.

> 
> Konrad
>>   arch/arm/boot/dts/qcom-msm8974.dtsi | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi
>> index 834ad95515b1..fb661c1bd3d5 100644
>> --- a/arch/arm/boot/dts/qcom-msm8974.dtsi
>> +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi
>> @@ -2104,8 +2104,9 @@ gpu: adreno@fdb00000 {
>>   
>>   			clocks = <&mmcc OXILI_GFX3D_CLK>,
>>   				 <&mmcc OXILICX_AHB_CLK>,
>> +				 <&mmcc OXILI_OCMEMGX_CLK>,
>>   				 <&mmcc OXILICX_AXI_CLK>;
>> -			clock-names = "core", "iface", "mem_iface";
>> +			clock-names = "core", "iface", "mem", "mem_iface";
>>   
>>   			sram = <&gmu_sram>;
>>   			power-domains = <&mmcc OXILICX_GDSC>;

-- 
With best wishes
Dmitry

Re: [PATCH 1/4] ARM: dts: qcom: msm8974: add ocmem clock to GPU

[Konrad Dybcio]

On 8.05.2023 12:24, Dmitry Baryshkov wrote:
> On 08/05/2023 11:30, Konrad Dybcio wrote:
>>
>>
>> On 7.05.2023 21:07, Dmitry Baryshkov wrote:
>>> To get GPU working with the OCMEM, the oxili_ocmemgx_clk clock should be
>>> enabled. Pass it to the GPU to get it to work on apq8074/msm8974 boards.
>>>
>>> Fixes: fe079442db63 ("ARM: dts: qcom: msm8974: add gpu support")
>>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>>> ---
>> Uhh.. this clock should be managed by RPM with:
>>
>> type = MEM
>> id = 2
>>
>> just like it's defined for 8994 today.
>>
>> Could you try adding it in rpmcc and confirming?
> 
> There is an RPM_SMD_OCMEMGX_CLK clk already, it is a bus clock for the ocmemnoc.
It's wrong.

Konrad
> 
>>
>> Konrad
>>>   arch/arm/boot/dts/qcom-msm8974.dtsi | 3 ++-
>>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi
>>> index 834ad95515b1..fb661c1bd3d5 100644
>>> --- a/arch/arm/boot/dts/qcom-msm8974.dtsi
>>> +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi
>>> @@ -2104,8 +2104,9 @@ gpu: adreno@fdb00000 {
>>>                 clocks = <&mmcc OXILI_GFX3D_CLK>,
>>>                    <&mmcc OXILICX_AHB_CLK>,
>>> +                 <&mmcc OXILI_OCMEMGX_CLK>,
>>>                    <&mmcc OXILICX_AXI_CLK>;
>>> -            clock-names = "core", "iface", "mem_iface";
>>> +            clock-names = "core", "iface", "mem", "mem_iface";
>>>                 sram = <&gmu_sram>;
>>>               power-domains = <&mmcc OXILICX_GDSC>;
> 

Re: [PATCH 1/4] ARM: dts: qcom: msm8974: add ocmem clock to GPU

[Dmitry Baryshkov]

On 08/05/2023 13:28, Konrad Dybcio wrote:
> 
> 
> On 8.05.2023 12:24, Dmitry Baryshkov wrote:
>> On 08/05/2023 11:30, Konrad Dybcio wrote:
>>>
>>>
>>> On 7.05.2023 21:07, Dmitry Baryshkov wrote:
>>>> To get GPU working with the OCMEM, the oxili_ocmemgx_clk clock should be
>>>> enabled. Pass it to the GPU to get it to work on apq8074/msm8974 boards.
>>>>
>>>> Fixes: fe079442db63 ("ARM: dts: qcom: msm8974: add gpu support")
>>>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>>>> ---
>>> Uhh.. this clock should be managed by RPM with:
>>>
>>> type = MEM
>>> id = 2
>>>
>>> just like it's defined for 8994 today.
>>>
>>> Could you try adding it in rpmcc and confirming?
>>
>> There is an RPM_SMD_OCMEMGX_CLK clk already, it is a bus clock for the ocmemnoc.
> It's wrong.

Can you possibly be more specific here?

On 8974 RPM_SMD_OCMEMGX_CLK is a core clock for ocmem and a bus clock 
for ocmemnoc.

On 8994 this clocks is just a core clock for ocmem, there is no ocmemnoc.


> 
> Konrad
>>
>>>
>>> Konrad
>>>>    arch/arm/boot/dts/qcom-msm8974.dtsi | 3 ++-
>>>>    1 file changed, 2 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi
>>>> index 834ad95515b1..fb661c1bd3d5 100644
>>>> --- a/arch/arm/boot/dts/qcom-msm8974.dtsi
>>>> +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi
>>>> @@ -2104,8 +2104,9 @@ gpu: adreno@fdb00000 {
>>>>                  clocks = <&mmcc OXILI_GFX3D_CLK>,
>>>>                     <&mmcc OXILICX_AHB_CLK>,
>>>> +                 <&mmcc OXILI_OCMEMGX_CLK>,
>>>>                     <&mmcc OXILICX_AXI_CLK>;
>>>> -            clock-names = "core", "iface", "mem_iface";
>>>> +            clock-names = "core", "iface", "mem", "mem_iface";
>>>>                  sram = <&gmu_sram>;
>>>>                power-domains = <&mmcc OXILICX_GDSC>;
>>

-- 
With best wishes
Dmitry

Re: [PATCH 1/4] ARM: dts: qcom: msm8974: add ocmem clock to GPU

[Konrad Dybcio]

On 8.05.2023 12:32, Dmitry Baryshkov wrote:
> On 08/05/2023 13:28, Konrad Dybcio wrote:
>>
>>
>> On 8.05.2023 12:24, Dmitry Baryshkov wrote:
>>> On 08/05/2023 11:30, Konrad Dybcio wrote:
>>>>
>>>>
>>>> On 7.05.2023 21:07, Dmitry Baryshkov wrote:
>>>>> To get GPU working with the OCMEM, the oxili_ocmemgx_clk clock should be
>>>>> enabled. Pass it to the GPU to get it to work on apq8074/msm8974 boards.
>>>>>
>>>>> Fixes: fe079442db63 ("ARM: dts: qcom: msm8974: add gpu support")
>>>>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>>>>> ---
>>>> Uhh.. this clock should be managed by RPM with:
>>>>
>>>> type = MEM
>>>> id = 2
>>>>
>>>> just like it's defined for 8994 today.
>>>>
>>>> Could you try adding it in rpmcc and confirming?
>>>
>>> There is an RPM_SMD_OCMEMGX_CLK clk already, it is a bus clock for the ocmemnoc.
>> It's wrong.
> 
> Can you possibly be more specific here?
> 
> On 8974 RPM_SMD_OCMEMGX_CLK is a core clock for ocmem and a bus clock for ocmemnoc.
The ocmemnoc bus is managed internally, the rpm clock is not used for scaling,
only to make sure the NIU is clocked for ocmem node access.

It's "scaled" with the ocmem-slv node, but the code never sets any rate,
only calls clk_get.

> 
> On 8994 this clocks is just a core clock for ocmem, there is no ocmemnoc.
It's there, named "fab-ovirt" and on 8994 it's actually used for scaling.

Konrad
> 
> 
>>
>> Konrad
>>>
>>>>
>>>> Konrad
>>>>>    arch/arm/boot/dts/qcom-msm8974.dtsi | 3 ++-
>>>>>    1 file changed, 2 insertions(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi
>>>>> index 834ad95515b1..fb661c1bd3d5 100644
>>>>> --- a/arch/arm/boot/dts/qcom-msm8974.dtsi
>>>>> +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi
>>>>> @@ -2104,8 +2104,9 @@ gpu: adreno@fdb00000 {
>>>>>                  clocks = <&mmcc OXILI_GFX3D_CLK>,
>>>>>                     <&mmcc OXILICX_AHB_CLK>,
>>>>> +                 <&mmcc OXILI_OCMEMGX_CLK>,
>>>>>                     <&mmcc OXILICX_AXI_CLK>;
>>>>> -            clock-names = "core", "iface", "mem_iface";
>>>>> +            clock-names = "core", "iface", "mem", "mem_iface";
>>>>>                  sram = <&gmu_sram>;
>>>>>                power-domains = <&mmcc OXILICX_GDSC>;
>>>
> 

[PATCH 2/4] ARM: dts: qcom: apq8074-dragonboard: Set DMA as remotely controlled

[Dmitry Baryshkov]

Add the qcom,controlled-remotely property for the blsp2_bam
controller node. This board requires this, otherwise the board stalls
during the boot for some reason (most probably because TZ mishandles the
protection error and keeps on looping somewhere inside).

Fixes: 62bc81792223 dts: msm8974: Add blsp2_bam dma node
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 arch/arm/boot/dts/qcom-apq8074-dragonboard.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts b/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
index 1345df7cbd00..6b047c679370 100644
--- a/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
+++ b/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
@@ -23,6 +23,10 @@ &blsp1_uart2 {
 	status = "okay";
 };
 
+&blsp2_dma {
+	qcom,controlled-remotely;
+};
+
 &blsp2_i2c5 {
 	status = "okay";
 	clock-frequency = <200000>;
-- 
2.39.2

Re: [PATCH 2/4] ARM: dts: qcom: apq8074-dragonboard: Set DMA as remotely controlled

[Konrad Dybcio]

On 7.05.2023 21:07, Dmitry Baryshkov wrote:
> Add the qcom,controlled-remotely property for the blsp2_bam
> controller node. This board requires this, otherwise the board stalls
> during the boot for some reason (most probably because TZ mishandles the
> protection error and keeps on looping somewhere inside).
> 
> Fixes: 62bc81792223 dts: msm8974: Add blsp2_bam dma node
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
Looks like a common theme.. sony-rhine boards also have the DMA
enabled *and* need this property.. perhaps it's a SoC-wide (or
at least SoC-and-fw-distribution-wide) issue?

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm/boot/dts/qcom-apq8074-dragonboard.dts | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts b/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
> index 1345df7cbd00..6b047c679370 100644
> --- a/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
> +++ b/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
> @@ -23,6 +23,10 @@ &blsp1_uart2 {
>  	status = "okay";
>  };
>  
> +&blsp2_dma {
> +	qcom,controlled-remotely;
> +};
> +
>  &blsp2_i2c5 {
>  	status = "okay";
>  	clock-frequency = <200000>;

Re: [PATCH 2/4] ARM: dts: qcom: apq8074-dragonboard: Set DMA as remotely controlled

[Dmitry Baryshkov]

On 08/05/2023 11:32, Konrad Dybcio wrote:
> 
> 
> On 7.05.2023 21:07, Dmitry Baryshkov wrote:
>> Add the qcom,controlled-remotely property for the blsp2_bam
>> controller node. This board requires this, otherwise the board stalls
>> during the boot for some reason (most probably because TZ mishandles the
>> protection error and keeps on looping somewhere inside).
>>
>> Fixes: 62bc81792223 dts: msm8974: Add blsp2_bam dma node
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> ---
> Looks like a common theme.. sony-rhine boards also have the DMA
> enabled *and* need this property.. perhaps it's a SoC-wide (or
> at least SoC-and-fw-distribution-wide) issue?

This looks like a strange history. Especially granted 338d51889851 
("Revert "dts: msm8974: Add blsp2_bam dma node"") and d44cbb1e9ca3 
("Revert "Revert "dts: msm8974: Add blsp2_bam dma node""")

And, of course, 
https://lore.kernel.org/linux-arm-msm/CAJAp7Oi33=kraAiU337JdFJZbuKZEVoCtY4FfAv_RgiWVmz+sw@mail.gmail.com/

Note, 338d51889851 mentions non-dragonboard boards. This makes me think 
that for some of the dragonboards/firmware combos this device was 
working as is, without controlled remotely. I could not get 'the latest 
bootloader package' (if there was one), so I'm stuck with what I have on 
my board. However there is no guarantee that it is the latest and 
greatest stuff.

Thus said, for this patch I decided to follow the rhino example and add 
this to the board file. Unless Bjorn (or anybody else remembering those 
times) can advise us.

> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> 
> Konrad
>>   arch/arm/boot/dts/qcom-apq8074-dragonboard.dts | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts b/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
>> index 1345df7cbd00..6b047c679370 100644
>> --- a/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
>> +++ b/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
>> @@ -23,6 +23,10 @@ &blsp1_uart2 {
>>   	status = "okay";
>>   };
>>   
>> +&blsp2_dma {
>> +	qcom,controlled-remotely;
>> +};
>> +
>>   &blsp2_i2c5 {
>>   	status = "okay";
>>   	clock-frequency = <200000>;

-- 
With best wishes
Dmitry

[PATCH 3/4] ARM: dts: qcom: apq8074-dragonboard: enable adsp and MSS

[Dmitry Baryshkov]

Enable ADSP and Modem DSPs on APQ8074 dragonboard. The MSS region
differs from the one defined in the msm8974, so it overriden locally.

The modem is specified use mba.mbn instead of mbn.b00 (for the sake of
similarity with other platforms). This requires a patch for remoteproc
to be applied [1].

[1] https://lore.kernel.org/all/20230507172041.2320279-1-dmitry.baryshkov@linaro.org/

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 .../arm/boot/dts/qcom-apq8074-dragonboard.dts | 28 +++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts b/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
index 6b047c679370..c893afc00eb4 100644
--- a/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
+++ b/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
@@ -4,6 +4,8 @@
 #include "qcom-pm8841.dtsi"
 #include "qcom-pm8941.dtsi"
 
+/delete-node/ &mpss_region;
+
 / {
 	model = "Qualcomm APQ8074 Dragonboard";
 	compatible = "qcom,apq8074-dragonboard", "qcom,apq8074";
@@ -17,6 +19,13 @@ aliases {
 	chosen {
 		stdout-path = "serial0:115200n8";
 	};
+
+	reserved-memory {
+		mpss_region: mpss@ac00000 {
+			reg = <0x0ac00000 0x2500000>;
+			no-map;
+		};
+	};
 };
 
 &blsp1_uart2 {
@@ -39,6 +48,25 @@ eeprom: eeprom@52 {
 	};
 };
 
+&remoteproc_adsp {
+	cx-supply = <&pm8841_s2>;
+
+	firmware-name = "qcom/apq8074/adsp.mbn";
+
+	status = "okay";
+};
+
+&remoteproc_mss {
+	cx-supply = <&pm8841_s2>;
+	mss-supply = <&pm8841_s3>;
+	mx-supply = <&pm8841_s1>;
+	pll-supply = <&pm8941_l12>;
+
+	firmware-name = "qcom/apq8074/mba.mbn", "qcom/apq8074/modem.mbn";
+
+	status = "okay";
+};
+
 &rpm_requests {
 	regulators-0 {
 		compatible = "qcom,rpm-pm8841-regulators";
-- 
2.39.2

Re: [PATCH 3/4] ARM: dts: qcom: apq8074-dragonboard: enable adsp and MSS

[Konrad Dybcio]

On 7.05.2023 21:07, Dmitry Baryshkov wrote:
> Enable ADSP and Modem DSPs on APQ8074 dragonboard. The MSS region
> differs from the one defined in the msm8974, so it overriden locally.
> 
> The modem is specified use mba.mbn instead of mbn.b00 (for the sake of
> similarity with other platforms). This requires a patch for remoteproc
> to be applied [1].
> 
> [1] https://lore.kernel.org/all/20230507172041.2320279-1-dmitry.baryshkov@linaro.org/
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>  .../arm/boot/dts/qcom-apq8074-dragonboard.dts | 28 +++++++++++++++++++
>  1 file changed, 28 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts b/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
> index 6b047c679370..c893afc00eb4 100644
> --- a/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
> +++ b/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
> @@ -4,6 +4,8 @@
>  #include "qcom-pm8841.dtsi"
>  #include "qcom-pm8941.dtsi"
>  
> +/delete-node/ &mpss_region;
> +
>  / {
>  	model = "Qualcomm APQ8074 Dragonboard";
>  	compatible = "qcom,apq8074-dragonboard", "qcom,apq8074";
> @@ -17,6 +19,13 @@ aliases {
>  	chosen {
>  		stdout-path = "serial0:115200n8";
>  	};
> +
> +	reserved-memory {
> +		mpss_region: mpss@ac00000 {
> +			reg = <0x0ac00000 0x2500000>;
> +			no-map;
> +		};
> +	};
>  };
>  
>  &blsp1_uart2 {
> @@ -39,6 +48,25 @@ eeprom: eeprom@52 {
>  	};
>  };
>  
> +&remoteproc_adsp {
> +	cx-supply = <&pm8841_s2>;
> +
> +	firmware-name = "qcom/apq8074/adsp.mbn";
> +
> +	status = "okay";
> +};
> +
> +&remoteproc_mss {
> +	cx-supply = <&pm8841_s2>;
> +	mss-supply = <&pm8841_s3>;
> +	mx-supply = <&pm8841_s1>;
> +	pll-supply = <&pm8941_l12>;
High time to move this to rpmpd!
I won't object to adding this though, as it obviously works
and is already used on other boards..

> +
> +	firmware-name = "qcom/apq8074/mba.mbn", "qcom/apq8074/modem.mbn";
Could you please keep it one entry per line?

Otherwise,

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
> +
> +	status = "okay";
> +};
> +
>  &rpm_requests {
>  	regulators-0 {
>  		compatible = "qcom,rpm-pm8841-regulators";

Re: [PATCH 3/4] ARM: dts: qcom: apq8074-dragonboard: enable adsp and MSS

[Dmitry Baryshkov]

On 08/05/2023 11:33, Konrad Dybcio wrote:
> 
> 
> On 7.05.2023 21:07, Dmitry Baryshkov wrote:
>> Enable ADSP and Modem DSPs on APQ8074 dragonboard. The MSS region
>> differs from the one defined in the msm8974, so it overriden locally.
>>
>> The modem is specified use mba.mbn instead of mbn.b00 (for the sake of
>> similarity with other platforms). This requires a patch for remoteproc
>> to be applied [1].
>>
>> [1] https://lore.kernel.org/all/20230507172041.2320279-1-dmitry.baryshkov@linaro.org/
>>
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> ---
>>   .../arm/boot/dts/qcom-apq8074-dragonboard.dts | 28 +++++++++++++++++++
>>   1 file changed, 28 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts b/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
>> index 6b047c679370..c893afc00eb4 100644
>> --- a/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
>> +++ b/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
>> @@ -4,6 +4,8 @@
>>   #include "qcom-pm8841.dtsi"
>>   #include "qcom-pm8941.dtsi"
>>   
>> +/delete-node/ &mpss_region;
>> +
>>   / {
>>   	model = "Qualcomm APQ8074 Dragonboard";
>>   	compatible = "qcom,apq8074-dragonboard", "qcom,apq8074";
>> @@ -17,6 +19,13 @@ aliases {
>>   	chosen {
>>   		stdout-path = "serial0:115200n8";
>>   	};
>> +
>> +	reserved-memory {
>> +		mpss_region: mpss@ac00000 {
>> +			reg = <0x0ac00000 0x2500000>;
>> +			no-map;
>> +		};
>> +	};
>>   };
>>   
>>   &blsp1_uart2 {
>> @@ -39,6 +48,25 @@ eeprom: eeprom@52 {
>>   	};
>>   };
>>   
>> +&remoteproc_adsp {
>> +	cx-supply = <&pm8841_s2>;
>> +
>> +	firmware-name = "qcom/apq8074/adsp.mbn";
>> +
>> +	status = "okay";
>> +};
>> +
>> +&remoteproc_mss {
>> +	cx-supply = <&pm8841_s2>;
>> +	mss-supply = <&pm8841_s3>;
>> +	mx-supply = <&pm8841_s1>;
>> +	pll-supply = <&pm8941_l12>;
> High time to move this to rpmpd!
> I won't object to adding this though, as it obviously works
> and is already used on other boards..

I think the problem is that they are not level-voted on this platform, 
so they are regulators, not PDs.

> 
>> +
>> +	firmware-name = "qcom/apq8074/mba.mbn", "qcom/apq8074/modem.mbn";
> Could you please keep it one entry per line?

Sure.

> 
> Otherwise,
> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> 
> Konrad
>> +
>> +	status = "okay";
>> +};
>> +
>>   &rpm_requests {
>>   	regulators-0 {
>>   		compatible = "qcom,rpm-pm8841-regulators";

-- 
With best wishes
Dmitry

Re: [PATCH 3/4] ARM: dts: qcom: apq8074-dragonboard: enable adsp and MSS

[Konrad Dybcio]

On 8.05.2023 12:33, Dmitry Baryshkov wrote:
> On 08/05/2023 11:33, Konrad Dybcio wrote:
>>
>>
>> On 7.05.2023 21:07, Dmitry Baryshkov wrote:
>>> Enable ADSP and Modem DSPs on APQ8074 dragonboard. The MSS region
>>> differs from the one defined in the msm8974, so it overriden locally.
>>>
>>> The modem is specified use mba.mbn instead of mbn.b00 (for the sake of
>>> similarity with other platforms). This requires a patch for remoteproc
>>> to be applied [1].
>>>
>>> [1] https://lore.kernel.org/all/20230507172041.2320279-1-dmitry.baryshkov@linaro.org/
>>>
>>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>>> ---
>>>   .../arm/boot/dts/qcom-apq8074-dragonboard.dts | 28 +++++++++++++++++++
>>>   1 file changed, 28 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts b/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
>>> index 6b047c679370..c893afc00eb4 100644
>>> --- a/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
>>> +++ b/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
>>> @@ -4,6 +4,8 @@
>>>   #include "qcom-pm8841.dtsi"
>>>   #include "qcom-pm8941.dtsi"
>>>   +/delete-node/ &mpss_region;
>>> +
>>>   / {
>>>       model = "Qualcomm APQ8074 Dragonboard";
>>>       compatible = "qcom,apq8074-dragonboard", "qcom,apq8074";
>>> @@ -17,6 +19,13 @@ aliases {
>>>       chosen {
>>>           stdout-path = "serial0:115200n8";
>>>       };
>>> +
>>> +    reserved-memory {
>>> +        mpss_region: mpss@ac00000 {
>>> +            reg = <0x0ac00000 0x2500000>;
>>> +            no-map;
>>> +        };
>>> +    };
>>>   };
>>>     &blsp1_uart2 {
>>> @@ -39,6 +48,25 @@ eeprom: eeprom@52 {
>>>       };
>>>   };
>>>   +&remoteproc_adsp {
>>> +    cx-supply = <&pm8841_s2>;
>>> +
>>> +    firmware-name = "qcom/apq8074/adsp.mbn";
>>> +
>>> +    status = "okay";
>>> +};
>>> +
>>> +&remoteproc_mss {
>>> +    cx-supply = <&pm8841_s2>;
>>> +    mss-supply = <&pm8841_s3>;
>>> +    mx-supply = <&pm8841_s1>;
>>> +    pll-supply = <&pm8941_l12>;
>> High time to move this to rpmpd!
>> I won't object to adding this though, as it obviously works
>> and is already used on other boards..
> 
> I think the problem is that they are not level-voted on this platform, so they are regulators, not PDs.
They're corner-voted.

Konrad
> 
>>
>>> +
>>> +    firmware-name = "qcom/apq8074/mba.mbn", "qcom/apq8074/modem.mbn";
>> Could you please keep it one entry per line?
> 
> Sure.
> 
>>
>> Otherwise,
>>
>> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>>
>> Konrad
>>> +
>>> +    status = "okay";
>>> +};
>>> +
>>>   &rpm_requests {
>>>       regulators-0 {
>>>           compatible = "qcom,rpm-pm8841-regulators";
> 

Re: [PATCH 3/4] ARM: dts: qcom: apq8074-dragonboard: enable adsp and MSS

[Dmitry Baryshkov]

On 08/05/2023 13:38, Konrad Dybcio wrote:
> 
> 
> On 8.05.2023 12:33, Dmitry Baryshkov wrote:
>> On 08/05/2023 11:33, Konrad Dybcio wrote:
>>>
>>>
>>> On 7.05.2023 21:07, Dmitry Baryshkov wrote:
>>>> Enable ADSP and Modem DSPs on APQ8074 dragonboard. The MSS region
>>>> differs from the one defined in the msm8974, so it overriden locally.
>>>>
>>>> The modem is specified use mba.mbn instead of mbn.b00 (for the sake of
>>>> similarity with other platforms). This requires a patch for remoteproc
>>>> to be applied [1].
>>>>
>>>> [1] https://lore.kernel.org/all/20230507172041.2320279-1-dmitry.baryshkov@linaro.org/
>>>>
>>>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>>>> ---
>>>>    .../arm/boot/dts/qcom-apq8074-dragonboard.dts | 28 +++++++++++++++++++
>>>>    1 file changed, 28 insertions(+)
>>>>
>>>> diff --git a/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts b/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
>>>> index 6b047c679370..c893afc00eb4 100644
>>>> --- a/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
>>>> +++ b/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
>>>> @@ -4,6 +4,8 @@
>>>>    #include "qcom-pm8841.dtsi"
>>>>    #include "qcom-pm8941.dtsi"
>>>>    +/delete-node/ &mpss_region;
>>>> +
>>>>    / {
>>>>        model = "Qualcomm APQ8074 Dragonboard";
>>>>        compatible = "qcom,apq8074-dragonboard", "qcom,apq8074";
>>>> @@ -17,6 +19,13 @@ aliases {
>>>>        chosen {
>>>>            stdout-path = "serial0:115200n8";
>>>>        };
>>>> +
>>>> +    reserved-memory {
>>>> +        mpss_region: mpss@ac00000 {
>>>> +            reg = <0x0ac00000 0x2500000>;
>>>> +            no-map;
>>>> +        };
>>>> +    };
>>>>    };
>>>>      &blsp1_uart2 {
>>>> @@ -39,6 +48,25 @@ eeprom: eeprom@52 {
>>>>        };
>>>>    };
>>>>    +&remoteproc_adsp {
>>>> +    cx-supply = <&pm8841_s2>;
>>>> +
>>>> +    firmware-name = "qcom/apq8074/adsp.mbn";
>>>> +
>>>> +    status = "okay";
>>>> +};
>>>> +
>>>> +&remoteproc_mss {
>>>> +    cx-supply = <&pm8841_s2>;
>>>> +    mss-supply = <&pm8841_s3>;
>>>> +    mx-supply = <&pm8841_s1>;
>>>> +    pll-supply = <&pm8941_l12>;
>>> High time to move this to rpmpd!
>>> I won't object to adding this though, as it obviously works
>>> and is already used on other boards..
>>
>> I think the problem is that they are not level-voted on this platform, so they are regulators, not PDs.
> They're corner-voted.

Hmm. Indeed. In msm8974-regulators I see both voltage and corner entries 
for these regulators.

> 
> Konrad
>>
>>>
>>>> +
>>>> +    firmware-name = "qcom/apq8074/mba.mbn", "qcom/apq8074/modem.mbn";
>>> Could you please keep it one entry per line?
>>
>> Sure.
>>
>>>
>>> Otherwise,
>>>
>>> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>>>
>>> Konrad
>>>> +
>>>> +    status = "okay";
>>>> +};
>>>> +
>>>>    &rpm_requests {
>>>>        regulators-0 {
>>>>            compatible = "qcom,rpm-pm8841-regulators";
>>

-- 
With best wishes
Dmitry

Re: [PATCH 3/4] ARM: dts: qcom: apq8074-dragonboard: enable adsp and MSS

[Dmitry Baryshkov]

On 08/05/2023 13:49, Dmitry Baryshkov wrote:
> On 08/05/2023 13:38, Konrad Dybcio wrote:
>>
>>
>> On 8.05.2023 12:33, Dmitry Baryshkov wrote:
>>> On 08/05/2023 11:33, Konrad Dybcio wrote:
>>>>
>>>>
>>>> On 7.05.2023 21:07, Dmitry Baryshkov wrote:
>>>>> Enable ADSP and Modem DSPs on APQ8074 dragonboard. The MSS region
>>>>> differs from the one defined in the msm8974, so it overriden locally.
>>>>>
>>>>> The modem is specified use mba.mbn instead of mbn.b00 (for the sake of
>>>>> similarity with other platforms). This requires a patch for remoteproc
>>>>> to be applied [1].
>>>>>
>>>>> [1] 
>>>>> https://lore.kernel.org/all/20230507172041.2320279-1-dmitry.baryshkov@linaro.org/
>>>>>
>>>>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>>>>> ---
>>>>>    .../arm/boot/dts/qcom-apq8074-dragonboard.dts | 28 
>>>>> +++++++++++++++++++
>>>>>    1 file changed, 28 insertions(+)
>>>>>
>>>>> diff --git a/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts 
>>>>> b/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
>>>>> index 6b047c679370..c893afc00eb4 100644
>>>>> --- a/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
>>>>> +++ b/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
>>>>> @@ -4,6 +4,8 @@
>>>>>    #include "qcom-pm8841.dtsi"
>>>>>    #include "qcom-pm8941.dtsi"
>>>>>    +/delete-node/ &mpss_region;
>>>>> +
>>>>>    / {
>>>>>        model = "Qualcomm APQ8074 Dragonboard";
>>>>>        compatible = "qcom,apq8074-dragonboard", "qcom,apq8074";
>>>>> @@ -17,6 +19,13 @@ aliases {
>>>>>        chosen {
>>>>>            stdout-path = "serial0:115200n8";
>>>>>        };
>>>>> +
>>>>> +    reserved-memory {
>>>>> +        mpss_region: mpss@ac00000 {
>>>>> +            reg = <0x0ac00000 0x2500000>;
>>>>> +            no-map;
>>>>> +        };
>>>>> +    };
>>>>>    };
>>>>>      &blsp1_uart2 {
>>>>> @@ -39,6 +48,25 @@ eeprom: eeprom@52 {
>>>>>        };
>>>>>    };
>>>>>    +&remoteproc_adsp {
>>>>> +    cx-supply = <&pm8841_s2>;
>>>>> +
>>>>> +    firmware-name = "qcom/apq8074/adsp.mbn";
>>>>> +
>>>>> +    status = "okay";
>>>>> +};
>>>>> +
>>>>> +&remoteproc_mss {
>>>>> +    cx-supply = <&pm8841_s2>;
>>>>> +    mss-supply = <&pm8841_s3>;
>>>>> +    mx-supply = <&pm8841_s1>;
>>>>> +    pll-supply = <&pm8941_l12>;
>>>> High time to move this to rpmpd!
>>>> I won't object to adding this though, as it obviously works
>>>> and is already used on other boards..
>>>
>>> I think the problem is that they are not level-voted on this 
>>> platform, so they are regulators, not PDs.
>> They're corner-voted.
> 
> Hmm. Indeed. In msm8974-regulators I see both voltage and corner entries 
> for these regulators.

Checked. Only CX and GFX (yes, MX not included) are enabled as corners 
in vendor dtsi. So this probably doesn't gain us a lot.

> 
>>
>> Konrad
>>>
>>>>
>>>>> +
>>>>> +    firmware-name = "qcom/apq8074/mba.mbn", "qcom/apq8074/modem.mbn";
>>>> Could you please keep it one entry per line?
>>>
>>> Sure.
>>>
>>>>
>>>> Otherwise,
>>>>
>>>> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>>>>
>>>> Konrad
>>>>> +
>>>>> +    status = "okay";
>>>>> +};
>>>>> +
>>>>>    &rpm_requests {
>>>>>        regulators-0 {
>>>>>            compatible = "qcom,rpm-pm8841-regulators";
>>>
> 

-- 
With best wishes
Dmitry

Re: [PATCH 3/4] ARM: dts: qcom: apq8074-dragonboard: enable adsp and MSS

[Dmitry Baryshkov]

On Mon, 8 May 2023 at 21:01, Dmitry Baryshkov
<dmitry.baryshkov@linaro.org> wrote:
>
> On 08/05/2023 13:49, Dmitry Baryshkov wrote:
> > On 08/05/2023 13:38, Konrad Dybcio wrote:
> >>
> >>
> >> On 8.05.2023 12:33, Dmitry Baryshkov wrote:
> >>> On 08/05/2023 11:33, Konrad Dybcio wrote:
> >>>>
> >>>>
> >>>> On 7.05.2023 21:07, Dmitry Baryshkov wrote:
> >>>>> Enable ADSP and Modem DSPs on APQ8074 dragonboard. The MSS region
> >>>>> differs from the one defined in the msm8974, so it overriden locally.
> >>>>>
> >>>>> The modem is specified use mba.mbn instead of mbn.b00 (for the sake of
> >>>>> similarity with other platforms). This requires a patch for remoteproc
> >>>>> to be applied [1].
> >>>>>
> >>>>> [1]
> >>>>> https://lore.kernel.org/all/20230507172041.2320279-1-dmitry.baryshkov@linaro.org/
> >>>>>
> >>>>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> >>>>> ---
> >>>>>    .../arm/boot/dts/qcom-apq8074-dragonboard.dts | 28
> >>>>> +++++++++++++++++++
> >>>>>    1 file changed, 28 insertions(+)
> >>>>>
> >>>>> diff --git a/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
> >>>>> b/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
> >>>>> index 6b047c679370..c893afc00eb4 100644
> >>>>> --- a/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
> >>>>> +++ b/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
> >>>>> @@ -4,6 +4,8 @@
> >>>>>    #include "qcom-pm8841.dtsi"
> >>>>>    #include "qcom-pm8941.dtsi"
> >>>>>    +/delete-node/ &mpss_region;
> >>>>> +
> >>>>>    / {
> >>>>>        model = "Qualcomm APQ8074 Dragonboard";
> >>>>>        compatible = "qcom,apq8074-dragonboard", "qcom,apq8074";
> >>>>> @@ -17,6 +19,13 @@ aliases {
> >>>>>        chosen {
> >>>>>            stdout-path = "serial0:115200n8";
> >>>>>        };
> >>>>> +
> >>>>> +    reserved-memory {
> >>>>> +        mpss_region: mpss@ac00000 {
> >>>>> +            reg = <0x0ac00000 0x2500000>;
> >>>>> +            no-map;
> >>>>> +        };
> >>>>> +    };
> >>>>>    };
> >>>>>      &blsp1_uart2 {
> >>>>> @@ -39,6 +48,25 @@ eeprom: eeprom@52 {
> >>>>>        };
> >>>>>    };
> >>>>>    +&remoteproc_adsp {
> >>>>> +    cx-supply = <&pm8841_s2>;
> >>>>> +
> >>>>> +    firmware-name = "qcom/apq8074/adsp.mbn";
> >>>>> +
> >>>>> +    status = "okay";
> >>>>> +};
> >>>>> +
> >>>>> +&remoteproc_mss {
> >>>>> +    cx-supply = <&pm8841_s2>;
> >>>>> +    mss-supply = <&pm8841_s3>;
> >>>>> +    mx-supply = <&pm8841_s1>;
> >>>>> +    pll-supply = <&pm8941_l12>;
> >>>> High time to move this to rpmpd!
> >>>> I won't object to adding this though, as it obviously works
> >>>> and is already used on other boards..
> >>>
> >>> I think the problem is that they are not level-voted on this
> >>> platform, so they are regulators, not PDs.
> >> They're corner-voted.
> >
> > Hmm. Indeed. In msm8974-regulators I see both voltage and corner entries
> > for these regulators.
>
> Checked. Only CX and GFX (yes, MX not included) are enabled as corners
> in vendor dtsi. So this probably doesn't gain us a lot.

I did a check. Implementing CX as a powerdomain here makes things
worse for now. We should first teach mss/pas/etc drivers to properly
handle the case when there is a single power-domain, which should be
unbound after staring the DSP Consider e.g. ADSP and CDSP on sm8150 or
CDSP on sm8250. But that's definitely a topic for a different patch
series. After that we can consider landing msm8974_genpd.

>
> >
> >>
> >> Konrad
> >>>
> >>>>
> >>>>> +
> >>>>> +    firmware-name = "qcom/apq8074/mba.mbn", "qcom/apq8074/modem.mbn";
> >>>> Could you please keep it one entry per line?
> >>>
> >>> Sure.
> >>>
> >>>>
> >>>> Otherwise,
> >>>>
> >>>> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> >>>>
> >>>> Konrad
> >>>>> +
> >>>>> +    status = "okay";
> >>>>> +};
> >>>>> +
> >>>>>    &rpm_requests {
> >>>>>        regulators-0 {
> >>>>>            compatible = "qcom,rpm-pm8841-regulators";
> >>>
> >
>
> --
> With best wishes
> Dmitry
>


-- 
With best wishes
Dmitry

Re: [PATCH 3/4] ARM: dts: qcom: apq8074-dragonboard: enable adsp and MSS

[Konrad Dybcio]

On 9.05.2023 01:38, Dmitry Baryshkov wrote:
> On Mon, 8 May 2023 at 21:01, Dmitry Baryshkov
> <dmitry.baryshkov@linaro.org> wrote:
>>
>> On 08/05/2023 13:49, Dmitry Baryshkov wrote:
>>> On 08/05/2023 13:38, Konrad Dybcio wrote:
>>>>
>>>>
>>>> On 8.05.2023 12:33, Dmitry Baryshkov wrote:
>>>>> On 08/05/2023 11:33, Konrad Dybcio wrote:
>>>>>>
>>>>>>
>>>>>> On 7.05.2023 21:07, Dmitry Baryshkov wrote:
>>>>>>> Enable ADSP and Modem DSPs on APQ8074 dragonboard. The MSS region
>>>>>>> differs from the one defined in the msm8974, so it overriden locally.
>>>>>>>
>>>>>>> The modem is specified use mba.mbn instead of mbn.b00 (for the sake of
>>>>>>> similarity with other platforms). This requires a patch for remoteproc
>>>>>>> to be applied [1].
>>>>>>>
>>>>>>> [1]
>>>>>>> https://lore.kernel.org/all/20230507172041.2320279-1-dmitry.baryshkov@linaro.org/
>>>>>>>
>>>>>>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>>>>>>> ---
>>>>>>>    .../arm/boot/dts/qcom-apq8074-dragonboard.dts | 28
>>>>>>> +++++++++++++++++++
>>>>>>>    1 file changed, 28 insertions(+)
>>>>>>>
>>>>>>> diff --git a/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
>>>>>>> b/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
>>>>>>> index 6b047c679370..c893afc00eb4 100644
>>>>>>> --- a/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
>>>>>>> +++ b/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
>>>>>>> @@ -4,6 +4,8 @@
>>>>>>>    #include "qcom-pm8841.dtsi"
>>>>>>>    #include "qcom-pm8941.dtsi"
>>>>>>>    +/delete-node/ &mpss_region;
>>>>>>> +
>>>>>>>    / {
>>>>>>>        model = "Qualcomm APQ8074 Dragonboard";
>>>>>>>        compatible = "qcom,apq8074-dragonboard", "qcom,apq8074";
>>>>>>> @@ -17,6 +19,13 @@ aliases {
>>>>>>>        chosen {
>>>>>>>            stdout-path = "serial0:115200n8";
>>>>>>>        };
>>>>>>> +
>>>>>>> +    reserved-memory {
>>>>>>> +        mpss_region: mpss@ac00000 {
>>>>>>> +            reg = <0x0ac00000 0x2500000>;
>>>>>>> +            no-map;
>>>>>>> +        };
>>>>>>> +    };
>>>>>>>    };
>>>>>>>      &blsp1_uart2 {
>>>>>>> @@ -39,6 +48,25 @@ eeprom: eeprom@52 {
>>>>>>>        };
>>>>>>>    };
>>>>>>>    +&remoteproc_adsp {
>>>>>>> +    cx-supply = <&pm8841_s2>;
>>>>>>> +
>>>>>>> +    firmware-name = "qcom/apq8074/adsp.mbn";
>>>>>>> +
>>>>>>> +    status = "okay";
>>>>>>> +};
>>>>>>> +
>>>>>>> +&remoteproc_mss {
>>>>>>> +    cx-supply = <&pm8841_s2>;
>>>>>>> +    mss-supply = <&pm8841_s3>;
>>>>>>> +    mx-supply = <&pm8841_s1>;
>>>>>>> +    pll-supply = <&pm8941_l12>;
>>>>>> High time to move this to rpmpd!
>>>>>> I won't object to adding this though, as it obviously works
>>>>>> and is already used on other boards..
>>>>>
>>>>> I think the problem is that they are not level-voted on this
>>>>> platform, so they are regulators, not PDs.
>>>> They're corner-voted.
>>>
>>> Hmm. Indeed. In msm8974-regulators I see both voltage and corner entries
>>> for these regulators.
>>
>> Checked. Only CX and GFX (yes, MX not included) are enabled as corners
>> in vendor dtsi. So this probably doesn't gain us a lot.
> 
> I did a check. Implementing CX as a powerdomain here makes things
> worse for now. We should first teach mss/pas/etc drivers to properly
> handle the case when there is a single power-domain, which should be
> unbound after staring the DSP Consider e.g. ADSP and CDSP on sm8150 or
> CDSP on sm8250. But that's definitely a topic for a different patch
> series. After that we can consider landing msm8974_genpd.
Ack, thanks for looking into it.

Konrad
> 
>>
>>>
>>>>
>>>> Konrad
>>>>>
>>>>>>
>>>>>>> +
>>>>>>> +    firmware-name = "qcom/apq8074/mba.mbn", "qcom/apq8074/modem.mbn";
>>>>>> Could you please keep it one entry per line?
>>>>>
>>>>> Sure.
>>>>>
>>>>>>
>>>>>> Otherwise,
>>>>>>
>>>>>> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>>>>>>
>>>>>> Konrad
>>>>>>> +
>>>>>>> +    status = "okay";
>>>>>>> +};
>>>>>>> +
>>>>>>>    &rpm_requests {
>>>>>>>        regulators-0 {
>>>>>>>            compatible = "qcom,rpm-pm8841-regulators";
>>>>>
>>>
>>
>> --
>> With best wishes
>> Dmitry
>>
> 
> 

[PATCH 4/4] ARM: dts: qcom: apq8074-dragonboard: enable DSI panel

[Dmitry Baryshkov]

Enable MDSS, GPU and DSI panel output on the APQ8074 dragonboard.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 .../arm/boot/dts/qcom-apq8074-dragonboard.dts | 51 +++++++++++++++++++
 1 file changed, 51 insertions(+)

diff --git a/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts b/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
index c893afc00eb4..72f7e09a5bbf 100644
--- a/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
+++ b/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
@@ -48,6 +48,57 @@ eeprom: eeprom@52 {
 	};
 };
 
+&dsi0 {
+	vdda-supply = <&pm8941_l2>;
+	vdd-supply = <&pm8941_l22>;
+	vddio-supply = <&pm8941_l12>;
+
+	status = "okay";
+
+	panel: panel@0 {
+		compatible = "sharp,ls043t1le01-qhd";
+		reg = <0>;
+
+		avdd-supply = <&pm8941_l22>;
+		backlight = <&pm8941_wled>;
+		reset-gpios = <&pm8941_gpios 19 GPIO_ACTIVE_HIGH>;
+
+		port {
+			panel_in: endpoint {
+				remote-endpoint = <&dsi0_out>;
+			};
+		};
+	};
+};
+
+&dsi0_out {
+	remote-endpoint = <&panel_in>;
+	data-lanes = <0 1 2 3>;
+};
+
+&dsi0_phy {
+	status = "okay";
+
+	vddio-supply = <&pm8941_l12>;
+};
+
+&gpu {
+	status = "okay";
+};
+
+&mdss {
+	status = "okay";
+};
+
+&pm8941_wled {
+	qcom,cs-out;
+	qcom,switching-freq = <3200>;
+	qcom,ovp = <32>;
+	qcom,num-strings = <1>;
+
+	status = "okay";
+};
+
 &remoteproc_adsp {
 	cx-supply = <&pm8841_s2>;
 
-- 
2.39.2

Re: [PATCH 4/4] ARM: dts: qcom: apq8074-dragonboard: enable DSI panel

[Konrad Dybcio]

On 7.05.2023 21:07, Dmitry Baryshkov wrote:
> Enable MDSS, GPU and DSI panel output on the APQ8074 dragonboard.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>  .../arm/boot/dts/qcom-apq8074-dragonboard.dts | 51 +++++++++++++++++++
>  1 file changed, 51 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts b/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
> index c893afc00eb4..72f7e09a5bbf 100644
> --- a/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
> +++ b/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
> @@ -48,6 +48,57 @@ eeprom: eeprom@52 {
>  	};
>  };
>  
> +&dsi0 {
old junk could use some mdss_ prefixing to keep the nodes together

Could you please take care of that?

> +	vdda-supply = <&pm8941_l2>;
> +	vdd-supply = <&pm8941_l22>;
> +	vddio-supply = <&pm8941_l12>;
> +
> +	status = "okay";
> +
> +	panel: panel@0 {
> +		compatible = "sharp,ls043t1le01-qhd";
> +		reg = <0>;
> +
> +		avdd-supply = <&pm8941_l22>;
> +		backlight = <&pm8941_wled>;
> +		reset-gpios = <&pm8941_gpios 19 GPIO_ACTIVE_HIGH>;
> +
> +		port {
> +			panel_in: endpoint {
> +				remote-endpoint = <&dsi0_out>;
> +			};
> +		};
> +	};
> +};
> +
> +&dsi0_out {
> +	remote-endpoint = <&panel_in>;
> +	data-lanes = <0 1 2 3>;
> +};
> +
> +&dsi0_phy {
> +	status = "okay";
> +
> +	vddio-supply = <&pm8941_l12>;
status last

Konrad
> +};
> +
> +&gpu {
> +	status = "okay";
> +};
> +
> +&mdss {
> +	status = "okay";
> +};
> +
> +&pm8941_wled {
> +	qcom,cs-out;
> +	qcom,switching-freq = <3200>;
> +	qcom,ovp = <32>;
> +	qcom,num-strings = <1>;
> +
> +	status = "okay";
> +};
> +
>  &remoteproc_adsp {
>  	cx-supply = <&pm8841_s2>;
>  

Re: [PATCH 4/4] ARM: dts: qcom: apq8074-dragonboard: enable DSI panel

[Dmitry Baryshkov]

On 08/05/2023 11:34, Konrad Dybcio wrote:
> 
> 
> On 7.05.2023 21:07, Dmitry Baryshkov wrote:
>> Enable MDSS, GPU and DSI panel output on the APQ8074 dragonboard.
>>
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> ---
>>   .../arm/boot/dts/qcom-apq8074-dragonboard.dts | 51 +++++++++++++++++++
>>   1 file changed, 51 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts b/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
>> index c893afc00eb4..72f7e09a5bbf 100644
>> --- a/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
>> +++ b/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
>> @@ -48,6 +48,57 @@ eeprom: eeprom@52 {
>>   	};
>>   };
>>   
>> +&dsi0 {
> old junk could use some mdss_ prefixing to keep the nodes together
> 
> Could you please take care of that?

Ack

> 
>> +	vdda-supply = <&pm8941_l2>;
>> +	vdd-supply = <&pm8941_l22>;
>> +	vddio-supply = <&pm8941_l12>;
>> +
>> +	status = "okay";
>> +
>> +	panel: panel@0 {
>> +		compatible = "sharp,ls043t1le01-qhd";
>> +		reg = <0>;
>> +
>> +		avdd-supply = <&pm8941_l22>;
>> +		backlight = <&pm8941_wled>;
>> +		reset-gpios = <&pm8941_gpios 19 GPIO_ACTIVE_HIGH>;
>> +
>> +		port {
>> +			panel_in: endpoint {
>> +				remote-endpoint = <&dsi0_out>;
>> +			};
>> +		};
>> +	};
>> +};
>> +
>> +&dsi0_out {
>> +	remote-endpoint = <&panel_in>;
>> +	data-lanes = <0 1 2 3>;
>> +};
>> +
>> +&dsi0_phy {
>> +	status = "okay";
>> +
>> +	vddio-supply = <&pm8941_l12>;
> status last
> 
> Konrad
>> +};
>> +
>> +&gpu {
>> +	status = "okay";
>> +};
>> +
>> +&mdss {
>> +	status = "okay";
>> +};
>> +
>> +&pm8941_wled {
>> +	qcom,cs-out;
>> +	qcom,switching-freq = <3200>;
>> +	qcom,ovp = <32>;
>> +	qcom,num-strings = <1>;
>> +
>> +	status = "okay";
>> +};
>> +
>>   &remoteproc_adsp {
>>   	cx-supply = <&pm8841_s2>;
>>   

-- 
With best wishes
Dmitry

Re: (subset) [PATCH 0/4] ARM: dts: qcom: apq8074-dragonboard enable DSI and remoteproc

[Bjorn Andersson]

On Sun, 7 May 2023 22:07:31 +0300, Dmitry Baryshkov wrote:
> Enable GPU, DSI panel and remoteprocs on the APQ8074 dragonboard device.
> 
> Dmitry Baryshkov (4):
>   ARM: dts: qcom: msm8974: add ocmem clock to GPU
>   ARM: dts: qcom: apq8074-dragonboard: Set DMA as remotely controlled
>   ARM: dts: qcom: apq8074-dragonboard: enable adsp and MSS
>   ARM: dts: qcom: apq8074-dragonboard: enable DSI panel
> 
> [...]

Applied, thanks!

[2/4] ARM: dts: qcom: apq8074-dragonboard: Set DMA as remotely controlled
      commit: d184f79bd075871e2d16ce1ef739b22dedd3d928
[3/4] ARM: dts: qcom: apq8074-dragonboard: enable adsp and MSS
      commit: 3a0dda1a2553f97c0c8aebd181cd33e0eee5094d
[4/4] ARM: dts: qcom: apq8074-dragonboard: enable DSI panel
      commit: ac366501f64f83e03a0f6fd21b87188f92ce0e57

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>