From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4082621129E; Wed, 19 Mar 2025 08:49:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742374157; cv=none; b=O0lWfy+lorBJU6M6f/8HEWa2+StA6ZRjw4Tn4FPaKiNUeGTdIv3jM7fVOqDC3HHAfAEt6VuyCI4PHYN7ilLc+2R20pJ271udYyN4ToQ8+4NBdyNUNGfaES20SB0aWMlL/7X5k/Fjkal/zfC0elRNijW72RUXYvA9JfgA2EBzmAU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742374157; c=relaxed/simple; bh=Pc7OmAP3/6l/+cxajU8JvnMaWhla1SM9/gpPoX+sfco=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cMsXVUrsdd0Cw3kJcsB7uOFNs8sj1hk+eVa71q451bVCV3n1BTkJjSQMZzarZhW0tzWw5FSoOvRnC8Uyq8wIHha/FDHZ28R7eFVMs+iJ2rYDhd1ZM7MHSZG+/DJCtMbhIeu7EJk7Y9iy0hsk5h+1NcciJ1LcirhDdDInmroVXMc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QbX6Gb+T; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QbX6Gb+T" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 19523C4CEEE; Wed, 19 Mar 2025 08:49:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742374156; bh=Pc7OmAP3/6l/+cxajU8JvnMaWhla1SM9/gpPoX+sfco=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=QbX6Gb+Tvc18mdaUN9Dv0/p1p67bkNJmde/JkHRT47eo8FfBRYcvodDiB98XkoQKm eDegnXfrMmMbCMxzScBI1s0PTSPxkmruJfNrU4H5aKI5Dxa5aIXJDlYAiVPOEESodU Tnc2wjZrDXs7IAjJLg2cUC9zT4H7Wag7cMq607c2danXI1rOivcKzfSrJiM/cw9VgS SLX/HnGK6Wn4i/7Hp4Wy3VF+ZoBjgCSlIBbIWF9pfyy1mrRDWfui+8NlMBAi51kjIM bH+4wbHlNZKdIixqVdUiq94zui3vjtRUvynFirr+X3ylnUAIxyJCmLfFBqxbksGYwu DyNeaaJmvqyxg== Message-ID: <7bb26735-bd68-426a-ab0e-ec8379b39bdf@kernel.org> Date: Wed, 19 Mar 2025 09:49:06 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 6/6] arm64: dts: amlogic: Add Amlogic S4 Audio To: Jiebing Chen Cc: Jerome Brunet , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jaroslav Kysela , Takashi Iwai , Neil Armstrong , Kevin Hilman , Martin Blumenstingl , Michael Turquette , Stephen Boyd , linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, jian.xu@amlogic.com, shuai.li@amlogic.com, zhe.wang@amlogic.com References: <20250319-audio_drvier-v4-0-686867fad719@amlogic.com> <20250319-audio_drvier-v4-6-686867fad719@amlogic.com> <20250319-quizzical-coyote-of-assurance-d4c91d@krzk-bin> <6c1ca29e-37e4-488c-b3a3-f61aad7f8dcf@amlogic.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <6c1ca29e-37e4-488c-b3a3-f61aad7f8dcf@amlogic.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 19/03/2025 09:46, Jiebing Chen wrote: >>> + tdmif_b: audio-controller-1 { >>> + compatible = "amlogic,axg-tdm-iface"; >>> + #sound-dai-cells = <0>; >>> + sound-name-prefix = "TDM_B"; >>> + clocks = <&clkc_audio AUD_CLKID_MST_A_SCLK>, >>> + <&clkc_audio AUD_CLKID_MST_B_LRCLK>, >>> + <&clkc_audio AUD_CLKID_MST_B_MCLK>; >>> + clock-names = "sclk", "lrclk","mclk"; >>> + }; >>> + >>> + tdmif_c: audio-controller-2 { >>> + compatible = "amlogic,axg-tdm-iface"; >>> + #sound-dai-cells = <0>; >>> + sound-name-prefix = "TDM_C"; >>> + clocks = <&clkc_audio AUD_CLKID_MST_C_SCLK>, >>> + <&clkc_audio AUD_CLKID_MST_C_LRCLK>, >>> + <&clkc_audio AUD_CLKID_MST_C_MCLK>; >>> + clock-names = "sclk", "lrclk","mclk"; >>> + }; >>> + >>> timer { >>> compatible = "arm,armv8-timer"; >>> interrupts = , >>> @@ -101,7 +135,6 @@ apb4: bus@fe000000 { >>> #address-cells = <2>; >>> #size-cells = <2>; >>> ranges = <0x0 0x0 0x0 0xfe000000 0x0 0x480000>; >>> - >> Why? What is happening in this patch - why are you changing so many >> other pieces? > > Hi, Krzysztof > > for last versions ,it it not match the amlogic,axg-tdm-iface.yaml It is not what is happening here. Read replies and patches again. > > so we must be change the order, otherwise a warning will be thrown，we > copy the dts config from merged dts > > the old order not meet the dt-binding rule, Another change, we only add > the audio clock reg > > + compatible = "amlogic,s4-audio-clkc"; + reg = <0x0 0x0 0x0 0xd8>, > > add <0x0 0xE80 0x0 0x10>; > > We have not made any changes to the rest How is this even remotely related to my comment? It's still a NAK for reasons stated later which you decided to ignore. Best regards, Krzysztof