From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: daviewales@disroot.org, Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ARM: dts: qcom: Support Motorola Moto G2 (2014)
Date: Fri, 24 Apr 2026 11:15:27 +0200 [thread overview]
Message-ID: <7bd0105f-7e99-4799-a778-56f0131ee79b@oss.qualcomm.com> (raw)
In-Reply-To: <20260423-device-motorola-titan-mainline-v1-2-e1813a028cc8@disroot.org>
On 4/23/26 3:24 PM, David Wales via B4 Relay wrote:
> From: David Wales <daviewales@disroot.org>
>
> Add device tree for Motorola Moto G2 (2014) (motorola-titan) smartphone
> based on the Qualcomm MSM8226 SoC.
>
> Initially supported features:
> - Buttons (Volume Down/Up, Power)
> - eMMC
> - Hall Effect Sensor
> - Simple framebuffer display
> - Vibrator
>
> Based on device tree for similar device msm8226-motorola-falcon.
> Initial commit for falcon notes that dhob and shob reserved-memory
> regions seem to be related to a Motorola specific mechanism. [1]
>
> [1] https://github.com/LineageOS/android_kernel_motorola_msm8226/blob/cm-14.1/Documentation/devicetree/bindings/misc/hob_ram.txt
>
> Signed-off-by: David Wales <daviewales@disroot.org>
> ---
[...]
> +&tlmm {
> + reg_lcd_default: reg-lcd-default-state {
> + pins = "gpio12", "gpio13";
> + function = "gpio";
> + drive-strength = <2>;
> + bias-disable;
> + output-high;
This line will keep these regulators always-enabled, until (which
may perhaps never happen) the driver takes over, it should be
unnecessary
otherwise lgtm
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
prev parent reply other threads:[~2026-04-24 9:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-23 13:24 [PATCH 0/2] Add initial device tree for Motorola Moto G (2014) David Wales via B4 Relay
2026-04-23 13:24 ` [PATCH 1/2] dt-bindings: arm: qcom: Add Motorola Moto G2 (2014) David Wales via B4 Relay
2026-04-24 9:18 ` Krzysztof Kozlowski
2026-04-23 13:24 ` [PATCH 2/2] ARM: dts: qcom: Support " David Wales via B4 Relay
2026-04-24 9:15 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7bd0105f-7e99-4799-a778-56f0131ee79b@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daviewales@disroot.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox