* [PATCH] MIPS: dts: bcm63268: Add missing properties to the TWD node
@ 2022-12-20 19:09 Florian Fainelli
2022-12-20 22:23 ` Philippe Mathieu-Daudé
2022-12-21 13:06 ` Thomas Bogendoerfer
0 siblings, 2 replies; 4+ messages in thread
From: Florian Fainelli @ 2022-12-20 19:09 UTC (permalink / raw)
To: linux-mips
Cc: Florian Fainelli, Broadcom internal kernel review list,
Rob Herring, Krzysztof Kozlowski, Thomas Bogendoerfer,
Rafał Miłecki,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
We currently have a DTC warning with the current DTS due to the lack of
a suitable #address-cells and #size-cells property:
DTC arch/mips/boot/dts/brcm/bcm63268-comtrend-vr-3032u.dtb
arch/mips/boot/dts/brcm/bcm63268.dtsi:115.5-22: Warning (reg_format): /ubus/timer-mfd@10000080/timer@0:reg: property has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1)
arch/mips/boot/dts/brcm/bcm63268.dtsi:120.5-22: Warning (reg_format): /ubus/timer-mfd@10000080/watchdog@1c:reg: property has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1)
arch/mips/boot/dts/brcm/bcm63268.dtsi:111.4-35: Warning (ranges_format): /ubus/timer-mfd@10000080:ranges: "ranges" property has invalid length (12 bytes) (parent #address-cells == 1, child #address-cells == 2, #size-cells == 1)
Fixes: d3db4b96ab7f ("mips: dts: bcm63268: add TWD block timer")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
arch/mips/boot/dts/brcm/bcm63268.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/mips/boot/dts/brcm/bcm63268.dtsi b/arch/mips/boot/dts/brcm/bcm63268.dtsi
index c663efce91cf..7b788757cb1e 100644
--- a/arch/mips/boot/dts/brcm/bcm63268.dtsi
+++ b/arch/mips/boot/dts/brcm/bcm63268.dtsi
@@ -109,6 +109,8 @@ timer-mfd@10000080 {
compatible = "brcm,bcm7038-twd", "simple-mfd", "syscon";
reg = <0x10000080 0x30>;
ranges = <0x0 0x10000080 0x30>;
+ #address-cells = <1>;
+ #size-cells = <1>;
timer@0 {
compatible = "brcm,bcm6345-timer";
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] MIPS: dts: bcm63268: Add missing properties to the TWD node
2022-12-20 19:09 [PATCH] MIPS: dts: bcm63268: Add missing properties to the TWD node Florian Fainelli
@ 2022-12-20 22:23 ` Philippe Mathieu-Daudé
2022-12-21 13:06 ` Thomas Bogendoerfer
1 sibling, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2022-12-20 22:23 UTC (permalink / raw)
To: Florian Fainelli, linux-mips
Cc: Broadcom internal kernel review list, Rob Herring,
Krzysztof Kozlowski, Thomas Bogendoerfer, Rafał Miłecki,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
On 20/12/22 20:09, Florian Fainelli wrote:
> We currently have a DTC warning with the current DTS due to the lack of
> a suitable #address-cells and #size-cells property:
>
> DTC arch/mips/boot/dts/brcm/bcm63268-comtrend-vr-3032u.dtb
> arch/mips/boot/dts/brcm/bcm63268.dtsi:115.5-22: Warning (reg_format): /ubus/timer-mfd@10000080/timer@0:reg: property has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1)
> arch/mips/boot/dts/brcm/bcm63268.dtsi:120.5-22: Warning (reg_format): /ubus/timer-mfd@10000080/watchdog@1c:reg: property has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1)
> arch/mips/boot/dts/brcm/bcm63268.dtsi:111.4-35: Warning (ranges_format): /ubus/timer-mfd@10000080:ranges: "ranges" property has invalid length (12 bytes) (parent #address-cells == 1, child #address-cells == 2, #size-cells == 1)
>
> Fixes: d3db4b96ab7f ("mips: dts: bcm63268: add TWD block timer")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> arch/mips/boot/dts/brcm/bcm63268.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] MIPS: dts: bcm63268: Add missing properties to the TWD node
2022-12-20 19:09 [PATCH] MIPS: dts: bcm63268: Add missing properties to the TWD node Florian Fainelli
2022-12-20 22:23 ` Philippe Mathieu-Daudé
@ 2022-12-21 13:06 ` Thomas Bogendoerfer
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Bogendoerfer @ 2022-12-21 13:06 UTC (permalink / raw)
To: Florian Fainelli
Cc: linux-mips, Broadcom internal kernel review list, Rob Herring,
Krzysztof Kozlowski, Rafał Miłecki,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
On Tue, Dec 20, 2022 at 11:09:46AM -0800, Florian Fainelli wrote:
> We currently have a DTC warning with the current DTS due to the lack of
> a suitable #address-cells and #size-cells property:
>
> DTC arch/mips/boot/dts/brcm/bcm63268-comtrend-vr-3032u.dtb
> arch/mips/boot/dts/brcm/bcm63268.dtsi:115.5-22: Warning (reg_format): /ubus/timer-mfd@10000080/timer@0:reg: property has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1)
> arch/mips/boot/dts/brcm/bcm63268.dtsi:120.5-22: Warning (reg_format): /ubus/timer-mfd@10000080/watchdog@1c:reg: property has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1)
> arch/mips/boot/dts/brcm/bcm63268.dtsi:111.4-35: Warning (ranges_format): /ubus/timer-mfd@10000080:ranges: "ranges" property has invalid length (12 bytes) (parent #address-cells == 1, child #address-cells == 2, #size-cells == 1)
>
> Fixes: d3db4b96ab7f ("mips: dts: bcm63268: add TWD block timer")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> arch/mips/boot/dts/brcm/bcm63268.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/mips/boot/dts/brcm/bcm63268.dtsi b/arch/mips/boot/dts/brcm/bcm63268.dtsi
> index c663efce91cf..7b788757cb1e 100644
> --- a/arch/mips/boot/dts/brcm/bcm63268.dtsi
> +++ b/arch/mips/boot/dts/brcm/bcm63268.dtsi
> @@ -109,6 +109,8 @@ timer-mfd@10000080 {
> compatible = "brcm,bcm7038-twd", "simple-mfd", "syscon";
> reg = <0x10000080 0x30>;
> ranges = <0x0 0x10000080 0x30>;
> + #address-cells = <1>;
> + #size-cells = <1>;
>
> timer@0 {
> compatible = "brcm,bcm6345-timer";
> --
> 2.34.1
applied.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] MIPS: dts: bcm63268: Add missing properties to the TWD node
@ 2022-12-20 19:09 Florian Fainelli
0 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2022-12-20 19:09 UTC (permalink / raw)
To: linux-mips
Cc: Florian Fainelli, Broadcom internal kernel review list,
Rob Herring, Krzysztof Kozlowski, Thomas Bogendoerfer,
Rafał Miłecki,
open list:BROADCOM BMIPS MIPS ARCHITECTURE,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
We currently have a DTC warning with the current DTS due to the lack of
a suitable #address-cells and #size-cells property:
DTC arch/mips/boot/dts/brcm/bcm63268-comtrend-vr-3032u.dtb
arch/mips/boot/dts/brcm/bcm63268.dtsi:115.5-22: Warning (reg_format): /ubus/timer-mfd@10000080/timer@0:reg: property has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1)
arch/mips/boot/dts/brcm/bcm63268.dtsi:120.5-22: Warning (reg_format): /ubus/timer-mfd@10000080/watchdog@1c:reg: property has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1)
arch/mips/boot/dts/brcm/bcm63268.dtsi:111.4-35: Warning (ranges_format): /ubus/timer-mfd@10000080:ranges: "ranges" property has invalid length (12 bytes) (parent #address-cells == 1, child #address-cells == 2, #size-cells == 1)
Fixes: d3db4b96ab7f ("mips: dts: bcm63268: add TWD block timer")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
arch/mips/boot/dts/brcm/bcm63268.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/mips/boot/dts/brcm/bcm63268.dtsi b/arch/mips/boot/dts/brcm/bcm63268.dtsi
index c663efce91cf..7b788757cb1e 100644
--- a/arch/mips/boot/dts/brcm/bcm63268.dtsi
+++ b/arch/mips/boot/dts/brcm/bcm63268.dtsi
@@ -109,6 +109,8 @@ timer-mfd@10000080 {
compatible = "brcm,bcm7038-twd", "simple-mfd", "syscon";
reg = <0x10000080 0x30>;
ranges = <0x0 0x10000080 0x30>;
+ #address-cells = <1>;
+ #size-cells = <1>;
timer@0 {
compatible = "brcm,bcm6345-timer";
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-12-21 13:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-20 19:09 [PATCH] MIPS: dts: bcm63268: Add missing properties to the TWD node Florian Fainelli
2022-12-20 22:23 ` Philippe Mathieu-Daudé
2022-12-21 13:06 ` Thomas Bogendoerfer
-- strict thread matches above, loose matches on Subject: below --
2022-12-20 19:09 Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).