From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Prathamesh Shete <pshete@nvidia.com>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
thierry.reding@gmail.com, jonathanh@nvidia.com,
devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: smangipudi@nvidia.com, kyarlagadda@nvidia.com, anrao@nvidia.com
Subject: Re: [PATCH v2] arm64: tegra: Add Tegra234 SDMMC1 device tree node
Date: Fri, 7 Oct 2022 17:57:28 +0200 [thread overview]
Message-ID: <7bf3f70a-4af6-c62a-75fc-89591d5de04b@linaro.org> (raw)
In-Reply-To: <20221007124424.16037-1-pshete@nvidia.com>
On 07/10/2022 14:44, Prathamesh Shete wrote:
> Add device tree node for Tegra234 SDMMC1 instance.
> Add and enable SD card instance in device tree.
>
> Signed-off-by: Prathamesh Shete <pshete@nvidia.com>
> +
> mmc@3460000 {
> compatible = "nvidia,tegra234-sdhci", "nvidia,tegra186-sdhci";
> reg = <0x03460000 0x20000>;
> @@ -1541,6 +1581,25 @@
>
> #interrupt-cells = <2>;
> interrupt-controller;
The blank line which you incorrectly placed, should be here...
> + sdmmc1_3v3: sdmmc1-3v3 {
> + pins = "sdmmc1-hv";
> + power-source = <TEGRA_IO_PAD_VOLTAGE_3V3>;
> + };
> +
> + sdmmc1_1v8: sdmmc1-1v8 {
> + pins = "sdmmc1-hv";
> + power-source = <TEGRA_IO_PAD_VOLTAGE_1V8>;
> + };
> +
> + sdmmc3_3v3: sdmmc3-3v3 {
> + pins = "sdmmc3-hv";
> + power-source = <TEGRA_IO_PAD_VOLTAGE_3V3>;
> + };
> +
> + sdmmc3_1v8: sdmmc3-1v8 {
> + pins = "sdmmc3-hv";
> + power-source = <TEGRA_IO_PAD_VOLTAGE_1V8>;
> + };
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-10-07 15:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-07 10:26 [PATCH] arm64: tegra: Add Tegra234 SDMMC1 device tree node Prathamesh Shete
2022-10-07 12:33 ` Krzysztof Kozlowski
2022-10-07 12:44 ` [PATCH v2] " Prathamesh Shete
2022-10-07 15:57 ` Krzysztof Kozlowski [this message]
2022-10-07 16:59 ` [PATCH v3] " Prathamesh Shete
2022-10-24 13:52 ` Thierry Reding
2022-10-07 20:18 ` [PATCH] " kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7bf3f70a-4af6-c62a-75fc-89591d5de04b@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=anrao@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kyarlagadda@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=pshete@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=smangipudi@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).