From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02E6B2562E for ; Wed, 17 Jan 2024 19:53:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705521190; cv=none; b=PtGRYMFuxdKfn0BCLJ/tKknwZuG5OygYMl2y7sQeqIbil0wgph3jIIqamuzIdDG5E79jbRWcxHkKBN9vnRtOjB3vjwH/1npepKqJocdlUyZNelNY/Wbq9QCzmzMBYZHkeYIk7pfDKmWxtE3e7ZT90eZLI0hw6610mNmgUjec1uk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705521190; c=relaxed/simple; bh=72BXa3ZPIvfwifjasuIJd6GMJgCyzAgDKLK46N4+lNo=; h=Received:DKIM-Signature:X-Google-DKIM-Signature: X-Gm-Message-State:X-Google-Smtp-Source:X-Received:Received: Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References: Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding; b=lV3uPfTHU8yd0pFQCUtiQ9lZHOUX1t4MLXmBVy0GNgp+pK4gmNzryMeXWFC0HKDIg0JRG/o1iJk9iYkWe45ZE+fe0axoWw3Ix2voj679f472/Vqp4Bs6RcGY3SM9GlBT5GnwxHXVbUnudPYzsE04cesc8L8b10UXaXZuNW0qG0Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=VlwTFxa1; arc=none smtp.client-ip=209.85.167.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VlwTFxa1" Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-50ea8fbf261so13881037e87.2 for ; Wed, 17 Jan 2024 11:53:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1705521187; x=1706125987; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Wm6DgYvqeoRUoLSmR1T0PQYUUXuQvfXV0BJlW+D/OzU=; b=VlwTFxa1/5plN/+HIzMYZULkK+6HrCKzJry9DuJrHZTaBdH4fTv3TFI+68EyofF4Qw PH2YMH01IcmmKJbDKlyDPwPqsTfEteiQk8ysV442y7ts5RXF59Gj8PTqS1UTzMBTDScl 5qMFTu7s15+h49v2a1AK4k4/Oh/TAgRH/44JA5iBe2jxTHP3SSdsCE/WjUz93lXVr4BQ nSMpaFkaiDaTBcn8zPPMcQH1HAzLjv0uiY6wL2062BPLm4TLYwrvbteMme1Z3ggKtik9 NSTid1toO/oZxKFVBmiu9lVGhoghNFMfZEbys9D4Nlak0YTps79yNY5EJF6pJNH66IP5 h03g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705521187; x=1706125987; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Wm6DgYvqeoRUoLSmR1T0PQYUUXuQvfXV0BJlW+D/OzU=; b=JAmbtfvUWRe9qyOapuHj1JSEd4uvjC+IaEFdaN0RgF0KXNZL1+89sbYPS7e9XnZhuk L5tsJlSeVM63awJavNpIv0z4DuQhxRpFhQq6RoWTareXRVD4/+iV0VuhkWXf/8X6y6GN h957ai6/3ZjAiqSrJgoVeeTYCKpeFi6fYXY++JKvvrw2m9YKSxXMh27ejJjoyqmZYOq6 +YfXSXdeM+XkJpG2HuVylKNgWmTXKO5g0NMdyBxwCvE6g/Xq1J/yxkgKLulmONEk/3ul FssVfmmNSzir7LyevK65YgxhZfVrjw7vu14trdrRZrhCRGzamTgzUzXRKY3/HoU8ImAH LiPA== X-Gm-Message-State: AOJu0YwGKV5HyMZ1/KrQnHtEHD0o/GIi0hXh/XOj37A9TNYeU3b4TY7z AFGD1CQGiXYb39CM+4Luv0myoREm+yyazg== X-Google-Smtp-Source: AGHT+IF3Y61AIRWeQ8u2Yp7ml5wNPwagyN8nac9JTwoZW0SXn7RisuuBO0czehYfhYEvs/1ZgROsZw== X-Received: by 2002:a05:6512:b90:b0:50e:f1e1:6127 with SMTP id b16-20020a0565120b9000b0050ef1e16127mr3641304lfv.58.1705521186890; Wed, 17 Jan 2024 11:53:06 -0800 (PST) Received: from [172.30.204.151] (UNUSED.212-182-62-129.lubman.net.pl. [212.182.62.129]) by smtp.gmail.com with ESMTPSA id b4-20020a056512060400b0050eb2325472sm352946lfe.37.2024.01.17.11.53.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Jan 2024 11:53:06 -0800 (PST) Message-ID: <7bf729a4-f3ac-4751-9275-a2aa4d62c036@linaro.org> Date: Wed, 17 Jan 2024 20:53:04 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 1/7] dt-bindings: mailbox: qcom: Add CPUCP mailbox controller bindings To: Sibi Sankar , sudeep.holla@arm.com, cristian.marussi@arm.com, andersson@kernel.org, jassisinghbrar@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, quic_rgottimu@quicinc.com, quic_kshivnan@quicinc.com, conor+dt@kernel.org References: <20240117173458.2312669-1-quic_sibis@quicinc.com> <20240117173458.2312669-2-quic_sibis@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20240117173458.2312669-2-quic_sibis@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/17/24 18:34, Sibi Sankar wrote: > Add devicetree binding for CPUSS Control Processor (CPUCP) mailbox > controller. > > Signed-off-by: Sibi Sankar > --- [...] > + - | > + #include > + > + mailbox@17430000 { > + compatible = "qcom,x1e80100-cpucp-mbox", "qcom,cpucp-mbox"; > + reg = <0x17430000 0x10000>, <0x18830000 0x300>; These reg spaces are quite far apart.. On 7280-8550, a similar mailbox exists, although it's dubbed RIMPS-mbox instead. In that case, I separated the mbox into tx (via qcom-apcs-ipc-mailbox.c) and rx (with a simple driver). Still haven't pushed or posted that anywhere, I'd need to access another machine.. On (some of) these SoCs, one of the channels (rx[1], iirc?) clearly bleeds into the CPUFREQ_HW/OSM register region, which gives an impression of misrepresenting the hardware. X1E doesn't have a node for cpufreq_hw defined, so I can't tell whether it's also the case here. Konrad