* Re: [PATCHv2 1/2] dt-bindings: adi,adv7511.txt: document cec clock [not found] ` <e68cffb1-346c-2018-9048-3f8523903809-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> @ 2017-09-19 10:07 ` Hans Verkuil 2017-09-19 10:15 ` Sergei Shtylyov 0 siblings, 1 reply; 6+ messages in thread From: Hans Verkuil @ 2017-09-19 10:07 UTC (permalink / raw) To: Sergei Shtylyov, Hans Verkuil, linux-media-u79uwXL29TY76Z2rM5mHXA Cc: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA, Archit Taneja, linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA, Lars-Peter Clausen, Hans Verkuil, devicetree-u79uwXL29TY76Z2rM5mHXA On 09/19/17 11:35, Sergei Shtylyov wrote: > On 9/19/2017 12:29 PM, Hans Verkuil wrote: > >>>> From: Hans Verkuil <hans.verkuil-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org> >>>> >>>> Document the cec clock binding. >>>> >>>> Signed-off-by: Hans Verkuil <hans.verkuil-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org> >>>> Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> >>>> --- >>>> Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt | 4 ++++ >>>> 1 file changed, 4 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt b/Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt >>>> index 06668bca7ffc..4497ae054d49 100644 >>>> --- a/Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt >>>> +++ b/Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt >>>> @@ -68,6 +68,8 @@ Optional properties: >>>> - adi,disable-timing-generator: Only for ADV7533. Disables the internal timing >>>> generator. The chip will rely on the sync signals in the DSI data lanes, >>>> rather than generate its own timings for HDMI output. >>>> +- clocks: from common clock binding: handle to CEC clock. >>> >>> It's called "phandle" in the DT speak. :-) >>> Are you sure the clock specifier would always be absent? >> >> Sorry? I don't understand the question. Did you mean: "can be absent?"? > > No, you only say that there'll be the clock phandle only. The clock > specifier may follow the phandle for the clock devices that have > "#clock-cells" prop != 0. I have to say that I just copy-and-pasted this from other bindings. Would this be better? - clocks: list of clock specifiers, corresponding to entries in the clock-names property; - clock-names: from common clock binding: must be "cec". Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCHv2 1/2] dt-bindings: adi,adv7511.txt: document cec clock 2017-09-19 10:07 ` [PATCHv2 1/2] dt-bindings: adi,adv7511.txt: document cec clock Hans Verkuil @ 2017-09-19 10:15 ` Sergei Shtylyov 2017-09-19 10:35 ` Hans Verkuil 0 siblings, 1 reply; 6+ messages in thread From: Sergei Shtylyov @ 2017-09-19 10:15 UTC (permalink / raw) To: Hans Verkuil, Hans Verkuil, linux-media Cc: dri-devel, linux-arm-msm, Archit Taneja, linux-renesas-soc, Lars-Peter Clausen, Hans Verkuil, devicetree On 9/19/2017 1:07 PM, Hans Verkuil wrote: >>>>> From: Hans Verkuil <hans.verkuil@cisco.com> >>>>> >>>>> Document the cec clock binding. >>>>> >>>>> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> >>>>> Acked-by: Rob Herring <robh@kernel.org> >>>>> --- >>>>> Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt | 4 ++++ >>>>> 1 file changed, 4 insertions(+) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt b/Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt >>>>> index 06668bca7ffc..4497ae054d49 100644 >>>>> --- a/Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt >>>>> +++ b/Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt >>>>> @@ -68,6 +68,8 @@ Optional properties: >>>>> - adi,disable-timing-generator: Only for ADV7533. Disables the internal timing >>>>> generator. The chip will rely on the sync signals in the DSI data lanes, >>>>> rather than generate its own timings for HDMI output. >>>>> +- clocks: from common clock binding: handle to CEC clock. >>>> >>>> It's called "phandle" in the DT speak. :-) >>>> Are you sure the clock specifier would always be absent? >>> >>> Sorry? I don't understand the question. Did you mean: "can be absent?"? >> >> No, you only say that there'll be the clock phandle only. The clock >> specifier may follow the phandle for the clock devices that have >> "#clock-cells" prop != 0. > > I have to say that I just copy-and-pasted this from other bindings. :-) > Would this be better? > > - clocks: list of clock specifiers, corresponding to entries in > the clock-names property; Didn't you say that there'll be only one clock, "cec"? If so, there's gonna be a single clock phandle+specifier pair. They always go in pairs. :-) > - clock-names: from common clock binding: must be "cec". > > Regards, > > Hans MBR, Sergei ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCHv2 1/2] dt-bindings: adi,adv7511.txt: document cec clock 2017-09-19 10:15 ` Sergei Shtylyov @ 2017-09-19 10:35 ` Hans Verkuil 2017-09-19 10:42 ` Sergei Shtylyov 0 siblings, 1 reply; 6+ messages in thread From: Hans Verkuil @ 2017-09-19 10:35 UTC (permalink / raw) To: Sergei Shtylyov, Hans Verkuil, linux-media Cc: dri-devel, linux-arm-msm, Archit Taneja, linux-renesas-soc, Lars-Peter Clausen, Hans Verkuil, devicetree On 09/19/17 12:15, Sergei Shtylyov wrote: > On 9/19/2017 1:07 PM, Hans Verkuil wrote: > >>>>>> From: Hans Verkuil <hans.verkuil@cisco.com> >>>>>> >>>>>> Document the cec clock binding. >>>>>> >>>>>> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> >>>>>> Acked-by: Rob Herring <robh@kernel.org> >>>>>> --- >>>>>> Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt | 4 ++++ >>>>>> 1 file changed, 4 insertions(+) >>>>>> >>>>>> diff --git a/Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt b/Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt >>>>>> index 06668bca7ffc..4497ae054d49 100644 >>>>>> --- a/Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt >>>>>> +++ b/Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt >>>>>> @@ -68,6 +68,8 @@ Optional properties: >>>>>> - adi,disable-timing-generator: Only for ADV7533. Disables the internal timing >>>>>> generator. The chip will rely on the sync signals in the DSI data lanes, >>>>>> rather than generate its own timings for HDMI output. >>>>>> +- clocks: from common clock binding: handle to CEC clock. >>>>> >>>>> It's called "phandle" in the DT speak. :-) >>>>> Are you sure the clock specifier would always be absent? >>>> >>>> Sorry? I don't understand the question. Did you mean: "can be absent?"? >>> >>> No, you only say that there'll be the clock phandle only. The clock >>> specifier may follow the phandle for the clock devices that have >>> "#clock-cells" prop != 0. >> >> I have to say that I just copy-and-pasted this from other bindings. > > :-) > >> Would this be better? >> >> - clocks: list of clock specifiers, corresponding to entries in >> the clock-names property; > > Didn't you say that there'll be only one clock, "cec"? If so, there's > gonna be a single clock phandle+specifier pair. They always go in pairs. :-) > >> - clock-names: from common clock binding: must be "cec". - clocks: cec clock phandle, corresponding to the clock-names entry. - clock-names: from common clock binding: must be "cec". This OK? Regards, Hans ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCHv2 1/2] dt-bindings: adi,adv7511.txt: document cec clock 2017-09-19 10:35 ` Hans Verkuil @ 2017-09-19 10:42 ` Sergei Shtylyov 2017-09-19 10:59 ` Hans Verkuil 0 siblings, 1 reply; 6+ messages in thread From: Sergei Shtylyov @ 2017-09-19 10:42 UTC (permalink / raw) To: Hans Verkuil, Hans Verkuil, linux-media Cc: dri-devel, linux-arm-msm, Archit Taneja, linux-renesas-soc, Lars-Peter Clausen, Hans Verkuil, devicetree On 9/19/2017 1:35 PM, Hans Verkuil wrote: >>>>>>> From: Hans Verkuil <hans.verkuil@cisco.com> >>>>>>> >>>>>>> Document the cec clock binding. >>>>>>> >>>>>>> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> >>>>>>> Acked-by: Rob Herring <robh@kernel.org> >>>>>>> --- >>>>>>> Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt | 4 ++++ >>>>>>> 1 file changed, 4 insertions(+) >>>>>>> >>>>>>> diff --git a/Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt b/Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt >>>>>>> index 06668bca7ffc..4497ae054d49 100644 >>>>>>> --- a/Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt >>>>>>> +++ b/Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt >>>>>>> @@ -68,6 +68,8 @@ Optional properties: >>>>>>> - adi,disable-timing-generator: Only for ADV7533. Disables the internal timing >>>>>>> generator. The chip will rely on the sync signals in the DSI data lanes, >>>>>>> rather than generate its own timings for HDMI output. >>>>>>> +- clocks: from common clock binding: handle to CEC clock. >>>>>> >>>>>> It's called "phandle" in the DT speak. :-) >>>>>> Are you sure the clock specifier would always be absent? >>>>> >>>>> Sorry? I don't understand the question. Did you mean: "can be absent?"? >>>> >>>> No, you only say that there'll be the clock phandle only. The clock >>>> specifier may follow the phandle for the clock devices that have >>>> "#clock-cells" prop != 0. >>> >>> I have to say that I just copy-and-pasted this from other bindings. >> >> :-) >> >>> Would this be better? >>> >>> - clocks: list of clock specifiers, corresponding to entries in >>> the clock-names property; >> >> Didn't you say that there'll be only one clock, "cec"? If so, there's >> gonna be a single clock phandle+specifier pair. They always go in pairs. :-) >> >>> - clock-names: from common clock binding: must be "cec". > > - clocks: cec clock phandle, corresponding to the clock-names entry. The clock phandle and specifier. > - clock-names: from common clock binding: must be "cec". > > This OK? Well, you seem to be going in circles, the above was almost the same as the original prop description... > Regards, > > Hans MBR, Sergei ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCHv2 1/2] dt-bindings: adi,adv7511.txt: document cec clock 2017-09-19 10:42 ` Sergei Shtylyov @ 2017-09-19 10:59 ` Hans Verkuil 2017-09-19 12:27 ` Sergei Shtylyov 0 siblings, 1 reply; 6+ messages in thread From: Hans Verkuil @ 2017-09-19 10:59 UTC (permalink / raw) To: Sergei Shtylyov, Hans Verkuil, linux-media Cc: dri-devel, linux-arm-msm, Archit Taneja, linux-renesas-soc, Lars-Peter Clausen, Hans Verkuil, devicetree On 09/19/17 12:42, Sergei Shtylyov wrote: > On 9/19/2017 1:35 PM, Hans Verkuil wrote: > >>>>>>>> From: Hans Verkuil <hans.verkuil@cisco.com> >>>>>>>> >>>>>>>> Document the cec clock binding. >>>>>>>> >>>>>>>> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> >>>>>>>> Acked-by: Rob Herring <robh@kernel.org> >>>>>>>> --- >>>>>>>> Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt | 4 ++++ >>>>>>>> 1 file changed, 4 insertions(+) >>>>>>>> >>>>>>>> diff --git a/Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt b/Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt >>>>>>>> index 06668bca7ffc..4497ae054d49 100644 >>>>>>>> --- a/Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt >>>>>>>> +++ b/Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt >>>>>>>> @@ -68,6 +68,8 @@ Optional properties: >>>>>>>> - adi,disable-timing-generator: Only for ADV7533. Disables the internal timing >>>>>>>> generator. The chip will rely on the sync signals in the DSI data lanes, >>>>>>>> rather than generate its own timings for HDMI output. >>>>>>>> +- clocks: from common clock binding: handle to CEC clock. >>>>>>> >>>>>>> It's called "phandle" in the DT speak. :-) >>>>>>> Are you sure the clock specifier would always be absent? >>>>>> >>>>>> Sorry? I don't understand the question. Did you mean: "can be absent?"? >>>>> >>>>> No, you only say that there'll be the clock phandle only. The clock >>>>> specifier may follow the phandle for the clock devices that have >>>>> "#clock-cells" prop != 0. >>>> >>>> I have to say that I just copy-and-pasted this from other bindings. >>> >>> :-) >>> >>>> Would this be better? >>>> >>>> - clocks: list of clock specifiers, corresponding to entries in >>>> the clock-names property; >>> >>> Didn't you say that there'll be only one clock, "cec"? If so, there's >>> gonna be a single clock phandle+specifier pair. They always go in pairs. :-) >>> >>>> - clock-names: from common clock binding: must be "cec". >> >> - clocks: cec clock phandle, corresponding to the clock-names entry. > > The clock phandle and specifier. > >> - clock-names: from common clock binding: must be "cec". >> >> This OK? > > Well, you seem to be going in circles, the above was almost the same as > the original prop description... - clocks: from common clock binding: reference to the CEC clock. - clock-names: from common clock binding: must be "cec". This avoids the whole issue of having just a phandle or a phandle + specifier. Regards, Hans ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCHv2 1/2] dt-bindings: adi,adv7511.txt: document cec clock 2017-09-19 10:59 ` Hans Verkuil @ 2017-09-19 12:27 ` Sergei Shtylyov 0 siblings, 0 replies; 6+ messages in thread From: Sergei Shtylyov @ 2017-09-19 12:27 UTC (permalink / raw) To: Hans Verkuil, Hans Verkuil, linux-media Cc: dri-devel, linux-arm-msm, Archit Taneja, linux-renesas-soc, Lars-Peter Clausen, Hans Verkuil, devicetree On 09/19/2017 01:59 PM, Hans Verkuil wrote: >>>>>>>>> From: Hans Verkuil <hans.verkuil@cisco.com> >>>>>>>>> >>>>>>>>> Document the cec clock binding. >>>>>>>>> >>>>>>>>> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> >>>>>>>>> Acked-by: Rob Herring <robh@kernel.org> >>>>>>>>> --- >>>>>>>>> Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt | 4 ++++ >>>>>>>>> 1 file changed, 4 insertions(+) >>>>>>>>> >>>>>>>>> diff --git a/Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt b/Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt >>>>>>>>> index 06668bca7ffc..4497ae054d49 100644 >>>>>>>>> --- a/Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt >>>>>>>>> +++ b/Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt >>>>>>>>> @@ -68,6 +68,8 @@ Optional properties: >>>>>>>>> - adi,disable-timing-generator: Only for ADV7533. Disables the internal timing >>>>>>>>> generator. The chip will rely on the sync signals in the DSI data lanes, >>>>>>>>> rather than generate its own timings for HDMI output. >>>>>>>>> +- clocks: from common clock binding: handle to CEC clock. >>>>>>>> >>>>>>>> It's called "phandle" in the DT speak. :-) >>>>>>>> Are you sure the clock specifier would always be absent? >>>>>>> >>>>>>> Sorry? I don't understand the question. Did you mean: "can be absent?"? >>>>>> >>>>>> No, you only say that there'll be the clock phandle only. The clock >>>>>> specifier may follow the phandle for the clock devices that have >>>>>> "#clock-cells" prop != 0. >>>>> >>>>> I have to say that I just copy-and-pasted this from other bindings. >>>> >>>> :-) >>>> >>>>> Would this be better? >>>>> >>>>> - clocks: list of clock specifiers, corresponding to entries in >>>>> the clock-names property; >>>> >>>> Didn't you say that there'll be only one clock, "cec"? If so, there's >>>> gonna be a single clock phandle+specifier pair. They always go in pairs. :-) >>>> >>>>> - clock-names: from common clock binding: must be "cec". >>> >>> - clocks: cec clock phandle, corresponding to the clock-names entry. >> >> The clock phandle and specifier. >> >>> - clock-names: from common clock binding: must be "cec". >>> >>> This OK? >> >> Well, you seem to be going in circles, the above was almost the same as >> the original prop description... > > - clocks: from common clock binding: reference to the CEC clock. > - clock-names: from common clock binding: must be "cec". > > This avoids the whole issue of having just a phandle or a phandle + specifier. OK, let's go with this one. Thank you! > Regards, > > Hans MBR, Sergei ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-09-19 12:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20170919073331.29007-1-hverkuil@xs4all.nl>
[not found] ` <20170919073331.29007-2-hverkuil@xs4all.nl>
[not found] ` <505bc74f-6563-ab1d-9aab-7893410aef7e@cogentembedded.com>
[not found] ` <74b252c8-c1eb-8498-7b9b-54604fe2806a@cisco.com>
[not found] ` <e68cffb1-346c-2018-9048-3f8523903809@cogentembedded.com>
[not found] ` <e68cffb1-346c-2018-9048-3f8523903809-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2017-09-19 10:07 ` [PATCHv2 1/2] dt-bindings: adi,adv7511.txt: document cec clock Hans Verkuil
2017-09-19 10:15 ` Sergei Shtylyov
2017-09-19 10:35 ` Hans Verkuil
2017-09-19 10:42 ` Sergei Shtylyov
2017-09-19 10:59 ` Hans Verkuil
2017-09-19 12:27 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).