From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A34B6C41513 for ; Mon, 14 Aug 2023 10:03:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234001AbjHNKCy (ORCPT ); Mon, 14 Aug 2023 06:02:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236413AbjHNKCU (ORCPT ); Mon, 14 Aug 2023 06:02:20 -0400 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6865C1BD6 for ; Mon, 14 Aug 2023 03:02:05 -0700 (PDT) Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-52564f3faf7so1083937a12.1 for ; Mon, 14 Aug 2023 03:02:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692007324; x=1692612124; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+ik4gXzePMNDVXoA4qrXdz513andF8ufeDJrefrHPgs=; b=Cuwgeg1oa9UiSAgOBKYu0Awo2j/aqHQF1fXXMcimETzCFxl/+vxxrRMeirwGB6S7Bz Vi5iuaz8mof1AbUXgd8pwXCYh1ZcHjntZep94U1XR5VziXLjLR4ea2XJH6OYLsfg3tjp EyvmO8zKNvzEKtV40aki0Out/JHLkcEcemC4P7ETzUm/IY8pi5Dl0cQLjj+a4oaAwYvl 9SGodBriSN4kDTzLh+jHPbr1T1GXJM2uf1VtRxdYdxF4Q8QRIGWYNIsL7VTgNM3NZ7QM aByl7AujH1eQ4nrklkKyLqBKP+GqLo/7nXtwGtztKido4c17MeMi8vjch7zpfPmL+4D9 Dycw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692007324; x=1692612124; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+ik4gXzePMNDVXoA4qrXdz513andF8ufeDJrefrHPgs=; b=RtyePbDDL7Sh0AllwUQW94qTc0SoAUNApjbpenlQ96QzlmdpQ4DLDrVXRiE8kuJqI/ HY4wvfoUkO1ddP3PDOlfm67o9O+6SjptEFMGknIfMZHbGw3GZoxheBywxwM0S2CD0oBQ TJvgcyfT/1UZ+ubd4NMHofUA01q0Vut+ATXYSuGlhIsaUtL0f3Ww2Qs1FutpKsV0cWos w0YbS2Dv92ZWu6BX2eTth5WBdwlpZ6tvk9cDEM9zAGVBZCHluG3UIM0bXsYbXgRYvt84 6/EPISauqKMeewnx3X3LE99O7DZP/D0vCw5YxKTb3Bf6SLxZqKHMSWjRyoFJf9m08Jt3 vftg== X-Gm-Message-State: AOJu0YykmW2n/xWZqksyjlszlW52gOKbBPf+Amuo3alnjHKKE/R251Jg x7CY/g57KkzF/rBESpIJv1ekiA== X-Google-Smtp-Source: AGHT+IGLzRRf7XnAWVvQR/vfWi0vMp1OCBzNr5Xn0bY7guPVzQfzodJcNpciW9fx89Nxo1T/CwxBrA== X-Received: by 2002:aa7:c557:0:b0:522:cef7:83c3 with SMTP id s23-20020aa7c557000000b00522cef783c3mr7646463edr.8.1692007323433; Mon, 14 Aug 2023 03:02:03 -0700 (PDT) Received: from [192.168.1.20] ([178.197.214.188]) by smtp.gmail.com with ESMTPSA id y18-20020aa7ccd2000000b005227e53cec2sm5403411edt.50.2023.08.14.03.02.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Aug 2023 03:02:03 -0700 (PDT) Message-ID: <7c05f889-acee-4ef7-7fce-c30baa760138@linaro.org> Date: Mon, 14 Aug 2023 12:01:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v7 3/5] arm64: dts: qcom: ipq5332: Add USB related nodes Content-Language: en-US To: Varadarajan Narayanan , agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, vkoul@kernel.org, kishon@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, catalin.marinas@arm.com, will@kernel.org, p.zabel@pengutronix.de, arnd@arndb.de, geert+renesas@glider.be, nfraprado@collabora.com, rafal@milecki.pl, peng.fan@nxp.com, quic_srichara@quicinc.com, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <066299506138ffcf1a3135b6f1a4609eee46ddf9.1691660905.git.quic_varada@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <066299506138ffcf1a3135b6f1a4609eee46ddf9.1691660905.git.quic_varada@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 10/08/2023 11:56, Varadarajan Narayanan wrote: > Add USB phy and controller nodes. > > Signed-off-by: Varadarajan Narayanan > --- > v6: > Remove clock names > Move the nodes to address sorted location > v5: > Use generic phy instead of usb-phy > 'make CHECK_DTBS=y DT_SCHEMA_FILES=qcom dtbs_check' passed > 'DT_CHECKER_FLAGS='-v -m' DT_SCHEMA_FILES=qcom dt_binding_check' passed > v4: > Change node name > Remove blank line > 'make CHECK_DTBS=y DT_SCHEMA_FILES=qcom qcom/ipq5332-rdp441.dtb' passed > v1: > Rename phy node > Change compatible from m31,ipq5332-usb-hsphy -> qcom,ipq5332-usb-hsphy > Remove 'qscratch' from phy node > Fix alignment and upper-case hex no.s > Add clock definition for the phy > Remove snps,ref-clock-period-ns as it is not used. dwc3_ref_clk_period() > in dwc3/core.c takes the frequency from ref clock and calculates fladj > as appropriate. > --- > arch/arm64/boot/dts/qcom/ipq5332.dtsi | 55 +++++++++++++++++++++++++++++++++++ > 1 file changed, 55 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi > index 8bfc2db..c45d9d4 100644 > --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi > @@ -145,6 +145,19 @@ > #size-cells = <1>; > ranges = <0 0 0 0xffffffff>; > > + usbphy0: phy@7b000 { > + compatible = "qcom,ipq5332-usb-hsphy"; > + reg = <0x0007b000 0x12c>; > + > + clocks = <&gcc GCC_USB0_PHY_CFG_AHB_CLK>; > + > + resets = <&gcc GCC_QUSB2_0_PHY_BCR>; > + > + #phy-cells = <0>; > + > + status = "disabled"; > + }; > + > qfprom: efuse@a4000 { > compatible = "qcom,ipq5332-qfprom", "qcom,qfprom"; > reg = <0x000a4000 0x721>; > @@ -290,6 +303,48 @@ > status = "disabled"; > }; > > + usb: usb2@8a00000 { usb@ Node names must be generic. > + compatible = "qcom,ipq5332-dwc3", "qcom,dwc3"; > + reg = <0x08af8800 0x400>; OK, so this was not really checked for any warnings. It does not look like you tested the DTS against bindings. Please run `make dtbs_check W=1` (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ for instructions). Best regards, Krzysztof