From: Jianguo Zhang <jianguo.zhang@mediatek.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"David S . Miller" <davem@davemloft.net>,
Rob Herring <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>
Cc: Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
Biao Huang <biao.huang@mediatek.com>, <netdev@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v5 4/4] net: stmmac: Update the name of property 'clk_csr'
Date: Wed, 28 Sep 2022 15:40:00 +0800 [thread overview]
Message-ID: <7c46b223e4ba5d1ceb587facf7dd060e6cab9f17.camel@mediatek.com> (raw)
In-Reply-To: <ff577b86-44c8-3146-3388-78021bb7edb4@linaro.org>
Dear Krzysztof,
Thanks for your comment.
On Wed, 2022-09-28 at 09:17 +0200, Krzysztof Kozlowski wrote:
> On 27/09/2022 12:44, AngeloGioacchino Del Regno wrote:
>
> > > > OTOH, as Angelo pointed out, handling old and new properties is
> > > > quite
> > > > easy to achieve, so... :)
> > > >
> > >
> > > So, the conclusion is as following:
> > >
> > > 1. add new property 'snps,clk-csr' and document it in binding
> > > file.
> > > 2. parse new property 'snps,clk-csr' firstly, if failed, fall
> > > back to
> > > old property 'clk_csr' in driver.
> > >
> > > Is my understanding correct?
> >
> > Yes, please.
> >
> > I think that bindings should also get a 'clk_csr' with deprecated:
> > true,
> > but that's Krzysztof's call.
>
> The property was never documented, so I think we can skip it as
> deprecated.
>
We will send next version patches according to the conclusion.
> Best regards,
> Krzysztof
>
BRS
Jianguo
prev parent reply other threads:[~2022-09-28 7:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 5:28 [PATCH v5 0/4] Mediatek ethernet patches for mt8188 Jianguo Zhang
2022-09-23 5:28 ` [PATCH v5 1/4] dt-bindings: net: mediatek-dwmac: add support " Jianguo Zhang
2022-09-23 5:28 ` [PATCH v5 2/4] dt-bindings: net: snps,dwmac: add clk_csr property Jianguo Zhang
2022-09-23 18:11 ` Krzysztof Kozlowski
2022-09-27 8:49 ` Jianguo Zhang
2022-09-23 5:28 ` [PATCH v5 3/4] arm64: dts: mediatek: mt2712e: Update the name of property 'clk_csr' Jianguo Zhang
2022-09-23 5:28 ` [PATCH v5 4/4] net: stmmac: " Jianguo Zhang
2022-09-23 9:10 ` AngeloGioacchino Del Regno
2022-09-23 18:14 ` Krzysztof Kozlowski
2022-09-23 18:15 ` Krzysztof Kozlowski
2022-09-27 8:43 ` Jianguo Zhang
2022-09-27 8:44 ` Jianguo Zhang
2022-09-27 10:44 ` AngeloGioacchino Del Regno
2022-09-28 7:17 ` Krzysztof Kozlowski
2022-09-28 7:40 ` Jianguo Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c46b223e4ba5d1ceb587facf7dd060e6cab9f17.camel@mediatek.com \
--to=jianguo.zhang@mediatek.com \
--cc=alexandre.torgue@foss.st.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=biao.huang@mediatek.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=joabreu@synopsys.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).