From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11DA06F06A; Sun, 9 Feb 2025 11:45:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739101515; cv=none; b=oYtnGngeJIlk5Tb9BY04LO0Hp5rTWx3/3ykRxKfly4wXewa+8g2Y3czJ9F/p3C/RkgPDsLqrwUR3myouLpRWrd3S9d9Nt0jiX2wSp/UzN8kFDCQpF1F2mOA927K1ZXotjKDhGg6CBEWusMcL7jB4d3ozgBKPlfqUwbhJPBh0fB4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739101515; c=relaxed/simple; bh=Av0QYU6wpxgVuFwcAS24I8JUgJ1wCGCWJhmZb+cGJsI=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=qaXbQUGxZqPVPFtV8iLkInE8+OLHm6204iqC4QK1fdHC12pBbmZ/pANZ6Hcvml3gDid+mQVMi84SnV0dr7yVjCR0pe114yW4iEiUlWCQanhnqtf2wFFe6+N7KHpGQAtB7J8jfotaaOZeF284DP/paAj0uq60VrsFNGFE1JKD7UQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OjicF0XW; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OjicF0XW" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0CFACC4CEDD; Sun, 9 Feb 2025 11:45:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739101514; bh=Av0QYU6wpxgVuFwcAS24I8JUgJ1wCGCWJhmZb+cGJsI=; h=Date:Subject:To:References:From:In-Reply-To:From; b=OjicF0XWimMaZwBsAwKDa1eQ8tybOAQk46ys/fmY0tyiD3E2qxXG+CHCPGr2v2WiG N8W/OS6pl/jbJVy8u5eqUQI3PUaKHYuJrHrGapDi8hMjLyOQ3mgZUfwOxPAb7C6ixC PFLYzW/hUKtzEiZ7sjAE3FeEyVbDgZO0oImlCn68sk/xGcFLzPOlBr9GWOSaiFGa1q qdNUjEEElmLve/pRpKJD0mNHmiFwBrKTh4rIpfEgezaZObjpnDqE3PR7ZTMWb/QW4n YjpNQckzP3i9RiJQBI2mbTwGwg1Dya0TaDlSl4IYGA85KJP0VHnkcSSg2w/f2kTwLi KdRFXyBQakrCQ== Message-ID: <7c518972-75df-4c8a-8920-06d5aa2849ae@kernel.org> Date: Sun, 9 Feb 2025 12:45:08 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/3] dt-bindings: i3c: Add Qualcomm I3C master controller bindings To: Mukesh Kumar Savaliya , alexandre.belloni@bootlin.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, jarkko.nikula@linux.intel.com, linux-i3c@lists.infradead.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250205143109.2955321-1-quic_msavaliy@quicinc.com> <20250205143109.2955321-2-quic_msavaliy@quicinc.com> <248000f5-63db-492c-884d-ac72db337493@kernel.org> <0ae3f754-edcb-4b22-9d49-b20ef264554b@quicinc.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <0ae3f754-edcb-4b22-9d49-b20ef264554b@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 06/02/2025 14:43, Mukesh Kumar Savaliya wrote: > Hi Krzysztof, Thanks ! > > On 2/5/2025 8:12 PM, Krzysztof Kozlowski wrote: >> On 05/02/2025 15:31, Mukesh Kumar Savaliya wrote: >>> Add device tree bindings for the Qualcomm I3C master controller. This >>> includes the necessary documentation and properties required to describe >>> the hardware in the device tree. >> >> A nit, subject: drop second/last, redundant "bindings". The >> "dt-bindings" prefix is already stating that these are bindings. > Sure >> See also: >> https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 >> >> Use modern terminology, which means: >> s/master/whatever else or even nothing/ >> See other recent bindings and discussions. >> > Sure >> >>> >>> Signed-off-by: Mukesh Kumar Savaliya >>> --- >>> .../bindings/i3c/qcom,i3c-master.yaml | 57 +++++++++++++++++++ >>> 1 file changed, 57 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/i3c/qcom,i3c-master.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/i3c/qcom,i3c-master.yaml b/Documentation/devicetree/bindings/i3c/qcom,i3c-master.yaml >>> new file mode 100644 >>> index 000000000000..ad63ea779fd6 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/i3c/qcom,i3c-master.yaml >> >> Filename matching compatible. >> > Changed compatible to "qcom,i3c-master" >>> @@ -0,0 +1,57 @@ >>> +# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/i3c/qcom,i3c-master.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Qualcomm I3C master controller >>> + >>> +maintainers: >>> + - Mukesh Kumar Savaliya >>> + >>> +allOf: >>> + - $ref: i3c.yaml# >>> + >>> +properties: >>> + compatible: >>> + const: qcom,geni-i3c >> >> No SoC? So to be sure: you claim all future SoCs will be using exactly >> the same interface. No new compatibles, no new properties will be added. >> > I think i should remove const. kept it for now as no other compatible to > be added as of now. > > let me remove const. No, it does not matter. Keep const. > > SoC name is not required, as this compatible is generic to all the SOCs. That's the statement you make. I accept it. I will bookmark this thread and use it whenever you try to add any future property here (to be clear: you agree you will not add new properties to fulfill *FUTURE* SoC differences). >>> + >>> + reg: >>> + minItems: 1 >> >> Drop >> > Not required ? I see other bindings are using it, so please confirm if i > can remove this. >>> + maxItems: 2 >> >> Drop and instead list and describe items >> > Okay, i can remove maxItems if not mandatory. Taken cdns,i3c-master.yaml > and added these. > >> >>> + >>> + clocks: >>> + minItems: 1 >> >> Look at other bindings. There is never code like this. >> > cdns,i3c-master.yaml taken as reference. >>> + >>> + clock-names: >>> + items: >>> + - const: se-clk >> >> Drop clock-names > Sure, took reference from cdns,i3c-master.yaml. >> >>> + >>> + interrupts-extended: >>> + minItems: 1 >>> + maxItems: 3 >> >> As well - there is never an interrupts-extended property. Just interrupts. >> > No, i see this property many places. Do you mean to say > interrupts-extended can be there in examples but not only add I already wrote what you should do: "Just interrupts." > "interrupts" property here ? > e.g timer/riscv,timer.yaml +41 lists it in yaml also. Please do not take one file and create coding style out of it, but instead look what ~2300 other YAML files do. Best regards, Krzysztof