From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5CDFC6FA8E for ; Wed, 28 Sep 2022 17:38:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234638AbiI1Rig (ORCPT ); Wed, 28 Sep 2022 13:38:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39454 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234625AbiI1Rif (ORCPT ); Wed, 28 Sep 2022 13:38:35 -0400 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DEC91F3916 for ; Wed, 28 Sep 2022 10:38:33 -0700 (PDT) Received: by mail-lj1-x22c.google.com with SMTP id j24so15139272lja.4 for ; Wed, 28 Sep 2022 10:38:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=WJrEm7Gj+RhCZrHxWWorpZ5+layPSsIO3kU2CBr8RUk=; b=kRrYubDuvhSHWTCTehEWYzr77FQ7wdJ7osLeHoj+8yRP5S8AtQgL9fXNusXJuLcBVx 3wi7k1LomwlCl4Xo9UMqDEY23MH8rUzwewo/t6rAV+V+T5JIhNDwXGj/hY7xzWOPzSx1 +juhKcmddu2oEngNSUlYkAIlBQ32DrPabMnqnbEx+2LnKLiJ8YZ/L8FAIugigEHRVGGF gAX7AU0ohWUK02FzN2bXkwqrQNmYREvhlBG461Tal2E798fAjbE0iPdkocyljZKcrrJg cNys14SXZVlpRDlfLgkjsp1U0QhwsQsEX+m3qDEFxsq7BR/8ZI9sbmdf/GMtTir39dYA d8aQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=WJrEm7Gj+RhCZrHxWWorpZ5+layPSsIO3kU2CBr8RUk=; b=tqOv/hcqI1ojPaIirY57kmC6BGWkTBk2/rpnLzuuUNm3KJpCxVS6QgV3BPXVKeFUdJ UHm+jA9zwLKDDjVz+fjQVZk14xpAcTMduXCgGByudsQKeqhYikq3VSI+Y2UiDxq2J5PG hd0FsAymX9oKZkkI425hK7bXtXJkxue3NMWRitXOUQzz6TUsLyVdA4GSo95H6wBTIM3y MKNYsuigM1Rqz1BkF6OSDyE0GBCCR5kAmj3m74tkgtbhjImV51gMIVmifx3HjCluBLSA uT8xEAyjXRek/GKprcuVecKpeYolLjnvJbzR3EJ1pProijtqkxIs6WLv0RPVNsW5ipEQ auQA== X-Gm-Message-State: ACrzQf3VO7MjT7H9A0ZPQbaBPF7dFpJ9ZXPlPUMYXsh8p5B8p0pBwukW BX4KOR8RZS+6W9Ia7xOnhhqqlA== X-Google-Smtp-Source: AMsMyM6B8xC1DZl6OlVbrJI9+S2jVaPRXzvyUtj6TyE2ZIHu8rbXrB11fu2rr8BEymohlF0MeAXLrg== X-Received: by 2002:a2e:9c2:0:b0:26a:cbe5:21ae with SMTP id 185-20020a2e09c2000000b0026acbe521aemr12589964ljj.354.1664386712146; Wed, 28 Sep 2022 10:38:32 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id 16-20020ac24d50000000b0049908e21e26sm527051lfp.253.2022.09.28.10.38.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Sep 2022 10:38:30 -0700 (PDT) Message-ID: <7c65e6f6-54f8-3582-0409-c800e16b8fcb@linaro.org> Date: Wed, 28 Sep 2022 19:38:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH] dt-bindings: clock: split qcom,gcc-sdm660 to the separate file Content-Language: en-US To: Dmitry Baryshkov , Andy Gross , Bjorn Andersson , Konrad Dybcio , Stephen Boyd , Michael Turquette , Rob Herring , Krzysztof Kozlowski , Taniya Das Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org References: <20220928145818.376250-1-dmitry.baryshkov@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20220928145818.376250-1-dmitry.baryshkov@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 28/09/2022 16:58, Dmitry Baryshkov wrote: > Move schema for the GCC on SDM630/SDM636/SDM660 to a separate file to be > able to define device-specific clock properties. > > Signed-off-by: Dmitry Baryshkov > --- > .../bindings/clock/qcom,gcc-other.yaml | 3 - > .../bindings/clock/qcom,gcc-sdm660.yaml | 61 +++++++++++++++++++ > 2 files changed, 61 insertions(+), 3 deletions(-) > create mode 100644 Documentation/devicetree/bindings/clock/qcom,gcc-sdm660.yaml > > diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml > index 76988e04c7db..35fc22a19000 100644 > --- a/Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml > +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml > @@ -24,7 +24,6 @@ description: | > - dt-bindings/clock/qcom,gcc-mdm9607.h > - dt-bindings/clock/qcom,gcc-mdm9615.h > - dt-bindings/reset/qcom,gcc-mdm9615.h > - - dt-bindings/clock/qcom,gcc-sdm660.h (qcom,gcc-sdm630 and qcom,gcc-sdm660) > > allOf: > - $ref: "qcom,gcc.yaml#" > @@ -41,8 +40,6 @@ properties: > - qcom,gcc-msm8974pro > - qcom,gcc-msm8974pro-ac > - qcom,gcc-mdm9615 > - - qcom,gcc-sdm630 > - - qcom,gcc-sdm660 > > required: > - compatible > diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-sdm660.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-sdm660.yaml > new file mode 100644 > index 000000000000..a39f28d37387 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-sdm660.yaml > @@ -0,0 +1,61 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/qcom,gcc-sdm660.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Global Clock & Reset Controller Binding for SDM660/SDM630/SDM636 > + > +maintainers: > + - Stephen Boyd > + - Taniya Das I guess email is not valid anymore. > + > +description: | > + Qualcomm global clock control module which supports the clocks, resets and > + power domains on SDM630, SDM636 and SDM660 > + > + See also: > + - dt-bindings/clock/qcom,gcc-sdm660.h (qcom,gcc-sdm630 and qcom,gcc-sdm660) > + > +$ref: qcom,gcc.yaml# > + > +properties: > + compatible: > + enum: > + - qcom,gcc-sdm630 > + - qcom,gcc-sdm660 > + > + clocks: > + items: > + - description: XO source > + - description: Sleep clock source > + > + clock-names: > + items: > + - const: xo > + - const: sleep_clk > + > + power-domains: > + maxItems: 1 > + > +required: > + - compatible > + > +unevaluatedProperties: false > + > +examples: > + # Example for GCC for SDM660: > + - | > + #include > + clock-controller@100000 { > + compatible = "qcom,gcc-sdm660"; > + #clock-cells = <1>; > + #reset-cells = <1>; > + #power-domain-cells = <1>; > + reg = <0x00100000 0x94000>; reg after compatible? Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof