From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8FF0FA3740 for ; Tue, 25 Oct 2022 19:40:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231639AbiJYTkb (ORCPT ); Tue, 25 Oct 2022 15:40:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231248AbiJYTk3 (ORCPT ); Tue, 25 Oct 2022 15:40:29 -0400 Received: from mail-qv1-xf2f.google.com (mail-qv1-xf2f.google.com [IPv6:2607:f8b0:4864:20::f2f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 701A25AA16 for ; Tue, 25 Oct 2022 12:40:28 -0700 (PDT) Received: by mail-qv1-xf2f.google.com with SMTP id j6so5059470qvn.12 for ; Tue, 25 Oct 2022 12:40:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=PuJ4rqhBVW/pzXuCIr6qAp0C/9agM39YZk4Tyezi0lg=; b=L2kqjdxA4/IcBXtCiww7ZIrzUkvLV+QQMxEBKsv9hiUWXaMwc/uzi0z+O/cOcRG7JV /J1c8ZyXAM9gvNhXIYl7273XQr93hmQedx+ZlTHuC1B/oDk0jk4gHMrfs1OIWoZgr5Zp qSyueabix5LDL24xa9eZdzp0Ojzj0lJt52J6DQ6PJuLScOOUbDKNzJ1pBeXOJQeLmYU8 6nF+RcwAUmuHQJ1po29cdqUOmaUBN1Jcnv5rSBY2Wabdac1z5bB4zugv2mNo94obfeAU 23sIqtykWF1b9ubLcGKJJwi2lMcrN/6AsruNeE2IUUdTRVoVieFZ7ZMKMJT59eqcC0Df 1lnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PuJ4rqhBVW/pzXuCIr6qAp0C/9agM39YZk4Tyezi0lg=; b=fGmQK/5x5/mJYDLiGrVjpFKvTCRpF2moJ/aKJa4+rPYax+IBtSSPrW3NOAxQm7ow9U E9JlfyrY4g1MtK4O+zb8XA1Pknvuvrahs7wyE3XnmRh+AijRObcoxbbHxRMRJlQXCtIQ 7j8ZnEUS7EoJGlYXX1vxnI8OVSmx+ca8OGydTVUxXHKSySjU87xJnlpvBgqD2jNYh2pz sExa1R8xXx1tHFrm74jZ+x26Q1lrK2oPeJxJCf0N+y9SU4O4nNfm7hMDmMxD+BvfkXrt Fq2S9niK7h1/YCRcyFq9DxcpVxxWoCMVqyO++Ez/ZeEY9in2Fg3aYj1ZIQPHPYIVdewS 6atw== X-Gm-Message-State: ACrzQf2xyujhM637Ngd/oM0arIBHdm8Kxq+MdiBzAC/YzATVYA+Q1fjj 49PWlLA4pUG7emxhhwR8RBeaPg== X-Google-Smtp-Source: AMsMyM7+P6vDmIeHHpQ1nGvGx/DyvpypIrLH2RG7R10wpTZc9qLl/phhWX5f1YYNDk+MUG5rmd8g4g== X-Received: by 2002:ad4:5eca:0:b0:4ba:535a:6d45 with SMTP id jm10-20020ad45eca000000b004ba535a6d45mr21478617qvb.56.1666726827588; Tue, 25 Oct 2022 12:40:27 -0700 (PDT) Received: from [192.168.1.11] ([64.57.193.93]) by smtp.gmail.com with ESMTPSA id l2-20020a05620a28c200b006e8f8ca8287sm2653378qkp.120.2022.10.25.12.40.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Oct 2022 12:40:26 -0700 (PDT) Message-ID: <7c67c721-685a-fa0e-ab4b-41b7de3ea0a0@linaro.org> Date: Tue, 25 Oct 2022 15:40:25 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH v2 2/2] dt-bindings: soc: add loongson2 guts Content-Language: en-US To: Yinbo Zhu , Rob Herring , Krzysztof Kozlowski , Arnd Bergmann , Hector Martin , Lubomir Rintel , Conor Dooley , Linus Walleij , Hitomi Hasegawa , Heiko Stuebner , Brian Norris , Sven Peter , loongarch@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221025035128.21068-1-zhuyinbo@loongson.cn> <20221025035128.21068-2-zhuyinbo@loongson.cn> From: Krzysztof Kozlowski In-Reply-To: <20221025035128.21068-2-zhuyinbo@loongson.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 24/10/2022 23:51, Yinbo Zhu wrote: > Add the loongson2 soc guts driver binding with DT schema format > using json-schema. > > Signed-off-by: Yinbo Zhu > --- > .../soc/loongson/loongson,ls2k-guts.yaml | 37 +++++++++++++++++++ Looks like wrong location, although difficult to judge because you did not describe the hardware at all. If this is chipinfo-like device, then Documentation/devicetree/bindings/hwinfo/. > MAINTAINERS | 1 + > 2 files changed, 38 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/loongson/loongson,ls2k-guts.yaml > > diff --git a/Documentation/devicetree/bindings/soc/loongson/loongson,ls2k-guts.yaml b/Documentation/devicetree/bindings/soc/loongson/loongson,ls2k-guts.yaml > new file mode 100644 > index 000000000000..2502f8aeb74d > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/loongson/loongson,ls2k-guts.yaml > @@ -0,0 +1,37 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/soc/loongson/loongson,ls2k-guts.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Loongson2 GUTS driver. Drop "driver." unless you refer to some hardware (like motor driver?). > + > +maintainers: > + - Yinbo Zhu > + > +description: | > + GUTS driver was to manage and access global utilities block. Initially Drop "driver" and describe instead what is GUTS, including its acronym, > + only reading SVR and registering soc device are supported. Entire sentence describe Linux driver - drop it. Instead describe the device, the hardware. > + > +properties: > + compatible: > + const: loongson,ls2k-guts > + > + reg: > + maxItems: 1 > + > + little-endian: true > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + guts: guts@1fe00000 { Node names should be generic. https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation Best regards, Krzysztof