From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.168.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795010638; b=Al40aGl/xBiOtkvZHR14GGJQGsWKPSOUzT2QmM/jsv+/WKTQZ8VaxCnHme5qtTdTIWF6 AZyjmzsrizfdThu0axUWqIJ+m72xESQZwu+5w8YMmcq8ookVHW5vT4Z0VS6RFUR8fR5jS XH5OpaleaZdbyt4COIOoWwbZK8rEuCfHMRJG1+IQFESIQyksvsMZQKrevkWJZ1P0qaFTU rBtjqBxZ3UU1uA51xMOpOYi14wqT3iptiGjWChm3BcDWhqffLkB/uvHQg+qdl0Tjibcuw ryTmhM3Sc4KB7Nn+zX2Q7wh0/11wBAkyQdVvqUBNrgT87xgQxWnNAy9ZVM7yIAytdAA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795010638; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:Message-ID: Date:MIME-Version:User-Agent:Subject:To:Cc:References: Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:X-Authority-Analysis:X-Proofpoint-ORIG-GUID: X-Proofpoint-Spam-Details-Enc:X-Proofpoint-GUID: X-Proofpoint-Spam-Info:X-Proofpoint-Virus-Version: X-Proofpoint-Spam-Details; bh=U4yvW/bZFXVXxFQbUaDkeXJTatVe0Umzb3Tgo9Fy4/Y=; b=eiAg/gZ8dyeeUfyW44v6UesRzAj3/ndN5RPzrcBq/S4yS5FkxxI67jncG84231IlScga RI8hwGLjUITPjg48iL3x+/VqJE0NMRBzQVAL7otRybCyqqlui3FfY4EzUuyjGiPLRn3w9 ixr8v+SztV0RhVau63GcwWMhnyIv5fbJ4twODRfebtPMJ39jQ8Idnu1brsPjLTMivSEA2 Yho2RjriVi3BuNYm1vGRsxX5vIpzLKE4SMzaSq7azEXSd2W186uByXGS2AWVjZ7PHF4O/ QeBAox7S7+zgGjcqqyQDQFWP1Mk+ShMMg4WOcTYCILPBGdHwKp9yaF20BbBmEOL7bhA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=ZNTbekvC; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=W8JKXJji; arc=none smtp.remote-ip=205.220.168.131 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FE95606A320 for ; Wed, 18 Nov 2026 14:03:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 1FE95606A320 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=ZNTbekvC; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=W8JKXJji Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6AIDQKoN3421962 for ; Wed, 18 Nov 2026 14:03:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= U4yvW/bZFXVXxFQbUaDkeXJTatVe0Umzb3Tgo9Fy4/Y=; b=ZNTbekvCdAZRQWOO zU/KTAPc1uzOAY2LAk+B0Sd9kdxLzOSH2EPxIArWsBUTw/vU76jxIoyQ5W+8UUAP m+lXUduoESBfx2xMu9RSenQPLjR8OCMQcMzGzT3Gq7DtuMpKqPx2T6+osJvyBtfV iysTlSGSY/qN10QBKBLAgPJpGey1xC+cIBGY4kdKcJ1a6jWFKBPzU2s1MVab6K5o 2PBxI3Vxxkv/K1nqKndEnXbWd4Rj5qy/bKg5v24lWsfs+Pveh0vsCJK8RILHWf9y kPewHEJOsGElfRO5WQ3/n1es3j2REFxDQgiEEljLIZU1iF3kQWCAxEJv9BQs2n7A RGfXhg== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4j0yv9k98j-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 18 Nov 2026 14:03:57 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-3b08aee6b3eso944404a91.3 for ; Wed, 18 Nov 2026 06:03:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1795010636; x=1795615436; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=U4yvW/bZFXVXxFQbUaDkeXJTatVe0Umzb3Tgo9Fy4/Y=; b=W8JKXJjiMtM6arjDt949RNl9glDPPvXgXrFykUxW0Y24e/eJQ2Hzz/RyhRZlcuVphe Ebe9UY71CBqb7R5bDrCTcGZXRBGxK6Zq13FpBsq04sP5JuSWfFUhbpSO/whQURdWd3de WSSKMNOOlqS5YGk28DFuTQNFjeQ7IZYQfO7/tTajAVdF4SyKvKFSROXO9/amHcNHyxfB iRBSycpffIaVjJGcBuUc3dVLcgRL8deLvLLXLl9sExlvlp05sLI0FKclUajeaIMZufGY l77X9aYdE/QBUGujQGGvqkapcOhmk5uXhB+WkDkze417UAnoz/fVlhy2BXmvl0gsdOyh PFLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795010636; x=1795615436; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=U4yvW/bZFXVXxFQbUaDkeXJTatVe0Umzb3Tgo9Fy4/Y=; b=hi4Oeq2sm/bGZDHVE3k0umYkOfmNnhZSFkQ5md9MJ7Q8viiNllyrdIQQEFQpuw8Ve+ RyEws/A0UHXo+1/00oB75Lcv2al0/Am0e7fVCuilRXpBGpQniePRcP49nrSB4APXbc+u sS2iE/2bC1EX9ZIHvInxjyWOW4UaxoW8M6dAv3aYWKsuIi0yiI8FiIa0HkMPgt0mvRuN 0CrEf3DPK3CZFbkyJdYBquY+K+64lQ8KKFp6KPaJ9ey8CE9V66gkM3ln2qsyxKSCFEIc qfIWOKGGldcEmyM0YVuSpUWclZh6FR6JXc363PHu9oX/tbPhA3Kp7xKex4dtmCRVLDcm bDVA== X-Forwarded-Encrypted: i=1; AL+hErESFp6i8h/GExC9OGbPTw75HZ15whGoqe015py6qjUDSYd1MXCVeQ5wIiJOiI6sxZuBDWuBpX+dd52O@vger.kernel.org X-Gm-Message-State: APuU4Z8JDvvivPZjQpBFmIMDo19AO0J51Pz11B6EVS01ZtaLEln1Fvlm eHKwSEyl5BNvBy7jDD+HuRvAOWdRd0UCWZed6Ov48WxUTvGPnrBvRsrcCe9k/hukitXHFjv6rbe JM+f8uEdBI3utquBo4QhYlNjMa5OO8NuMwsbA8C6aLd7i/Qeokg+SWi+kdmEcgo6X X-Gm-Gg: AZFdTZcR+eRwaqsNjrYkqPopatmWgNjSKH0rhxD6sWI1/OPY1hyROWmxBwsxyVkS/bA qjTinVk8uDPB/qPrEBDZ0Re/7gdhYDb0BEJ0FK1anZghlpy+iOvz0ZHGYjN9GOwSXsYJmk/Mb25 /5B/fu3VSoGzFDDJZFYKFblEsqo1iPsCIVlI8zNR4B34yvfE/xPcTqMe/BgYM273KbHSMMJl3QH 6J3EeRa/s2/gswWVBtjqHc37g5QnvGt0SRv10eeb0qc7LjuPYkVgd5zD0wuKUTLMAy91nA01TpI RjdQDsDQILh4hKdOshXB+hbOiXjarYfGfheSu+h93f/BCuEWck8b2i05JiMHG02ma8tdFCb44G2 Tb1pTSMo8UrN5D2Ak9Im9MlJwFMHrNZK4PGn/wksaeUYAyM53RKjbXaa7KKfFnvwg34GGlGh6rd bOdVz/Rg== X-Received: by 2002:a17:90b:4c92:b0:3b3:b71e:b2e7 with SMTP id 98e67ed59e1d1-3b3d0766880mr2786137a91.36.1795010636369; Wed, 18 Nov 2026 06:03:56 -0800 (PST) X-Received: by 2002:a17:90b:4c92:b0:3b3:b71e:b2e7 with SMTP id 98e67ed59e1d1-3b3d0766880mr2786113a91.36.1795010635774; Wed, 18 Nov 2026 06:03:55 -0800 (PST) Received: from [10.218.9.75] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2eff5ed13a2sm14908515ad.6.2026.11.18.06.03.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Nov 2026 06:03:55 -0800 (PST) Message-ID: <7c67eec5-b382-4e58-bf3b-09df69752f5e@oss.qualcomm.com> Date: Wed, 18 Nov 2026 19:33:42 +0530 X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v27 02/10] power: reset: reboot-mode: Add support for predefined reboot modes To: Sebastian Reichel Cc: Lorenzo Pieralisi , Arnd Bergmann , Bjorn Andersson , Rob Herring , Souvik Chakravarty , Krzysztof Kozlowski , Matthias Brugger , Mark Rutland , Conor Dooley , Konrad Dybcio , John Stultz , Moritz Fischer , "Rafael J. Wysocki" , Daniel Lezcano , Christian Loehle , Lee Jones , Ulf Hansson , Pavan Kondeti , Abel Vesa , Bartosz Golaszewski , Sudeep Holla , Andy Yan , Florian Fainelli , Krzysztof Kozlowski , Dmitry Baryshkov , Mukesh Ojha , Andre Draszik , Greg Kroah-Hartman , Kathiravan Thirumoorthy , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Srinivas Kandagatla References: <20261029-arm-psci-system_reset2-vendor-reboots-v27-0-fa4b3ff1359b@oss.qualcomm.com> <20261029-arm-psci-system_reset2-vendor-reboots-v27-2-fa4b3ff1359b@oss.qualcomm.com> Content-Language: en-US From: Shivendra Pratap In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=QenzLcbv c=1 sm=1 tr=0 ts=6afdb04d cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=zJRp6_cAMcgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=JKe0p63tuqD2XvbLR5EA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-ORIG-GUID: SLau7hIfv4g-flzcrl9u7OZo8tQ8fGiO X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMTE4MDA1NSBTYWx0ZWRfX3w5x8f9I0wxc oykOcy6tikrWRFFzF9fWMavFLrkUpRcU2lPD7aojFsCWmPl91vGJQo8JfCm+WNycVMEJtckmkdS 2LGhBXM0jHTb5gGlyYp4TAy1SLXUAexsRsQhO9QXJStRs5lDwxm2TZwtIOS8FucGu2shIEvGPjY IYOG/zIxT1zOU00V2QGxICtgg9wfSQIW04mn5XimONUmvf2X5iGAvTDwXDPUdL0xjC3PUOTfc1t bRsbfjplLqzCnL3xKb+1D9aW6Fys/S7fJ/OBDzyLzaL71VoPWY55xJcqvoLSUQBvRfy0MA+3PfV y4l1rsA1xTKmwyuM+U+inNO4ENv57jgaV/OH0vZWX4HZdVEANWOO3xUXemqjPuzRSbGcniAu3p6 +mjIfKal4KJtfs/NTAU84+NU1zFzTg0M0Pbb4StxpyeV9Msnmp7HG0qeRB3DO5rqYOKZyT0HnV5 B97hvoJsxctOQdENufg== X-Proofpoint-GUID: SLau7hIfv4g-flzcrl9u7OZo8tQ8fGiO X-Proofpoint-Spam-Info: AW1haW4tMjYxMTE4MDA1NSBTYWx0ZWRfX799iEdeWQ2jH ExGKF2RUS+iCJWviKHP9U5OdaXfcdPyCZ6XwYZSa5AjVUOnNI4mKRgKNG+PWLORKBUhTPQRhxLe gujOCKGdS4dUrY2Vh/6FF7xjUvQtacE= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-11-18_04,2026-11-16_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 clxscore=1015 suspectscore=0 impostorscore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2611040001 definitions=main-2611180055 On 11/16/2026 4:43 AM, Sebastian Reichel wrote: > Hi, > > On Thu, Oct 29, 2026 at 02:30:56PM +0530, Shivendra Pratap wrote: >> reboot-mode based drivers can define a reboot-mode by adding it under >> the reboot-mode node in device tree. This limits such drivers, to define >> any predefined reboot-modes statically within the driver and creates a >> dependency on device-tree. >> >> Extend the reboot-mode framework to support driver-defined predefined >> reboot modes. Add a centralized initcall to initialize driver state >> along with predefined modes. >> >> Signed-off-by: Shivendra Pratap >> --- >> drivers/power/reset/nvmem-reboot-mode.c | 7 +- >> drivers/power/reset/qcom-pon.c | 7 +- >> drivers/power/reset/reboot-mode.c | 192 ++++++++++++++++++++++--------- >> drivers/power/reset/syscon-reboot-mode.c | 7 +- >> include/linux/reboot-mode.h | 26 ++++- >> 5 files changed, 175 insertions(+), 64 deletions(-) >> >> diff --git a/drivers/power/reset/nvmem-reboot-mode.c b/drivers/power/reset/nvmem-reboot-mode.c >> index d260715fccf6..700732ed0f5b 100644 >> --- a/drivers/power/reset/nvmem-reboot-mode.c >> +++ b/drivers/power/reset/nvmem-reboot-mode.c >> @@ -51,8 +51,11 @@ static int nvmem_reboot_mode_probe(struct platform_device *pdev) >> if (!nvmem_rbm) >> return -ENOMEM; >> >> - nvmem_rbm->reboot.dev = &pdev->dev; >> - nvmem_rbm->reboot.write = nvmem_reboot_mode_write; >> + ret = reboot_mode_driver_init(&nvmem_rbm->reboot, &pdev->dev, >> + nvmem_reboot_mode_write, NULL, >> + NULL, 0); >> + if (ret) >> + return ret; >> >> nvmem_rbm->cell = devm_nvmem_cell_get(&pdev->dev, "reboot-mode"); >> if (IS_ERR(nvmem_rbm->cell)) { >> diff --git a/drivers/power/reset/qcom-pon.c b/drivers/power/reset/qcom-pon.c >> index cd7ba680b841..55aaa99d88b6 100644 >> --- a/drivers/power/reset/qcom-pon.c >> +++ b/drivers/power/reset/qcom-pon.c >> @@ -84,9 +84,12 @@ static int qcom_pon_probe(struct platform_device *pdev) >> reason_shift = (long)of_device_get_match_data(&pdev->dev); >> >> if (reason_shift != NO_REASON_SHIFT) { >> - pon->reboot_mode.dev = &pdev->dev; >> + error = reboot_mode_driver_init(&pon->reboot_mode, &pdev->dev, >> + qcom_pon_reboot_mode_write, NULL, >> + NULL, 0); >> + if (error) >> + return error; >> pon->reason_shift = reason_shift; >> - pon->reboot_mode.write = qcom_pon_reboot_mode_write; >> error = devm_reboot_mode_register(&pdev->dev, &pon->reboot_mode); >> if (error) { >> dev_err(&pdev->dev, "can't register reboot mode\n"); >> diff --git a/drivers/power/reset/reboot-mode.c b/drivers/power/reset/reboot-mode.c >> index 328fa37598df..fd61de226383 100644 >> --- a/drivers/power/reset/reboot-mode.c >> +++ b/drivers/power/reset/reboot-mode.c >> @@ -30,12 +30,12 @@ struct reboot_mode_sysfs_data { >> struct list_head head; >> }; >> >> -static inline void reboot_mode_release_list(struct reboot_mode_sysfs_data *priv) >> +static void reboot_mode_release_list(struct list_head *head) >> { >> struct mode_info *info; >> struct mode_info *next; >> >> - list_for_each_entry_safe(info, next, &priv->head, list) { >> + list_for_each_entry_safe(info, next, head, list) { >> list_del(&info->list); >> kfree_const(info->mode); >> kfree(info); >> @@ -119,6 +119,80 @@ static int reboot_mode_notify(struct notifier_block *this, >> return NOTIFY_DONE; >> } >> >> +/** >> + * reboot_mode_driver_init - Initialize reboot-mode state >> + * @reboot: reboot mode driver object to initialize >> + * @dev: backing device >> + * @write: write callback to program a single magic value >> + * @write_array: write callback to program multiple magic values >> + * @predefined_modes: optional predefined reboot-mode table >> + * @predefined_mode_count: number of entries in @predefined_modes >> + * >> + * Exactly one write callback must be provided by the driver. >> + * >> + * This function must be called with a valid @dev before calling >> + * reboot_mode_register(). >> + * >> + * Returns: 0 on success or -EINVAL if callback/predefined mode configuration >> + * is invalid. >> + */ >> +int reboot_mode_driver_init(struct reboot_mode_driver *reboot, >> + struct device *dev, >> + int (*write)(struct reboot_mode_driver *reboot, unsigned int magic), >> + int (*write_array)(struct reboot_mode_driver *reboot, >> + const u32 *magic, u32 count), >> + const struct reboot_mode_entry *predefined_modes, >> + size_t predefined_mode_count) >> +{ >> + if (!reboot || !dev) >> + return -EINVAL; >> + >> + if (!write == !write_array) >> + return -EINVAL; >> + >> + memset(reboot, 0, sizeof(*reboot)); >> + reboot->dev = dev; >> + reboot->write = write; >> + reboot->write_array = write_array; >> + reboot->predefined_modes = predefined_modes; >> + reboot->predefined_mode_count = predefined_mode_count; >> + INIT_LIST_HEAD(&reboot->head); >> + >> + return 0; >> +} >> +EXPORT_SYMBOL_GPL(reboot_mode_driver_init); >> + >> +static struct mode_info *reboot_mode_create_info(struct device *dev, const char *mode, >> + const u32 *magic, int count) >> +{ >> + struct mode_info *info; >> + >> + if (!mode || mode[0] == '\0') { >> + dev_err(dev, "invalid mode name\n"); >> + return ERR_PTR(-EINVAL); >> + } >> + >> + info = kzalloc_obj(*info, GFP_KERNEL); >> + if (!info) >> + return ERR_PTR(-ENOMEM); > > info = kzalloc_obj(*info); sure, will update this in next post. thanks, Shivendra