From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1993C7619A for ; Wed, 12 Apr 2023 16:16:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229950AbjDLQQg (ORCPT ); Wed, 12 Apr 2023 12:16:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230255AbjDLQQa (ORCPT ); Wed, 12 Apr 2023 12:16:30 -0400 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E0D7C76BB for ; Wed, 12 Apr 2023 09:16:03 -0700 (PDT) Received: by mail-ej1-x634.google.com with SMTP id dm2so30329888ejc.8 for ; Wed, 12 Apr 2023 09:16:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681316162; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xKz2CfdmkyWEUAUCRBGTeQXDG/9nQXron/CwZa9Nm00=; b=g7jiaNa/w7rvSAY10RFzRhPYx6wX3SzW9Ltp47xv27yKDwNXQ8wwQshMGu1UwZBDnP nIoBoAzWw9eAyBnL5DQdKWgKntxvoQIFaEWI3xGsCqDukrJo9+ybXsuRl1On4LJbWSUJ Md8iI+45YnPbziICs08oDOd+jDcFsHhc6Vc+ESQUqAnauTaXLTnS5oab5edjyN4Kir+j 1d71UXvEFipu+X9znuLgywbDpYEeANh+IyLOrDyESFwQ3IJnAP73JNvFiqdkvfmdtP0k tpgP+Ln/0OJW0PPvCjTmfjy8HcmYk/A44noUGcPZnR1PoP/iAyo8OdZgXB9zJmK3kzTz 6jxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681316162; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xKz2CfdmkyWEUAUCRBGTeQXDG/9nQXron/CwZa9Nm00=; b=hQoyq8zamF2YIKeiRjLVGwiAreup9QYWk3mhtUW5YqhONakf121M4JW+m2aZPP5yQC 1Y37fg7Cirgw6JTkF1xW2IJOpEpIFe8+dpzEJsSmxwVQFb29K/8sfrhOvxf83+Oj4VZV ZdmGkPV87OC0g9uYRmK17EURnfIRXovpk9sTXvFCvoMzOmC/jEEUBr4yERIf/0etQ4/l lDic2/wn9Oiv2zKVFWl28bk3//VIGGcPobDIbXpyPi82xg168l9hN5pmnDkQ+Wu9sjjI CUdV/PcVv7YSkkslg0WZtsPwPKXgAc5TL7Llbd55gxjdEPBMRW0NR6Doh50UQClJy3uK lcGw== X-Gm-Message-State: AAQBX9e5tjy0ieUCWtCcE54nzpqN92QE2BmWWpdMfyX45pXQ664ZDH5+ fxFQSi5OrNI/mTFivrJ7NnUoBA== X-Google-Smtp-Source: AKy350Yl7iVyPSmeKdJ9g9LAu8gPmo81pX9ruC7lLLt8C82rDZNRUAlOPGbHNe3gHcL/ST8gYVF1ew== X-Received: by 2002:a17:906:3b8f:b0:94a:6fc2:75b7 with SMTP id u15-20020a1709063b8f00b0094a6fc275b7mr10639381ejf.33.1681316162374; Wed, 12 Apr 2023 09:16:02 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:938a:b3db:7c59:795e? ([2a02:810d:15c0:828:938a:b3db:7c59:795e]) by smtp.gmail.com with ESMTPSA id sa3-20020a1709076d0300b0094e4b8816e0sm1153036ejc.217.2023.04.12.09.16.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Apr 2023 09:16:01 -0700 (PDT) Message-ID: <7c7afc80-713f-1949-4feb-f5f2d192569c@linaro.org> Date: Wed, 12 Apr 2023 18:16:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v2 2/7] dt-bindings: soundwire: qcom: add 16-bit sample interval Content-Language: en-US To: Srinivas Kandagatla , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Vinod Koul , Bard Liao , Pierre-Louis Bossart , Sanyog Kale , Rao Mandadapu , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Cc: Patrick Lai References: <20230403132503.62090-1-krzysztof.kozlowski@linaro.org> <20230403132503.62090-3-krzysztof.kozlowski@linaro.org> <94590a79-cae3-7b88-8f02-0c356adf06b7@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <94590a79-cae3-7b88-8f02-0c356adf06b7@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 12/04/2023 17:28, Srinivas Kandagatla wrote: > > > On 03/04/2023 14:24, Krzysztof Kozlowski wrote: >> The port sample interval was always 16-bit, split into low and high >> bytes. This split was unnecessary, although harmless for older devices >> because all of them used only lower byte (so values < 0xff). With >> support for Soundwire controller on Qualcomm SM8550 and its devices, >> both bytes will be used, thus add a new 'qcom,ports-sinterval' property >> to allow 16-bit sample intervals. >> >> Signed-off-by: Krzysztof Kozlowski >> --- >> .../bindings/soundwire/qcom,soundwire.yaml | 22 +++++++++++++++++-- >> 1 file changed, 20 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/soundwire/qcom,soundwire.yaml b/Documentation/devicetree/bindings/soundwire/qcom,soundwire.yaml >> index c283c594fb5c..883b8be9be1b 100644 >> --- a/Documentation/devicetree/bindings/soundwire/qcom,soundwire.yaml >> +++ b/Documentation/devicetree/bindings/soundwire/qcom,soundwire.yaml >> @@ -86,7 +86,7 @@ properties: >> qcom,ports-sinterval-low: >> $ref: /schemas/types.yaml#/definitions/uint8-array >> description: >> - Sample interval low of each data port. >> + Sample interval (only lowest byte) of each data port. >> Out ports followed by In ports. Used for Sample Interval calculation. >> Value of 0xff indicates that this option is not implemented >> or applicable for the respective data port. >> @@ -94,6 +94,19 @@ properties: >> minItems: 3 >> maxItems: 16 >> >> + qcom,ports-sinterval: >> + $ref: /schemas/types.yaml#/definitions/uint32-array > > Should this not be ref: /schemas/types.yaml#/definitions/uint16-array ? Same answer as for Rob: Because I am afraid it will grow in next version to 24 or 32 bits. I can change easily maximum, but if I put here uint16-array, all DTS will have /bytes 16/ annotation. Best regards, Krzysztof