devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm: expressatt: fix pm8921_l6 regulator
@ 2024-09-17  4:48 Rudraksha Gupta via B4 Relay
  2024-09-17  6:02 ` Krzysztof Kozlowski
  0 siblings, 1 reply; 3+ messages in thread
From: Rudraksha Gupta via B4 Relay @ 2024-09-17  4:48 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, Rudraksha Gupta

From: Rudraksha Gupta <guptarud@gmail.com>

The SD card refuses to work because the regulator is turned off. Enable
it by default.

Signed-off-by: Rudraksha Gupta <guptarud@gmail.com>
---
 arch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dts b/arch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dts
index af6cc6393d74..13c102a562ab 100644
--- a/arch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dts
+++ b/arch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dts
@@ -253,6 +253,7 @@ pm8921_l5: l5 {
 		};
 
 		pm8921_l6: l6 {
+			regulator-always-on;
 			regulator-min-microvolt = <2950000>;
 			regulator-max-microvolt = <2950000>;
 			bias-pull-down;

---
base-commit: 98f7e32f20d28ec452afb208f9cffc08448a2652
change-id: 20240916-sd-card-regulator-a71268ca47e8

Best regards,
-- 
Rudraksha Gupta <guptarud@gmail.com>



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm: expressatt: fix pm8921_l6 regulator
  2024-09-17  4:48 [PATCH] arm: expressatt: fix pm8921_l6 regulator Rudraksha Gupta via B4 Relay
@ 2024-09-17  6:02 ` Krzysztof Kozlowski
  2024-09-17  7:51   ` Rudraksha Gupta
  0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2024-09-17  6:02 UTC (permalink / raw)
  To: guptarud, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel

On 17/09/2024 06:48, Rudraksha Gupta via B4 Relay wrote:
> From: Rudraksha Gupta <guptarud@gmail.com>
> 
> The SD card refuses to work because the regulator is turned off. Enable
> it by default.

That's odd. Are you sure regulator is provided in SD card node? Is it
SDCC1 or SDCC3?

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm: expressatt: fix pm8921_l6 regulator
  2024-09-17  6:02 ` Krzysztof Kozlowski
@ 2024-09-17  7:51   ` Rudraksha Gupta
  0 siblings, 0 replies; 3+ messages in thread
From: Rudraksha Gupta @ 2024-09-17  7:51 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel

> That's odd. Are you sure regulator is provided in SD card node? Is it
> SDCC1 or SDCC3?

I believe it's SDCC3. Unfortunately, I don't think this patch is the 
solution either anymore. It was working with this patch consistently, 
but now my phone just hangs on mounting the SD card like before. I've 
tried a combination of GPT and MSDOS + vfat, ext2, and ext4. I'm not 
sure what I'm doing wrong cause the SD card consistently works on the 
downstream Linux kernel :(

Sorry for wasting your time


Thanks,

Rudraksha


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-09-17  7:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-17  4:48 [PATCH] arm: expressatt: fix pm8921_l6 regulator Rudraksha Gupta via B4 Relay
2024-09-17  6:02 ` Krzysztof Kozlowski
2024-09-17  7:51   ` Rudraksha Gupta

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).