From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3257C4332F for ; Fri, 11 Nov 2022 16:42:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233886AbiKKQmI (ORCPT ); Fri, 11 Nov 2022 11:42:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234041AbiKKQmH (ORCPT ); Fri, 11 Nov 2022 11:42:07 -0500 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D9F360E93 for ; Fri, 11 Nov 2022 08:42:05 -0800 (PST) Received: by mail-wr1-x42e.google.com with SMTP id h9so7211902wrt.0 for ; Fri, 11 Nov 2022 08:42:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KRDq3YvWP3xlx40agy7LwTpV95X9uRpVaWN3hJZiIrE=; b=CVsNX79HlQ0xGOF1Z1TKcpj8NMOVjQOldIQpoV1xWeKqERQAHxdQfwaVlfzXCpjA/0 QFuj9ImG3K0oOKY+xgpIvc06pSuEnvTxfITNulGEfv/Q+VluUGXs6XGbLS7JHWMk8Ncq 62Y5wSWP1JUVMzcXLtKhZ5cpoQgqkj+DhD6oU4rIn/YOvky3+//LewKDXNxVSSFQt2gB rgBq/8DDq74p0bOp0yWsSzJl6ppvhItIllWn3wG8hxANEprfRGg0FryKrHFr9vUVn5Jb RAj0NVLpco40QSCw2A/B+Zftk81f26r3BkkCM3vzoEUTJKZffoczl1c1+ycdSvbxYt/C OGmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KRDq3YvWP3xlx40agy7LwTpV95X9uRpVaWN3hJZiIrE=; b=2/aNkng5dpnxV9sV7XJdSzhAfZT16mZlgVOb9QBOR+UsuB7QCRq7dX5ZSRLOaaHczh QPWPqBoIGNtGeJeGEooZfUe6CdFFryY3qMH/VEDENwox5mkKQ7NTItC4tCOWK9XIjqar CZ620yVdI76VFwZniIQuJNfYmCFKzLq9zUNAIrpfPqrRk+Vd9IMtQHpUTag6t11LBkk+ SXgRjY+Ppb2DtU5dWBwxspmjm98YCYLs7/TDIUzb4uZ07JmTm+k1SIRYD62TARjsk/EU eVwMDxKxdzJ/V3PvcCBFzL+SfgawueRPBsznPclMa5ZoQpuPB7UdXxgxTY6zKI9LBcUM 6pIQ== X-Gm-Message-State: ANoB5pnFPxR6cRoEZn2yIfrWlwTOoyN4vpPtazj4TsYT/qtpTwmGpvYb S1XAQGSVBjZM+x1zDbWzruI4Tw== X-Google-Smtp-Source: AA0mqf4CB8B5ldRLG2ZTP+StIEXMyDGoczXmUgfdXQ4MPh8CPep7VpfwIc0MBXZUi8VEgrQHfbasnQ== X-Received: by 2002:adf:f08a:0:b0:22e:37d1:b598 with SMTP id n10-20020adff08a000000b0022e37d1b598mr1796487wro.377.1668184924029; Fri, 11 Nov 2022 08:42:04 -0800 (PST) Received: from [192.168.1.195] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id r15-20020a05600c35cf00b003a84375d0d1sm10299100wmq.44.2022.11.11.08.42.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Nov 2022 08:42:03 -0800 (PST) Message-ID: <7cdb914a-df88-ca11-45d3-d370d5c94bcd@linaro.org> Date: Fri, 11 Nov 2022 16:42:02 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v2 2/2] ASoC: codecs: wsa883x: Use proper shutdown GPIO polarity Content-Language: en-US To: Krzysztof Kozlowski , Banajit Goswami , Andy Gross , Bjorn Andersson , Konrad Dybcio , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221110133512.478831-1-krzysztof.kozlowski@linaro.org> <20221110133512.478831-2-krzysztof.kozlowski@linaro.org> From: Srinivas Kandagatla In-Reply-To: <20221110133512.478831-2-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 10/11/2022 13:35, Krzysztof Kozlowski wrote: > The shutdown GPIO is active low (SD_N), but this depends on actual board > layout. Linux drivers should only care about logical state, where high > (1) means shutdown and low (0) means do not shutdown. > > Invert the GPIO to match logical value. > > Fixes: 43b8c7dc85a1 ("ASoC: codecs: add wsa883x amplifier support") > Signed-off-by: Krzysztof Kozlowski > > --- Reviewed-by: Srinivas Kandagatla > > Changes since v1: > 1. None. > --- > sound/soc/codecs/wsa883x.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sound/soc/codecs/wsa883x.c b/sound/soc/codecs/wsa883x.c > index c7b10bbfba7e..77a7dd3cf495 100644 > --- a/sound/soc/codecs/wsa883x.c > +++ b/sound/soc/codecs/wsa883x.c > @@ -1392,7 +1392,7 @@ static int wsa883x_probe(struct sdw_slave *pdev, > } > > wsa883x->sd_n = devm_gpiod_get_optional(&pdev->dev, "powerdown", > - GPIOD_FLAGS_BIT_NONEXCLUSIVE); > + GPIOD_FLAGS_BIT_NONEXCLUSIVE | GPIOD_OUT_HIGH); > if (IS_ERR(wsa883x->sd_n)) { > dev_err(&pdev->dev, "Shutdown Control GPIO not found\n"); > ret = PTR_ERR(wsa883x->sd_n); > @@ -1411,7 +1411,7 @@ static int wsa883x_probe(struct sdw_slave *pdev, > pdev->prop.simple_clk_stop_capable = true; > pdev->prop.sink_dpn_prop = wsa_sink_dpn_prop; > pdev->prop.scp_int1_mask = SDW_SCP_INT1_BUS_CLASH | SDW_SCP_INT1_PARITY; > - gpiod_direction_output(wsa883x->sd_n, 1); > + gpiod_direction_output(wsa883x->sd_n, 0); > > wsa883x->regmap = devm_regmap_init_sdw(pdev, &wsa883x_regmap_config); > if (IS_ERR(wsa883x->regmap)) {