From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: forbidden405@outlook.com, Ulf Hansson <ulf.hansson@linaro.org>,
Jaehoon Chung <jh80.chung@samsung.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: tianshuliang <tianshuliang@hisilicon.com>,
Jiancheng Xue <xuejiancheng@hisilicon.com>,
Shawn Guo <shawn.guo@linaro.org>, David Yang <mmyangfl@gmail.com>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH RFC v4 4/4] dt-binding: mmc: histb-dw-mshc: Add Hi3798MV200 compatible string
Date: Sun, 16 Apr 2023 13:16:31 +0200 [thread overview]
Message-ID: <7cdf170f-1045-db73-df87-fd9da693da28@linaro.org> (raw)
In-Reply-To: <20230415-mmc-hi3798mv200-v4-4-44096e187f53@outlook.com>
On 16/04/2023 11:19, Yang Xiwen via B4 Relay wrote:
> From: Yang Xiwen <forbidden405@outlook.com>
>
> Add Hi3798MV200 compatible string and an extra clock for it.
>
> Signed-off-by: Yang Xiwen <forbidden405@outlook.com>
> ---
> .../bindings/mmc/hisilicon,histb-dw-mshc.yaml | 26 +++++++++++++++++++++-
> 1 file changed, 25 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/hisilicon,histb-dw-mshc.yaml b/Documentation/devicetree/bindings/mmc/hisilicon,histb-dw-mshc.yaml
> index 301b6ad39c5af..2f8335fd2c965 100644
> --- a/Documentation/devicetree/bindings/mmc/hisilicon,histb-dw-mshc.yaml
> +++ b/Documentation/devicetree/bindings/mmc/hisilicon,histb-dw-mshc.yaml
> @@ -19,6 +19,7 @@ properties:
> compatible:
> enum:
> - hisilicon,hi3798cv200-dw-mshc
> + - hisilicon,hi3798mv200-dw-mshc
>
> reg:
> maxItems: 1
> @@ -27,14 +28,16 @@ properties:
> maxItems: 1
>
> clocks:
> - maxItems: 4
You miss now minItems. Are you sure you tested your bindings? This
should fail.
Anyway, wait with sending new versions of patches to give other people
chance to review. It's already second patchset today.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-04-16 11:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-16 9:19 [PATCH RFC v4 0/4] mmc: add support for the dw-mmc controller on Hi3798MV200 Yang Xiwen via B4 Relay
2023-04-16 9:19 ` [PATCH RFC v4 1/4] mmc: dw_mmc: hi3798cv200: rename to dw_mmc-histb Yang Xiwen via B4 Relay
2023-04-16 9:19 ` [PATCH RFC v4 2/4] mmc: dw_mmc: histb: add support for hi3798mv200 Yang Xiwen via B4 Relay
2023-04-16 9:19 ` [PATCH RFC v4 3/4] dt-binding: mmc: hi3798cv200-dw-mshc: convert to YAML and rename to histb-dw-mshc Yang Xiwen via B4 Relay
2023-04-16 11:17 ` Krzysztof Kozlowski
2023-04-17 17:09 ` Krzysztof Kozlowski
2023-04-17 13:10 ` Rob Herring
2023-04-16 9:19 ` [PATCH RFC v4 4/4] dt-binding: mmc: histb-dw-mshc: Add Hi3798MV200 compatible string Yang Xiwen via B4 Relay
2023-04-16 11:16 ` Krzysztof Kozlowski [this message]
2023-04-16 11:23 ` Yang Xiwen
2023-04-19 13:28 ` [PATCH RFC v4 0/4] mmc: add support for the dw-mmc controller on Hi3798MV200 Yang Xiwen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7cdf170f-1045-db73-df87-fd9da693da28@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=forbidden405@outlook.com \
--cc=jh80.chung@samsung.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mmyangfl@gmail.com \
--cc=robh+dt@kernel.org \
--cc=shawn.guo@linaro.org \
--cc=tianshuliang@hisilicon.com \
--cc=ulf.hansson@linaro.org \
--cc=xuejiancheng@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox