From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-renesas-soc@vger.kernel.org
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] arm64: dts: renesas: white-hawk-cpu: sort RWDT entry correctly
Date: Thu, 3 Nov 2022 17:00:43 -0400 [thread overview]
Message-ID: <7cfe285d-eb82-1840-0149-b5b77f2beaae@linaro.org> (raw)
In-Reply-To: <20221103205546.24836-4-wsa+renesas@sang-engineering.com>
On 03/11/2022 16:55, Wolfram Sang wrote:
You need to describe the bug and its impact to justify Fixes tag (thus
AUTOSEL backporting).
> Fixes: 495e36c3a313 ("arm64: dts: renesas: white-hawk-cpu: Enable watchdog timer")
But I doubt that there is a bug here. Style (like order of things) is
not a bug.
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi b/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi
> index bb4dd08781ca..c10740aee9f6 100644
> --- a/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi
> @@ -271,11 +271,11 @@ user@1200000 {
> };
> };
>
> -&scif_clk {
> - clock-frequency = <24000000>;
> -};
> -
> &rwdt {
> timeout-sec = <60>;
> status = "okay";
> };
> +
> +&scif_clk {
> + clock-frequency = <24000000>;
> +};
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-03 21:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 20:55 [PATCH 0/4] r8a779g0: add TMU support Wolfram Sang
2022-11-03 20:55 ` [PATCH 2/4] arm64: dts: renesas: r8a779g0: Add TMU nodes Wolfram Sang
2022-11-07 16:29 ` Geert Uytterhoeven
2022-11-03 20:55 ` [PATCH 3/4] arm64: dts: renesas: white-hawk-cpu: sort RWDT entry correctly Wolfram Sang
2022-11-03 21:00 ` Krzysztof Kozlowski [this message]
2022-11-04 11:14 ` Wolfram Sang
2022-11-04 12:21 ` Geert Uytterhoeven
2022-11-04 8:57 ` Geert Uytterhoeven
2022-11-03 20:55 ` [PATCH 4/4] TEST: arm64: dts: renesas: white-hawk-cpu: Enable TMU Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7cfe285d-eb82-1840-0149-b5b77f2beaae@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=robh+dt@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).