* [PATCH v3 0/2] Add scmi powerdomain for sky1 @ 2026-03-13 6:03 Gary Yang 2026-03-13 6:03 ` [PATCH v3 1/2] dt-bindings: PCI: cix,sky1-pcie-host: Add power-domains Gary Yang 2026-03-13 6:03 ` [PATCH v3 2/2] arm64: dts: cix: Add scmi powerdomain nodes for sky1 Gary Yang 0 siblings, 2 replies; 6+ messages in thread From: Gary Yang @ 2026-03-13 6:03 UTC (permalink / raw) To: lpieralisi, kwilczynski, mani, robh, bhelgaas, krzk+dt, conor+dt, peter.chen Cc: linux-pci, devicetree, linux-kernel, linux-arm-kernel, cix-kernel-upstream, Gary Yang v3 changes: - Pass dts build check with below commands: make O=$OUTKNL dt_binding_check make O=$OUTKNL dt_binding_check DT_SCHEMA_FILES=cix,sky1-pcie-host.yaml make O=$OUTKNL CHECK_DTBS=y W=1 cix/sky1-orion-o6.dtb scripts/checkpatch.pl 000*.patch - refine dt-bindings v2 changes: - Pass dts build check with below commands: make O=$OUTKNL dt_binding_check make O=$OUTKNL dt_binding_check DT_SCHEMA_FILES=cix,sky1-pcie-host.yaml make O=$OUTKNL CHECK_DTBS=y W=1 cix/sky1-orion-o6.dtb scripts/checkpatch.pl 000*.patch - update dt-bindings Gary Yang (2): dt-bindings: PCI: cix,sky1-pcie-host: Add power-domains arm64: dts: cix: Add scmi powerdomain nodes for sky1 .../bindings/pci/cix,sky1-pcie-host.yaml | 6 ++++ arch/arm64/boot/dts/cix/sky1-power.h | 34 +++++++++++++++++++ arch/arm64/boot/dts/cix/sky1.dtsi | 21 ++++++++++++ 3 files changed, 61 insertions(+) create mode 100644 arch/arm64/boot/dts/cix/sky1-power.h -- 2.49.0 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v3 1/2] dt-bindings: PCI: cix,sky1-pcie-host: Add power-domains 2026-03-13 6:03 [PATCH v3 0/2] Add scmi powerdomain for sky1 Gary Yang @ 2026-03-13 6:03 ` Gary Yang 2026-03-13 8:25 ` Krzysztof Kozlowski 2026-03-13 6:03 ` [PATCH v3 2/2] arm64: dts: cix: Add scmi powerdomain nodes for sky1 Gary Yang 1 sibling, 1 reply; 6+ messages in thread From: Gary Yang @ 2026-03-13 6:03 UTC (permalink / raw) To: lpieralisi, kwilczynski, mani, robh, bhelgaas, krzk+dt, conor+dt, peter.chen Cc: linux-pci, devicetree, linux-kernel, linux-arm-kernel, cix-kernel-upstream, Gary Yang add power-domains and power-domain-names property Signed-off-by: Gary Yang <gary.yang@cixtech.com> --- .../devicetree/bindings/pci/cix,sky1-pcie-host.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/pci/cix,sky1-pcie-host.yaml b/Documentation/devicetree/bindings/pci/cix,sky1-pcie-host.yaml index b910a42e0843..6f194319be52 100644 --- a/Documentation/devicetree/bindings/pci/cix,sky1-pcie-host.yaml +++ b/Documentation/devicetree/bindings/pci/cix,sky1-pcie-host.yaml @@ -38,6 +38,12 @@ properties: ranges: maxItems: 3 + power-domains: + maxItems: 1 + + power-domain-names: + maxItems: 1 + required: - compatible - ranges -- 2.49.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: PCI: cix,sky1-pcie-host: Add power-domains 2026-03-13 6:03 ` [PATCH v3 1/2] dt-bindings: PCI: cix,sky1-pcie-host: Add power-domains Gary Yang @ 2026-03-13 8:25 ` Krzysztof Kozlowski 2026-03-13 8:53 ` 回复: " Gary Yang 0 siblings, 1 reply; 6+ messages in thread From: Krzysztof Kozlowski @ 2026-03-13 8:25 UTC (permalink / raw) To: Gary Yang Cc: lpieralisi, kwilczynski, mani, robh, bhelgaas, krzk+dt, conor+dt, peter.chen, linux-pci, devicetree, linux-kernel, linux-arm-kernel, cix-kernel-upstream On Fri, Mar 13, 2026 at 02:03:07PM +0800, Gary Yang wrote: > add power-domains and power-domain-names property Nothing improved. <form letter> This is a friendly reminder during the review process. It seems my or other reviewer's previous comments were not fully addressed. Maybe the feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. Thank you. </form letter> Best regards, Krzysztof ^ permalink raw reply [flat|nested] 6+ messages in thread
* 回复: [PATCH v3 1/2] dt-bindings: PCI: cix,sky1-pcie-host: Add power-domains 2026-03-13 8:25 ` Krzysztof Kozlowski @ 2026-03-13 8:53 ` Gary Yang 2026-03-13 9:00 ` Krzysztof Kozlowski 0 siblings, 1 reply; 6+ messages in thread From: Gary Yang @ 2026-03-13 8:53 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: lpieralisi@kernel.org, kwilczynski@kernel.org, mani@kernel.org, robh@kernel.org, bhelgaas@google.com, krzk+dt@kernel.org, conor+dt@kernel.org, Peter Chen, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, cix-kernel-upstream Hi Krzysztof: Thanks for your comments > EXTERNAL EMAIL > > On Fri, Mar 13, 2026 at 02:03:07PM +0800, Gary Yang wrote: > > add power-domains and power-domain-names property > > Nothing improved. > > <form letter> > This is a friendly reminder during the review process. > > It seems my or other reviewer's previous comments were not fully addressed. > Maybe the feedback got lost between the quotes, maybe you just forgot to > apply it. Please go back to the previous discussion and either implement all > requested changes or keep discussing them. > > Thank you. > </form letter> > Sorry, we only delete power-domain-names property in dts file. We also delete it in yaml file on V4. Like this, All right? power-domains: maxItems: 1 Best Regards Gary > Best regards, > Krzysztof ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: 回复: [PATCH v3 1/2] dt-bindings: PCI: cix,sky1-pcie-host: Add power-domains 2026-03-13 8:53 ` 回复: " Gary Yang @ 2026-03-13 9:00 ` Krzysztof Kozlowski 0 siblings, 0 replies; 6+ messages in thread From: Krzysztof Kozlowski @ 2026-03-13 9:00 UTC (permalink / raw) To: Gary Yang Cc: lpieralisi@kernel.org, kwilczynski@kernel.org, mani@kernel.org, robh@kernel.org, bhelgaas@google.com, krzk+dt@kernel.org, conor+dt@kernel.org, Peter Chen, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, cix-kernel-upstream On 13/03/2026 09:53, Gary Yang wrote: > Hi Krzysztof: > > Thanks for your comments > >> EXTERNAL EMAIL >> >> On Fri, Mar 13, 2026 at 02:03:07PM +0800, Gary Yang wrote: >>> add power-domains and power-domain-names property >> >> Nothing improved. >> >> <form letter> >> This is a friendly reminder during the review process. >> >> It seems my or other reviewer's previous comments were not fully addressed. >> Maybe the feedback got lost between the quotes, maybe you just forgot to >> apply it. Please go back to the previous discussion and either implement all >> requested changes or keep discussing them. >> >> Thank you. >> </form letter> >> > > Sorry, we only delete power-domain-names property in dts file. > > We also delete it in yaml file on V4. Like this, All right? "Please go back to the previous discussion..." Best regards, Krzysztof ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v3 2/2] arm64: dts: cix: Add scmi powerdomain nodes for sky1 2026-03-13 6:03 [PATCH v3 0/2] Add scmi powerdomain for sky1 Gary Yang 2026-03-13 6:03 ` [PATCH v3 1/2] dt-bindings: PCI: cix,sky1-pcie-host: Add power-domains Gary Yang @ 2026-03-13 6:03 ` Gary Yang 1 sibling, 0 replies; 6+ messages in thread From: Gary Yang @ 2026-03-13 6:03 UTC (permalink / raw) To: lpieralisi, kwilczynski, mani, robh, bhelgaas, krzk+dt, conor+dt, peter.chen Cc: linux-pci, devicetree, linux-kernel, linux-arm-kernel, cix-kernel-upstream, Gary Yang Add a second SCMI channel using SMC transport to communicate with TF-A for power domain management on the Sky1 SoC. Signed-off-by: Gary Yang <gary.yang@cixtech.com> --- arch/arm64/boot/dts/cix/sky1-power.h | 34 ++++++++++++++++++++++++++++ arch/arm64/boot/dts/cix/sky1.dtsi | 21 +++++++++++++++++ 2 files changed, 55 insertions(+) create mode 100644 arch/arm64/boot/dts/cix/sky1-power.h diff --git a/arch/arm64/boot/dts/cix/sky1-power.h b/arch/arm64/boot/dts/cix/sky1-power.h new file mode 100644 index 000000000000..743c0e5558ee --- /dev/null +++ b/arch/arm64/boot/dts/cix/sky1-power.h @@ -0,0 +1,34 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * Copyright 2026 Cix Technology Group Co., Ltd. + */ + +#ifndef __SKY1_POWER_H__ +#define __SKY1_POWER_H__ + +/* The Rich OS need flow the macro */ +#define SKY1_PD_AUDIO 0 +#define SKY1_PD_PCIE_CTRL0 1 +#define SKY1_PD_PCIE_DUMMY 2 +#define SKY1_PD_PCIEHUB 3 +#define SKY1_PD_MMHUB 4 +#define SKY1_PD_MMHUB_SMMU 5 +#define SKY1_PD_DPU0 6 +#define SKY1_PD_DPU1 7 +#define SKY1_PD_DPU2 8 +#define SKY1_PD_DPU3 9 +#define SKY1_PD_DPU4 10 +#define SKY1_PD_VPU_TOP 11 +#define SKY1_PD_VPU_CORE0 12 +#define SKY1_PD_VPU_CORE1 13 +#define SKY1_PD_VPU_CORE2 14 +#define SKY1_PD_VPU_CORE3 15 +#define SKY1_PD_NPU_CORE0 16 +#define SKY1_PD_NPU_CORE1 17 +#define SKY1_PD_NPU_CORE2 18 +#define SKY1_PD_NPU_TOP 19 +#define SKY1_PD_ISP0 20 +#define SKY1_PD_GPU 21 +#define SKY1_PD_MAX 22 + +#endif diff --git a/arch/arm64/boot/dts/cix/sky1.dtsi b/arch/arm64/boot/dts/cix/sky1.dtsi index 64b76905cbff..495ea91a63f5 100644 --- a/arch/arm64/boot/dts/cix/sky1.dtsi +++ b/arch/arm64/boot/dts/cix/sky1.dtsi @@ -6,6 +6,7 @@ #include <dt-bindings/interrupt-controller/arm-gic.h> #include <dt-bindings/clock/cix,sky1.h> +#include "sky1-power.h" / { interrupt-parent = <&gic>; @@ -168,6 +169,19 @@ scmi_clk: protocol@14 { #clock-cells = <1>; }; }; + + ap_to_tfa_scmi: scmi-1 { + compatible = "arm,scmi-smc"; + arm,smc-id = <0xc2000001>; + #address-cells = <1>; + #size-cells = <0>; + shmem = <&ap_tfa_scmi_mem>; + + smc_devpd: protocol@11 { + reg = <0x11>; + #power-domain-cells = <1>; + }; + }; }; pmu-a520 { @@ -428,6 +442,7 @@ pcie_x8_rc: pcie@a010000 { #size-cells = <2>; bus-range = <0xc0 0xff>; device_type = "pci"; + power-domains = <&smc_devpd SKY1_PD_PCIE_CTRL0>; #interrupt-cells = <1>; interrupt-map-mask = <0 0 0 0x7>; interrupt-map = <0 0 0 1 &gic 0 0 GIC_SPI 407 IRQ_TYPE_LEVEL_HIGH 0>, @@ -572,6 +587,12 @@ iomuxc_s5: pinctrl@16007000 { compatible = "cix,sky1-pinctrl-s5"; reg = <0x0 0x16007000 0x0 0x1000>; }; + + ap_tfa_scmi_mem: shmem@84380000 { + compatible = "arm,scmi-shmem"; + reg = <0x0 0x84380000 0x0 0x80>; + reg-io-width = <4>; + }; }; timer { -- 2.49.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-03-13 9:01 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-03-13 6:03 [PATCH v3 0/2] Add scmi powerdomain for sky1 Gary Yang 2026-03-13 6:03 ` [PATCH v3 1/2] dt-bindings: PCI: cix,sky1-pcie-host: Add power-domains Gary Yang 2026-03-13 8:25 ` Krzysztof Kozlowski 2026-03-13 8:53 ` 回复: " Gary Yang 2026-03-13 9:00 ` Krzysztof Kozlowski 2026-03-13 6:03 ` [PATCH v3 2/2] arm64: dts: cix: Add scmi powerdomain nodes for sky1 Gary Yang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox