* [PATCH 0/2] dt-bindings: net: wireless: add wifi node for IPQ5332
@ 2025-01-28 9:10 Raj Kumar Bhagat
2025-01-28 9:10 ` [PATCH 1/2] dt-bindings: net: wireless: describe the ath12k AHB module Raj Kumar Bhagat
2025-01-28 9:10 ` [PATCH 2/2] arm64: dts: qcom: add wifi node for IPQ5332 based RDP441 Raj Kumar Bhagat
0 siblings, 2 replies; 13+ messages in thread
From: Raj Kumar Bhagat @ 2025-01-28 9:10 UTC (permalink / raw)
To: ath12k
Cc: linux-wireless, Kalle Valo, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Jeff Johnson, Bjorn Andersson, Konrad Dybcio,
devicetree, linux-kernel, linux-arm-msm, Raj Kumar Bhagat
The IPQ5332 has IEEE802.11be 2 GHz 2x2 AHB bus WiFi device. This patch
series:
- Describe IPQ5332 WiFi device for device-tree binding.
- Add IPQ5332 wifi node and required reserved-memory in RDP441.
Depends-On: [PATCH V2 0/2] mailbox: tmel-qmp: Introduce QCOM TMEL QMP mailbox driver
Depends-On: [PATCH V3 0/8] Add new driver for WCSS secure PIL loading
Link: https://lore.kernel.org/lkml/20241231054900.2144961-1-quic_srichara@quicinc.com/
Link: https://lore.kernel.org/lkml/20250107101647.2087358-1-quic_gokulsri@quicinc.com/
NOTE:
The Depends-On series '[PATCH V3 0/8] Add new driver for WCSS secure PIL
loading' do not apply completely on ath/main ToT. One of the patch
(https://lore.kernel.org/lkml/20250107101647.2087358-9-quic_gokulsri@quicinc.com/)
fails to apply. This patch does changes in the file -
arch/arm64/boot/dts/qcom/ipq5424.dtsi, which is in linux-next but not in
ath/main as of now. Hence, skip this particular patch while applying
depenency on ath/main for review.
Raj Kumar Bhagat (2):
dt-bindings: net: wireless: describe the ath12k AHB module
arm64: dts: qcom: add wifi node for IPQ5332 based RDP441
.../net/wireless/qcom,ath12k-ahb.yaml | 317 ++++++++++++++++++
arch/arm64/boot/dts/qcom/ipq5332-rdp441.dts | 56 +++-
arch/arm64/boot/dts/qcom/ipq5332.dtsi | 106 ++++++
3 files changed, 478 insertions(+), 1 deletion(-)
create mode 100644 Documentation/devicetree/bindings/net/wireless/qcom,ath12k-ahb.yaml
base-commit: b5aeca2e66899430827b8afcad061201f3b7861b
prerequisite-patch-id: d59a64ae7cc13f19fc6f27f8906c98ff5f97f3b2
prerequisite-patch-id: 6c4774dac182e3cc7fa830c06936e34b2c3f4e21
prerequisite-patch-id: 2ae372ac47365309e9d6a123dc9db69bd0f81cd7
prerequisite-patch-id: 4feb9dd9bfff074118dc0ee327b53a45ddb535bb
prerequisite-patch-id: efdd81a1f3309e3383ed996f3b1ebef8d2680705
prerequisite-patch-id: 2fb2bcb350efe9cb0f85aefa1849fccb5e13ebd7
prerequisite-patch-id: aea510292c2387e214523d6aaff52298f783e342
prerequisite-patch-id: 6ca17cf991617a9c5664b812007547e914f44562
prerequisite-patch-id: 74dc586eab1f42e73d53730084bc38be4677b816
--
2.34.1
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 1/2] dt-bindings: net: wireless: describe the ath12k AHB module
2025-01-28 9:10 [PATCH 0/2] dt-bindings: net: wireless: add wifi node for IPQ5332 Raj Kumar Bhagat
@ 2025-01-28 9:10 ` Raj Kumar Bhagat
2025-01-28 9:17 ` Krzysztof Kozlowski
2025-01-28 9:10 ` [PATCH 2/2] arm64: dts: qcom: add wifi node for IPQ5332 based RDP441 Raj Kumar Bhagat
1 sibling, 1 reply; 13+ messages in thread
From: Raj Kumar Bhagat @ 2025-01-28 9:10 UTC (permalink / raw)
To: ath12k
Cc: linux-wireless, Kalle Valo, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Jeff Johnson, Bjorn Andersson, Konrad Dybcio,
devicetree, linux-kernel, linux-arm-msm, Raj Kumar Bhagat
Add device-tree bindings for the ATH12K module found in the IPQ5332
device.
Signed-off-by: Raj Kumar Bhagat <quic_rajkbhag@quicinc.com>
---
.../net/wireless/qcom,ath12k-ahb.yaml | 317 ++++++++++++++++++
1 file changed, 317 insertions(+)
create mode 100644 Documentation/devicetree/bindings/net/wireless/qcom,ath12k-ahb.yaml
diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath12k-ahb.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath12k-ahb.yaml
new file mode 100644
index 000000000000..52c421f7f1c7
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath12k-ahb.yaml
@@ -0,0 +1,317 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+# Copyright (c) 2024-2025 Qualcomm Innovation Center, Inc. All rights reserved.
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/wireless/qcom,ath12k-ahb.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm Technologies ath12k wireless devices (AHB)
+
+maintainers:
+ - Kalle Valo <kvalo@kernel.org>
+ - Jeff Johnson <jjohnson@kernel.org>
+
+description:
+ Qualcomm Technologies IEEE 802.11be AHB devices.
+
+properties:
+ compatible:
+ enum:
+ - qcom,ipq5332-wifi
+
+ reg:
+ maxItems: 1
+
+ clocks:
+ items:
+ - description: XO clock used for copy engine
+
+ clock-names:
+ items:
+ - const: xo
+
+ interrupts:
+ items:
+ - description: Ready interrupt
+ - description: Spawn acknowledge interrupt
+ - description: Stop acknowledge interrupt
+ - description: misc-pulse1 interrupt events
+ - description: misc-latch interrupt events
+ - description: sw exception interrupt events
+ - description: interrupt event for ring CE0
+ - description: interrupt event for ring CE1
+ - description: interrupt event for ring CE2
+ - description: interrupt event for ring CE3
+ - description: interrupt event for ring CE4
+ - description: interrupt event for ring CE5
+ - description: interrupt event for ring CE6
+ - description: interrupt event for ring CE7
+ - description: interrupt event for ring CE8
+ - description: interrupt event for ring CE9
+ - description: interrupt event for ring CE10
+ - description: interrupt event for ring CE11
+ - description: interrupt event for ring host2wbm-desc-feed
+ - description: interrupt event for ring host2reo-re-injection
+ - description: interrupt event for ring host2reo-command
+ - description: interrupt event for ring host2rxdma-monitor-ring1
+ - description: interrupt event for ring reo2ost-exception
+ - description: interrupt event for ring wbm2host-rx-release
+ - description: interrupt event for ring reo2host-status
+ - description: interrupt event for ring reo2host-destination-ring4
+ - description: interrupt event for ring reo2host-destination-ring3
+ - description: interrupt event for ring reo2host-destination-ring2
+ - description: interrupt event for ring reo2host-destination-ring1
+ - description: interrupt event for ring rxdma2host-monitor-destination-mac3
+ - description: interrupt event for ring rxdma2host-monitor-destination-mac2
+ - description: interrupt event for ring rxdma2host-monitor-destination-mac1
+ - description: interrupt event for ring host2rxdma-host-buf-ring-mac3
+ - description: interrupt event for ring host2rxdma-host-buf-ring-mac2
+ - description: interrupt event for ring host2rxdma-host-buf-ring-mac1
+ - description: interrupt event for ring host2tcl-input-ring4
+ - description: interrupt event for ring host2tcl-input-ring3
+ - description: interrupt event for ring host2tcl-input-ring2
+ - description: interrupt event for ring host2tcl-input-ring1
+ - description: interrupt event for ring wbm2host-tx-completions-ring4
+ - description: interrupt event for ring wbm2host-tx-completions-ring3
+ - description: interrupt event for ring wbm2host-tx-completions-ring2
+ - description: interrupt event for ring wbm2host-tx-completions-ring1
+ - description: interrupt event for ring host2tx-monitor-ring1
+ - description: interrupt event for ring txmon2host-monitor-destination-mac3
+ - description: interrupt event for ring txmon2host-monitor-destination-mac2
+ - description: interrupt event for ring txmon2host-monitor-destination-mac1
+ - description: interrupt event for umac-reset
+
+ interrupt-names:
+ items:
+ - const: ready
+ - const: spawn
+ - const: stop-ack
+ - const: misc-pulse1
+ - const: misc-latch
+ - const: sw-exception
+ - const: ce0
+ - const: ce1
+ - const: ce2
+ - const: ce3
+ - const: ce4
+ - const: ce5
+ - const: ce6
+ - const: ce7
+ - const: ce8
+ - const: ce9
+ - const: ce10
+ - const: ce11
+ - const: host2wbm-desc-feed
+ - const: host2reo-re-injection
+ - const: host2reo-command
+ - const: host2rxdma-monitor-ring1
+ - const: reo2ost-exception
+ - const: wbm2host-rx-release
+ - const: reo2host-status
+ - const: reo2host-destination-ring4
+ - const: reo2host-destination-ring3
+ - const: reo2host-destination-ring2
+ - const: reo2host-destination-ring1
+ - const: rxdma2host-monitor-destination-mac3
+ - const: rxdma2host-monitor-destination-mac2
+ - const: rxdma2host-monitor-destination-mac1
+ - const: host2rxdma-host-buf-ring-mac3
+ - const: host2rxdma-host-buf-ring-mac2
+ - const: host2rxdma-host-buf-ring-mac1
+ - const: host2tcl-input-ring4
+ - const: host2tcl-input-ring3
+ - const: host2tcl-input-ring2
+ - const: host2tcl-input-ring1
+ - const: wbm2host-tx-completions-ring4
+ - const: wbm2host-tx-completions-ring3
+ - const: wbm2host-tx-completions-ring2
+ - const: wbm2host-tx-completions-ring1
+ - const: host2tx-monitor-ring1
+ - const: txmon2host-monitor-destination-mac3
+ - const: txmon2host-monitor-destination-mac2
+ - const: txmon2host-monitor-destination-mac1
+ - const: umac-reset
+
+ memory-region:
+ minItems: 2
+ description:
+ phandle to a node describing reserved memory (System RAM memory)
+ used by ath12k firmware (see bindings/reserved-memory/reserved-memory.txt)
+ items:
+ - description: Q6 memory region
+ - description: m3 dump memory region
+ - description: Q6 caldata memory region
+ - description: Multi Link Operation (MLO) Global memory region
+
+ memory-region-names:
+ minItems: 2
+ description:
+ Name of the reserved memory region used by ath12k firmware
+ items:
+ - const: q6-region
+ - const: m3-dump
+ - const: q6-caldb
+ - const: mlo-global-mem
+
+ qcom,ath12k-calibration-variant:
+ $ref: /schemas/types.yaml#/definitions/string
+ description:
+ String to uniquely identify variant of the calibration data for designs
+ with colliding bus and device ids
+
+ qcom,rproc:
+ $ref: /schemas/types.yaml#/definitions/phandle
+ description:
+ Phandle to the Qualcomm Hexagon DSP(q6 remote processor), which is utilized
+ for offloading WiFi processing tasks, this q6 remote processor operates in
+ conjunction with WiFi.
+
+ qcom,smem-states:
+ $ref: /schemas/types.yaml#/definitions/phandle-array
+ description: States used by the AP to signal the remote processor
+ items:
+ - description: Shutdown WCSS pd
+ - description: Stop WCSS pd
+ - description: Spawn WCSS pd
+
+ qcom,smem-state-names:
+ description:
+ Names of the states used by the AP to signal the remote processor
+ items:
+ - const: shutdown
+ - const: stop
+ - const: spawn
+
+required:
+ - compatible
+ - reg
+ - clocks
+ - clock-names
+ - interrupts
+ - interrupt-names
+ - memory-region
+ - memory-region-names
+ - qcom,rproc
+ - qcom,smem-states
+ - qcom,smem-state-names
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/clock/qcom,ipq5332-gcc.h>
+
+ wifi0: wifi@c000000 {
+ compatible = "qcom,ipq5332-wifi";
+ reg = <0x0c000000 0x1000000>;
+ clocks = <&gcc GCC_XO_CLK>;
+ clock-names = "xo";
+ interrupts-extended = <&wcss_smp2p_in 9 IRQ_TYPE_NONE>,
+ <&wcss_smp2p_in 12 IRQ_TYPE_NONE>,
+ <&wcss_smp2p_in 11 IRQ_TYPE_NONE>,
+ <&intc GIC_SPI 559 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 560 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 561 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 422 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 423 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 424 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 425 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 426 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 427 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 428 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 429 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 430 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 431 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 432 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 433 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 491 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 495 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 493 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 544 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 457 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 466 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 497 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 454 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 453 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 452 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 451 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 488 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 488 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 484 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 554 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 554 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 549 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 507 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 500 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 499 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 498 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 450 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 449 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 448 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 447 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 543 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 486 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 486 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 482 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 419 IRQ_TYPE_EDGE_RISING>;
+ interrupt-names = "ready",
+ "spawn",
+ "stop-ack",
+ "misc-pulse1",
+ "misc-latch",
+ "sw-exception",
+ "ce0",
+ "ce1",
+ "ce2",
+ "ce3",
+ "ce4",
+ "ce5",
+ "ce6",
+ "ce7",
+ "ce8",
+ "ce9",
+ "ce10",
+ "ce11",
+ "host2wbm-desc-feed",
+ "host2reo-re-injection",
+ "host2reo-command",
+ "host2rxdma-monitor-ring1",
+ "reo2ost-exception",
+ "wbm2host-rx-release",
+ "reo2host-status",
+ "reo2host-destination-ring4",
+ "reo2host-destination-ring3",
+ "reo2host-destination-ring2",
+ "reo2host-destination-ring1",
+ "rxdma2host-monitor-destination-mac3",
+ "rxdma2host-monitor-destination-mac2",
+ "rxdma2host-monitor-destination-mac1",
+ "host2rxdma-host-buf-ring-mac3",
+ "host2rxdma-host-buf-ring-mac2",
+ "host2rxdma-host-buf-ring-mac1",
+ "host2tcl-input-ring4",
+ "host2tcl-input-ring3",
+ "host2tcl-input-ring2",
+ "host2tcl-input-ring1",
+ "wbm2host-tx-completions-ring4",
+ "wbm2host-tx-completions-ring3",
+ "wbm2host-tx-completions-ring2",
+ "wbm2host-tx-completions-ring1",
+ "host2tx-monitor-ring1",
+ "txmon2host-monitor-destination-mac3",
+ "txmon2host-monitor-destination-mac2",
+ "txmon2host-monitor-destination-mac1",
+ "umac-reset";
+
+ memory-region = <&q6_region>, <&m3_dump>;
+ memory-region-names = "q6-region", "m3-dump";
+ qcom,ath12k-calibration-variant = "RDP441_1";
+ qcom,rproc = <&q6v5_wcss>;
+ qcom,smem-states = <&wcss_smp2p_out 8>,
+ <&wcss_smp2p_out 9>,
+ <&wcss_smp2p_out 10>;
+ qcom,smem-state-names = "shutdown",
+ "stop",
+ "spawn";
+ };
--
2.34.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 2/2] arm64: dts: qcom: add wifi node for IPQ5332 based RDP441
2025-01-28 9:10 [PATCH 0/2] dt-bindings: net: wireless: add wifi node for IPQ5332 Raj Kumar Bhagat
2025-01-28 9:10 ` [PATCH 1/2] dt-bindings: net: wireless: describe the ath12k AHB module Raj Kumar Bhagat
@ 2025-01-28 9:10 ` Raj Kumar Bhagat
2025-01-28 9:22 ` Krzysztof Kozlowski
1 sibling, 1 reply; 13+ messages in thread
From: Raj Kumar Bhagat @ 2025-01-28 9:10 UTC (permalink / raw)
To: ath12k
Cc: linux-wireless, Kalle Valo, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Jeff Johnson, Bjorn Andersson, Konrad Dybcio,
devicetree, linux-kernel, linux-arm-msm, Raj Kumar Bhagat
RDP441 is based on IPQ5332. It has inbuilt AHB bus based IPQ5332 WiFi
device.
Describe and add WiFi node for RDP441. Also, reserve the memory
required by IPQ5332 firmware.
Signed-off-by: Raj Kumar Bhagat <quic_rajkbhag@quicinc.com>
---
arch/arm64/boot/dts/qcom/ipq5332-rdp441.dts | 56 ++++++++++-
arch/arm64/boot/dts/qcom/ipq5332.dtsi | 106 ++++++++++++++++++++
2 files changed, 161 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/ipq5332-rdp441.dts b/arch/arm64/boot/dts/qcom/ipq5332-rdp441.dts
index 846413817e9a..07019e224492 100644
--- a/arch/arm64/boot/dts/qcom/ipq5332-rdp441.dts
+++ b/arch/arm64/boot/dts/qcom/ipq5332-rdp441.dts
@@ -2,7 +2,7 @@
/*
* IPQ5332 AP-MI01.2 board device tree source
*
- * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2022-2025 Qualcomm Innovation Center, Inc. All rights reserved.
*/
/dts-v1/;
@@ -12,6 +12,47 @@
/ {
model = "Qualcomm Technologies, Inc. IPQ5332 MI01.2";
compatible = "qcom,ipq5332-ap-mi01.2", "qcom,ipq5332";
+
+ /* Default Profile
+ * +============+==============+=====================+
+ * | | | |
+ * | Region | Start Offset | Size |
+ * | | | |
+ * +------------+--------------+---------------------+
+ * | | | |
+ * | | | |
+ * | | | |
+ * | WLAN Q6 | 0x4A900000 | 43MB |
+ * | | | |
+ * | | | |
+ * +------------+--------------+---------------------+
+ * | M3 Dump | 0x4D400000 | 1MB |
+ * +============+==============+=====================+
+ * | |
+ * | |
+ * | |
+ * | Rest of memory for Linux |
+ * | |
+ * | |
+ * | |
+ * +=================================================+
+ */
+
+ reserved-memory {
+ #address-cells = <2>;
+ #size-cells = <2>;
+ ranges;
+
+ q6_region: wcss@4a900000 {
+ reg = <0x0 0x4a900000 0x0 0x02b00000>;
+ no-map;
+ };
+
+ m3_dump: m3-dump@4d400000 {
+ reg = <0x0 0x4D400000 0x0 0x100000>;
+ no-map;
+ };
+ };
};
&blsp1_i2c1 {
@@ -63,3 +104,16 @@ data-pins {
};
};
};
+
+&wifi0 {
+ memory-region = <&q6_region>, <&m3_dump>;
+ memory-region-names = "q6-region", "m3-dump";
+ qcom,rproc = <&q6v5_wcss>;
+ qcom,smem-states = <&wcss_smp2p_out 8>,
+ <&wcss_smp2p_out 9>,
+ <&wcss_smp2p_out 10>;
+ qcom,smem-state-names = "shutdown",
+ "stop",
+ "spawn";
+ status = "okay";
+};
diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
index 85e10b20342a..a27a679d4348 100644
--- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
@@ -485,6 +485,112 @@ frame@b128000 {
};
};
+ wifi0: wifi@c000000 {
+ compatible = "qcom,ipq5332-wifi";
+ reg = <0x0c000000 0x1000000>;
+ clocks = <&gcc GCC_XO_CLK>;
+ clock-names = "xo";
+ interrupts-extended = <&wcss_smp2p_in 9 IRQ_TYPE_NONE>,
+ <&wcss_smp2p_in 12 IRQ_TYPE_NONE>,
+ <&wcss_smp2p_in 11 IRQ_TYPE_NONE>,
+ <&intc GIC_SPI 559 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 560 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 561 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 422 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 423 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 424 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 425 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 426 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 427 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 428 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 429 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 430 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 431 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 432 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 433 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 491 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 495 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 493 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 544 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 457 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 466 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 497 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 454 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 453 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 452 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 451 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 488 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 488 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 484 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 554 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 554 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 549 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 507 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 500 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 499 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 498 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 450 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 449 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 448 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 447 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 543 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 486 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 486 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 482 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 419 IRQ_TYPE_EDGE_RISING>;
+
+ interrupt-names = "ready",
+ "spawn",
+ "stop-ack",
+ "misc-pulse1",
+ "misc-latch",
+ "sw-exception",
+ "ce0",
+ "ce1",
+ "ce2",
+ "ce3",
+ "ce4",
+ "ce5",
+ "ce6",
+ "ce7",
+ "ce8",
+ "ce9",
+ "ce10",
+ "ce11",
+ "host2wbm-desc-feed",
+ "host2reo-re-injection",
+ "host2reo-command",
+ "host2rxdma-monitor-ring1",
+ "reo2ost-exception",
+ "wbm2host-rx-release",
+ "reo2host-status",
+ "reo2host-destination-ring4",
+ "reo2host-destination-ring3",
+ "reo2host-destination-ring2",
+ "reo2host-destination-ring1",
+ "rxdma2host-monitor-destination-mac3",
+ "rxdma2host-monitor-destination-mac2",
+ "rxdma2host-monitor-destination-mac1",
+ "host2rxdma-host-buf-ring-mac3",
+ "host2rxdma-host-buf-ring-mac2",
+ "host2rxdma-host-buf-ring-mac1",
+ "host2tcl-input-ring4",
+ "host2tcl-input-ring3",
+ "host2tcl-input-ring2",
+ "host2tcl-input-ring1",
+ "wbm2host-tx-completions-ring4",
+ "wbm2host-tx-completions-ring3",
+ "wbm2host-tx-completions-ring2",
+ "wbm2host-tx-completions-ring1",
+ "host2tx-monitor-ring1",
+ "txmon2host-monitor-destination-mac3",
+ "txmon2host-monitor-destination-mac2",
+ "txmon2host-monitor-destination-mac1",
+ "umac-reset";
+
+ status = "disabled";
+ };
+
q6v5_wcss: remoteproc@d100000 {
compatible = "qcom,ipq5332-wcss-sec-pil";
reg = <0xd100000 0x4040>;
--
2.34.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH 1/2] dt-bindings: net: wireless: describe the ath12k AHB module
2025-01-28 9:10 ` [PATCH 1/2] dt-bindings: net: wireless: describe the ath12k AHB module Raj Kumar Bhagat
@ 2025-01-28 9:17 ` Krzysztof Kozlowski
2025-01-28 9:29 ` Raj Kumar Bhagat
0 siblings, 1 reply; 13+ messages in thread
From: Krzysztof Kozlowski @ 2025-01-28 9:17 UTC (permalink / raw)
To: Raj Kumar Bhagat, ath12k
Cc: linux-wireless, Kalle Valo, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Jeff Johnson, Bjorn Andersson, Konrad Dybcio,
devicetree, linux-kernel, linux-arm-msm
On 28/01/2025 10:10, Raj Kumar Bhagat wrote:
> Add device-tree bindings for the ATH12K module found in the IPQ5332
> device.
>
> Signed-off-by: Raj Kumar Bhagat <quic_rajkbhag@quicinc.com>
> ---
> .../net/wireless/qcom,ath12k-ahb.yaml | 317 ++++++++++++++++++
> 1 file changed, 317 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/wireless/qcom,ath12k-ahb.yaml
It was v4, now v1? So entire previous discussion and feedback is
missing? Go to previous series and implement entire feedback. Then use
proper versioning, proper changelog and make it obvious/understandable
to us, instead of sending v1 after v4 in entirely separate thread.
I also do not understand why this is sent to arm soc. That's wireless patch.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 2/2] arm64: dts: qcom: add wifi node for IPQ5332 based RDP441
2025-01-28 9:10 ` [PATCH 2/2] arm64: dts: qcom: add wifi node for IPQ5332 based RDP441 Raj Kumar Bhagat
@ 2025-01-28 9:22 ` Krzysztof Kozlowski
2025-01-28 9:41 ` Raj Kumar Bhagat
0 siblings, 1 reply; 13+ messages in thread
From: Krzysztof Kozlowski @ 2025-01-28 9:22 UTC (permalink / raw)
To: Raj Kumar Bhagat, ath12k
Cc: linux-wireless, Kalle Valo, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Jeff Johnson, Bjorn Andersson, Konrad Dybcio,
devicetree, linux-kernel, linux-arm-msm
On 28/01/2025 10:10, Raj Kumar Bhagat wrote:
> + /* Default Profile
> + * +============+==============+=====================+
> + * | | | |
> + * | Region | Start Offset | Size |
> + * | | | |
> + * +------------+--------------+---------------------+
> + * | | | |
> + * | | | |
> + * | | | |
> + * | WLAN Q6 | 0x4A900000 | 43MB |
> + * | | | |
> + * | | | |
> + * +------------+--------------+---------------------+
> + * | M3 Dump | 0x4D400000 | 1MB |
> + * +============+==============+=====================+
> + * | |
> + * | |
> + * | |
> + * | Rest of memory for Linux |
> + * | |
> + * | |
> + * | |
> + * +=================================================+
> + */
> +
> + reserved-memory {
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
> +
> + q6_region: wcss@4a900000 {
> + reg = <0x0 0x4a900000 0x0 0x02b00000>;
> + no-map;
> + };
> +
> + m3_dump: m3-dump@4d400000 {
This fails with your wireless patchset.
> + reg = <0x0 0x4D400000 0x0 0x100000>;
> + no-map;
> + };
> + };
> };
>
> &blsp1_i2c1 {
> @@ -63,3 +104,16 @@ data-pins {
> };
> };
> };
> +
> +&wifi0 {
> + memory-region = <&q6_region>, <&m3_dump>;
> + memory-region-names = "q6-region", "m3-dump";
Binding said you have four items. I don't understand why this varies and
why this is 2 items instead.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/2] dt-bindings: net: wireless: describe the ath12k AHB module
2025-01-28 9:17 ` Krzysztof Kozlowski
@ 2025-01-28 9:29 ` Raj Kumar Bhagat
2025-01-28 10:21 ` Krzysztof Kozlowski
0 siblings, 1 reply; 13+ messages in thread
From: Raj Kumar Bhagat @ 2025-01-28 9:29 UTC (permalink / raw)
To: Krzysztof Kozlowski, ath12k
Cc: linux-wireless, Kalle Valo, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Jeff Johnson, Bjorn Andersson, Konrad Dybcio,
devicetree, linux-kernel, linux-arm-msm
On 1/28/2025 2:47 PM, Krzysztof Kozlowski wrote:
> On 28/01/2025 10:10, Raj Kumar Bhagat wrote:
>> Add device-tree bindings for the ATH12K module found in the IPQ5332
>> device.
>>
>> Signed-off-by: Raj Kumar Bhagat <quic_rajkbhag@quicinc.com>
>> ---
>> .../net/wireless/qcom,ath12k-ahb.yaml | 317 ++++++++++++++++++
>> 1 file changed, 317 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/net/wireless/qcom,ath12k-ahb.yaml
>
> It was v4, now v1? So entire previous discussion and feedback is
> missing? Go to previous series and implement entire feedback. Then use
> proper versioning, proper changelog and make it obvious/understandable
> to us, instead of sending v1 after v4 in entirely separate thread.
>
I was asked to send DTS as a separate series, this is a new series for
DTS hence stated with v1.
To address the undocumented ABIs we have changes in dt-binding and hence
corresponding changes in driver as well. Let me know If we could send the
complete series as v5.
> I also do not understand why this is sent to arm soc. That's wireless patch.
>
All the email list are as per - './scripts/get_maintainer.pl'
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 2/2] arm64: dts: qcom: add wifi node for IPQ5332 based RDP441
2025-01-28 9:22 ` Krzysztof Kozlowski
@ 2025-01-28 9:41 ` Raj Kumar Bhagat
2025-01-28 10:24 ` Krzysztof Kozlowski
2025-01-28 11:32 ` Konrad Dybcio
0 siblings, 2 replies; 13+ messages in thread
From: Raj Kumar Bhagat @ 2025-01-28 9:41 UTC (permalink / raw)
To: Krzysztof Kozlowski, ath12k
Cc: linux-wireless, Kalle Valo, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Jeff Johnson, Bjorn Andersson, Konrad Dybcio,
devicetree, linux-kernel, linux-arm-msm
On 1/28/2025 2:52 PM, Krzysztof Kozlowski wrote:
> On 28/01/2025 10:10, Raj Kumar Bhagat wrote:
>> + /* Default Profile
>> + * +============+==============+=====================+
>> + * | | | |
>> + * | Region | Start Offset | Size |
>> + * | | | |
>> + * +------------+--------------+---------------------+
>> + * | | | |
>> + * | | | |
>> + * | | | |
>> + * | WLAN Q6 | 0x4A900000 | 43MB |
>> + * | | | |
>> + * | | | |
>> + * +------------+--------------+---------------------+
>> + * | M3 Dump | 0x4D400000 | 1MB |
>> + * +============+==============+=====================+
>> + * | |
>> + * | |
>> + * | |
>> + * | Rest of memory for Linux |
>> + * | |
>> + * | |
>> + * | |
>> + * +=================================================+
>> + */
>> +
>> + reserved-memory {
>> + #address-cells = <2>;
>> + #size-cells = <2>;
>> + ranges;
>> +
>> + q6_region: wcss@4a900000 {
>> + reg = <0x0 0x4a900000 0x0 0x02b00000>;
>> + no-map;
>> + };
>> +
>> + m3_dump: m3-dump@4d400000 {
>
> This fails with your wireless patchset.
>
Yes, this will fail with v4 wireless patch.
We have v5 (yet to be sent) to read the correct reserved memory. Since,
in v4 I was asked to address and send DTS patch separately, The corresponding
driver patches are yet to be sent.
>> + reg = <0x0 0x4D400000 0x0 0x100000>;
>> + no-map;
>> + };
>> + };
>> };
>>
>> &blsp1_i2c1 {
>> @@ -63,3 +104,16 @@ data-pins {
>> };
>> };
>> };
>> +
>> +&wifi0 {
>> + memory-region = <&q6_region>, <&m3_dump>;
>> + memory-region-names = "q6-region", "m3-dump";
>
> Binding said you have four items. I don't understand why this varies and
> why this is 2 items instead.
>
In total we have 4 items, with minItems as 2.
The other 2 items (q6-caldb & mlo-global-mem) functionalities are not yet enabled
in ath12k driver. Hence these memory are not reserved yet.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/2] dt-bindings: net: wireless: describe the ath12k AHB module
2025-01-28 9:29 ` Raj Kumar Bhagat
@ 2025-01-28 10:21 ` Krzysztof Kozlowski
2025-01-28 17:34 ` Raj Kumar Bhagat
0 siblings, 1 reply; 13+ messages in thread
From: Krzysztof Kozlowski @ 2025-01-28 10:21 UTC (permalink / raw)
To: Raj Kumar Bhagat, ath12k
Cc: linux-wireless, Kalle Valo, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Jeff Johnson, Bjorn Andersson, Konrad Dybcio,
devicetree, linux-kernel, linux-arm-msm
On 28/01/2025 10:29, Raj Kumar Bhagat wrote:
> On 1/28/2025 2:47 PM, Krzysztof Kozlowski wrote:
>> On 28/01/2025 10:10, Raj Kumar Bhagat wrote:
>>> Add device-tree bindings for the ATH12K module found in the IPQ5332
>>> device.
>>>
>>> Signed-off-by: Raj Kumar Bhagat <quic_rajkbhag@quicinc.com>
>>> ---
>>> .../net/wireless/qcom,ath12k-ahb.yaml | 317 ++++++++++++++++++
>>> 1 file changed, 317 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/net/wireless/qcom,ath12k-ahb.yaml
>>
>> It was v4, now v1? So entire previous discussion and feedback is
>> missing? Go to previous series and implement entire feedback. Then use
>> proper versioning, proper changelog and make it obvious/understandable
>> to us, instead of sending v1 after v4 in entirely separate thread.
>>
>
> I was asked to send DTS as a separate series, this is a new series for
> DTS hence stated with v1.
But we do not talk about DTS here, but bindings.
> To address the undocumented ABIs we have changes in dt-binding and hence
That's v1 so how it could have changes in the first place? Unless this
is v5?
> corresponding changes in driver as well. Let me know If we could send the
> complete series as v5.
>
>> I also do not understand why this is sent to arm soc. That's wireless patch.
>>
>
> All the email list are as per - './scripts/get_maintainer.pl'
I am asking why this patch is part of the arm soc patchset. This is
networking/wireless patch.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 2/2] arm64: dts: qcom: add wifi node for IPQ5332 based RDP441
2025-01-28 9:41 ` Raj Kumar Bhagat
@ 2025-01-28 10:24 ` Krzysztof Kozlowski
2025-01-28 16:46 ` Raj Kumar Bhagat
2025-01-28 11:32 ` Konrad Dybcio
1 sibling, 1 reply; 13+ messages in thread
From: Krzysztof Kozlowski @ 2025-01-28 10:24 UTC (permalink / raw)
To: Raj Kumar Bhagat, ath12k
Cc: linux-wireless, Kalle Valo, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Jeff Johnson, Bjorn Andersson, Konrad Dybcio,
devicetree, linux-kernel, linux-arm-msm
On 28/01/2025 10:41, Raj Kumar Bhagat wrote:
>>> +
>>> + reserved-memory {
>>> + #address-cells = <2>;
>>> + #size-cells = <2>;
>>> + ranges;
>>> +
>>> + q6_region: wcss@4a900000 {
>>> + reg = <0x0 0x4a900000 0x0 0x02b00000>;
>>> + no-map;
>>> + };
>>> +
>>> + m3_dump: m3-dump@4d400000 {
>>
>> This fails with your wireless patchset.
>>
>
> Yes, this will fail with v4 wireless patch.
> We have v5 (yet to be sent) to read the correct reserved memory. Since,
> in v4 I was asked to address and send DTS patch separately, The corresponding
> driver patches are yet to be sent.
So you send it to prove my point? OK, fine. So this patch confirms your
driver changes should be rejected.
>
>>> + reg = <0x0 0x4D400000 0x0 0x100000>;
>>> + no-map;
>>> + };
>>> + };
>>> };
>>>
>>> &blsp1_i2c1 {
>>> @@ -63,3 +104,16 @@ data-pins {
>>> };
>>> };
>>> };
>>> +
>>> +&wifi0 {
>>> + memory-region = <&q6_region>, <&m3_dump>;
>>> + memory-region-names = "q6-region", "m3-dump";
>>
>> Binding said you have four items. I don't understand why this varies and
>> why this is 2 items instead.
>>
>
> In total we have 4 items, with minItems as 2.
> The other 2 items (q6-caldb & mlo-global-mem) functionalities are not yet enabled
> in ath12k driver. Hence these memory are not reserved yet.
That's not a valid reason to skip valid items. DTS is not dependent on
driver. Submit proper hardware description, not something carved to
match your driver.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 2/2] arm64: dts: qcom: add wifi node for IPQ5332 based RDP441
2025-01-28 9:41 ` Raj Kumar Bhagat
2025-01-28 10:24 ` Krzysztof Kozlowski
@ 2025-01-28 11:32 ` Konrad Dybcio
2025-01-28 17:00 ` Raj Kumar Bhagat
1 sibling, 1 reply; 13+ messages in thread
From: Konrad Dybcio @ 2025-01-28 11:32 UTC (permalink / raw)
To: Raj Kumar Bhagat, Krzysztof Kozlowski, ath12k
Cc: linux-wireless, Kalle Valo, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Jeff Johnson, Bjorn Andersson, Konrad Dybcio,
devicetree, linux-kernel, linux-arm-msm
On 28.01.2025 10:41 AM, Raj Kumar Bhagat wrote:
> On 1/28/2025 2:52 PM, Krzysztof Kozlowski wrote:
>> On 28/01/2025 10:10, Raj Kumar Bhagat wrote:
>>> + /* Default Profile
>>> + * +============+==============+=====================+
>>> + * | | | |
>>> + * | Region | Start Offset | Size |
>>> + * | | | |
>>> + * +------------+--------------+---------------------+
>>> + * | | | |
>>> + * | | | |
>>> + * | | | |
>>> + * | WLAN Q6 | 0x4A900000 | 43MB |
>>> + * | | | |
>>> + * | | | |
>>> + * +------------+--------------+---------------------+
>>> + * | M3 Dump | 0x4D400000 | 1MB |
>>> + * +============+==============+=====================+
>>> + * | |
>>> + * | |
>>> + * | |
>>> + * | Rest of memory for Linux |
>>> + * | |
>>> + * | |
>>> + * | |
>>> + * +=================================================+
>>> + */
>>> +
>>> + reserved-memory {
>>> + #address-cells = <2>;
>>> + #size-cells = <2>;
>>> + ranges;
>>> +
>>> + q6_region: wcss@4a900000 {
>>> + reg = <0x0 0x4a900000 0x0 0x02b00000>;
>>> + no-map;
>>> + };
>>> +
>>> + m3_dump: m3-dump@4d400000 {
>>
>> This fails with your wireless patchset.
>>
>
> Yes, this will fail with v4 wireless patch.
> We have v5 (yet to be sent) to read the correct reserved memory. Since,
> in v4 I was asked to address and send DTS patch separately, The corresponding
> driver patches are yet to be sent.
I think the intention was to send them separately, but together time-wise, so
that the large set of net changes is somewhat shrunk, but the reviewers can
cross-reference both series if/as needed
>
>>> + reg = <0x0 0x4D400000 0x0 0x100000>;
Please use lowercase hex
Konrad
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 2/2] arm64: dts: qcom: add wifi node for IPQ5332 based RDP441
2025-01-28 10:24 ` Krzysztof Kozlowski
@ 2025-01-28 16:46 ` Raj Kumar Bhagat
0 siblings, 0 replies; 13+ messages in thread
From: Raj Kumar Bhagat @ 2025-01-28 16:46 UTC (permalink / raw)
To: Krzysztof Kozlowski, ath12k
Cc: linux-wireless, Kalle Valo, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Jeff Johnson, Bjorn Andersson, Konrad Dybcio,
devicetree, linux-kernel, linux-arm-msm
On 1/28/2025 3:54 PM, Krzysztof Kozlowski wrote:
> On 28/01/2025 10:41, Raj Kumar Bhagat wrote:
>>>> +
>>>> + reserved-memory {
>>>> + #address-cells = <2>;
>>>> + #size-cells = <2>;
>>>> + ranges;
>>>> +
>>>> + q6_region: wcss@4a900000 {
>>>> + reg = <0x0 0x4a900000 0x0 0x02b00000>;
>>>> + no-map;
>>>> + };
>>>> +
>>>> + m3_dump: m3-dump@4d400000 {
>>>
>>> This fails with your wireless patchset.
>>>
>>
>> Yes, this will fail with v4 wireless patch.
>> We have v5 (yet to be sent) to read the correct reserved memory. Since,
>> in v4 I was asked to address and send DTS patch separately, The corresponding
>> driver patches are yet to be sent.
>
>
> So you send it to prove my point? OK, fine. So this patch confirms your
> driver changes should be rejected.
>
There seems to be some confusion here.
Based on the comments in v4, as quoted below:
"Please post the updated DTS in a separate series after fixing all the issues
pointed out by the DTS coding style."
I understood that you wanted to review only the DT-related patches first
before the driver implementation. Hence, this is posted separately before the
v5 driver is posted.
If I misunderstood, please let me know. We will continue with v5 of the original
series 'wifi: ath12k: add Ath12k AHB driver support for IPQ5332'. The v5 will
include dt-binding, driver, and reference DTS as well.
>>
>>>> + reg = <0x0 0x4D400000 0x0 0x100000>;
>>>> + no-map;
>>>> + };
>>>> + };
>>>> };
>>>>
>>>> &blsp1_i2c1 {
>>>> @@ -63,3 +104,16 @@ data-pins {
>>>> };
>>>> };
>>>> };
>>>> +
>>>> +&wifi0 {
>>>> + memory-region = <&q6_region>, <&m3_dump>;
>>>> + memory-region-names = "q6-region", "m3-dump";
>>>
>>> Binding said you have four items. I don't understand why this varies and
>>> why this is 2 items instead.
>>>
>>
>> In total we have 4 items, with minItems as 2.
>> The other 2 items (q6-caldb & mlo-global-mem) functionalities are not yet enabled
>> in ath12k driver. Hence these memory are not reserved yet.
>
> That's not a valid reason to skip valid items. DTS is not dependent on
> driver. Submit proper hardware description, not something carved to
> match your driver.
>
Sure, we can have all four reserved memory sections in the DTS. However, ath12k
will not use all four reserved memory sections as of now. Once the functionality
corresponding to q6-caldb and mlo-global-mem is enabled, these reserved memory
sections will be used.
In that case, we can also drop 'minItems' to 2 in the binding?
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 2/2] arm64: dts: qcom: add wifi node for IPQ5332 based RDP441
2025-01-28 11:32 ` Konrad Dybcio
@ 2025-01-28 17:00 ` Raj Kumar Bhagat
0 siblings, 0 replies; 13+ messages in thread
From: Raj Kumar Bhagat @ 2025-01-28 17:00 UTC (permalink / raw)
To: Konrad Dybcio, Krzysztof Kozlowski, ath12k
Cc: linux-wireless, Kalle Valo, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Jeff Johnson, Bjorn Andersson, Konrad Dybcio,
devicetree, linux-kernel, linux-arm-msm
On 1/28/2025 5:02 PM, Konrad Dybcio wrote:
> On 28.01.2025 10:41 AM, Raj Kumar Bhagat wrote:
>> On 1/28/2025 2:52 PM, Krzysztof Kozlowski wrote:
>>> On 28/01/2025 10:10, Raj Kumar Bhagat wrote:
>>>> + /* Default Profile
>>>> + * +============+==============+=====================+
>>>> + * | | | |
>>>> + * | Region | Start Offset | Size |
>>>> + * | | | |
>>>> + * +------------+--------------+---------------------+
>>>> + * | | | |
>>>> + * | | | |
>>>> + * | | | |
>>>> + * | WLAN Q6 | 0x4A900000 | 43MB |
>>>> + * | | | |
>>>> + * | | | |
>>>> + * +------------+--------------+---------------------+
>>>> + * | M3 Dump | 0x4D400000 | 1MB |
>>>> + * +============+==============+=====================+
>>>> + * | |
>>>> + * | |
>>>> + * | |
>>>> + * | Rest of memory for Linux |
>>>> + * | |
>>>> + * | |
>>>> + * | |
>>>> + * +=================================================+
>>>> + */
>>>> +
>>>> + reserved-memory {
>>>> + #address-cells = <2>;
>>>> + #size-cells = <2>;
>>>> + ranges;
>>>> +
>>>> + q6_region: wcss@4a900000 {
>>>> + reg = <0x0 0x4a900000 0x0 0x02b00000>;
>>>> + no-map;
>>>> + };
>>>> +
>>>> + m3_dump: m3-dump@4d400000 {
>>>
>>> This fails with your wireless patchset.
>>>
>>
>> Yes, this will fail with v4 wireless patch.
>> We have v5 (yet to be sent) to read the correct reserved memory. Since,
>> in v4 I was asked to address and send DTS patch separately, The corresponding
>> driver patches are yet to be sent.
>
> I think the intention was to send them separately, but together time-wise, so
> that the large set of net changes is somewhat shrunk, but the reviewers can
> cross-reference both series if/as needed
>
Yes, the intention is similar: to get DT related reviews before posting the next
version (v5) of the driver changes.
>>
>>>> + reg = <0x0 0x4D400000 0x0 0x100000>;
>
> Please use lowercase hex
>
Thanks, will do in next version.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/2] dt-bindings: net: wireless: describe the ath12k AHB module
2025-01-28 10:21 ` Krzysztof Kozlowski
@ 2025-01-28 17:34 ` Raj Kumar Bhagat
0 siblings, 0 replies; 13+ messages in thread
From: Raj Kumar Bhagat @ 2025-01-28 17:34 UTC (permalink / raw)
To: Krzysztof Kozlowski, ath12k
Cc: linux-wireless, Kalle Valo, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Jeff Johnson, Bjorn Andersson, Konrad Dybcio,
devicetree, linux-kernel, linux-arm-msm
On 1/28/2025 3:51 PM, Krzysztof Kozlowski wrote:
> On 28/01/2025 10:29, Raj Kumar Bhagat wrote:
>> On 1/28/2025 2:47 PM, Krzysztof Kozlowski wrote:
>>> On 28/01/2025 10:10, Raj Kumar Bhagat wrote:
>>>> Add device-tree bindings for the ATH12K module found in the IPQ5332
>>>> device.
>>>>
>>>> Signed-off-by: Raj Kumar Bhagat <quic_rajkbhag@quicinc.com>
>>>> ---
>>>> .../net/wireless/qcom,ath12k-ahb.yaml | 317 ++++++++++++++++++
>>>> 1 file changed, 317 insertions(+)
>>>> create mode 100644 Documentation/devicetree/bindings/net/wireless/qcom,ath12k-ahb.yaml
>>>
>>> It was v4, now v1? So entire previous discussion and feedback is
>>> missing? Go to previous series and implement entire feedback. Then use
>>> proper versioning, proper changelog and make it obvious/understandable
>>> to us, instead of sending v1 after v4 in entirely separate thread.
>>>
>>
>> I was asked to send DTS as a separate series, this is a new series for
>> DTS hence stated with v1.
>
>
> But we do not talk about DTS here, but bindings.
>
>
>> To address the undocumented ABIs we have changes in dt-binding and hence
>
> That's v1 so how it could have changes in the first place? Unless this
> is v5?
>
Sure, I understand your point now.
I shouldn't have sent dt-binding here along with DTS as v1. dt-binding should
go with wireless patch-set in v5.
Let me know your thoughts on the next steps:
1. I will send v5 for 'wifi: ath12k: add Ath12k AHB driver support for IPQ5332'
along with dt-binding.
2. In a separate series, I will send only DTS changes as v2, considering the
review comments in this version as v1 for DTS.
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2025-01-28 17:34 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-28 9:10 [PATCH 0/2] dt-bindings: net: wireless: add wifi node for IPQ5332 Raj Kumar Bhagat
2025-01-28 9:10 ` [PATCH 1/2] dt-bindings: net: wireless: describe the ath12k AHB module Raj Kumar Bhagat
2025-01-28 9:17 ` Krzysztof Kozlowski
2025-01-28 9:29 ` Raj Kumar Bhagat
2025-01-28 10:21 ` Krzysztof Kozlowski
2025-01-28 17:34 ` Raj Kumar Bhagat
2025-01-28 9:10 ` [PATCH 2/2] arm64: dts: qcom: add wifi node for IPQ5332 based RDP441 Raj Kumar Bhagat
2025-01-28 9:22 ` Krzysztof Kozlowski
2025-01-28 9:41 ` Raj Kumar Bhagat
2025-01-28 10:24 ` Krzysztof Kozlowski
2025-01-28 16:46 ` Raj Kumar Bhagat
2025-01-28 11:32 ` Konrad Dybcio
2025-01-28 17:00 ` Raj Kumar Bhagat
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).