From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB71018B482 for ; Tue, 20 Aug 2024 09:23:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724145819; cv=none; b=GYbQpVU+cidR1TtkMKZLtbNPby+6W7RhC6u6hlfOB4dGGcVZQsiSp3ZOH3ht5esUtKC41Y2JeldHQB+KAWQsWlrXbONjkF8GpkrIxklT+gRpWttnnEqCenBYqmQp50dRzm6oT5VxJ0AjTjUjaGnqHoqS3hYW+vpcJZVCnPe/Gbc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724145819; c=relaxed/simple; bh=xDllrtn/qD4DkixdUPPvZUy37jpiMK+61GEL0PlGQfk=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=ECHPWhUVHYVY+Sstj3737cEzetQ/gvSHx6xIIhYDSvqcJBWljgVZ31ZPy4NQUw5lvywjfSAl+gfAMyrLGCWi3c4ycEXk3Y9+SCBHRg02eATb0ZNrDrQmZ0bGiE35ZKOR2FZ4uPA55/yosxgi/dBomUpEZGQms8R7kLx/QOpZGmE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=DCQdgS3p; arc=none smtp.client-ip=209.85.167.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DCQdgS3p" Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-52efd2221efso309181e87.1 for ; Tue, 20 Aug 2024 02:23:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1724145816; x=1724750616; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fdqVMnwAacQ74gXBl8dr3ho20uzyST6Z+0PRXKoicpg=; b=DCQdgS3pGgZ5KX8+z5lK3y0XHT31HpPfQO/fZ7xyJ5ZhVbh4vk4BFkp0smsyKzkHkX LHTBDth45E3jTFAfuk/ZPBXiXrIfRVSaKcQNBb/CdFvw8GIc1ymD6J8GWwjHqzhtMutb SS+LkQdtrXNBqOEmhCzTv/9FBMweJNxopUzfUiou7rljTfE4doDlfraVs2zwdguJBR7Q 5fP1/cE9zru0KseDE8Y4gYvOJo8p3DgksI1swG3h+Xa2Lq28ahwbVTqMQE/7FYmchPgM GgH56WxFCt9oopq57/Y5ANDij0ZhvxU3OFuJrboil9qcXPlA4zdHsKcpKX+waQ/Xp2T8 RXNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724145816; x=1724750616; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fdqVMnwAacQ74gXBl8dr3ho20uzyST6Z+0PRXKoicpg=; b=B/cZALle3TXeVbEmfGDVFGhJ8FyU6TT4CW3PAYyqb9BG7JcicEXJKLCMFO8U8kQgPc v8LOashkOkeuRhGKfBZ4/ABbLk3HwSMjF6a1GSRdSeHHleMMkyNFWIcZ2HhnQDD3vTRM LXlK0SaAHspykUAFdZs/deA4BXjt20RrVYj+xY/TP6R2L7NPPO4f85UKS4sU+oOXIgCZ FQXPx9ls/7Ttb0ciLFs4j+R1kCqEuUAwsfDI9X44HYNHLJz+ulu7VrIvFjcTTdVHEqtU QleY0ia/fPRRdbmrjuOPY/0WJi+YE5cdjRLjEYNGiIDQzMOa6xV1GCaRmiDyC/JpD8gR dqBQ== X-Forwarded-Encrypted: i=1; AJvYcCW9DR9RRqPa9YvoVI8m8xW2Ven99ee3+7EgDwgQHMxk7RsqINt2MVDfGDdqwrKf5Am9hjtybZ6QpfVV@vger.kernel.org X-Gm-Message-State: AOJu0Ywjv1in4HeyEYQeJOxScYE1hYaisgIRIYqO7OdhtKnQrC0e691S F51jASVzAmN/MF1q4K3kneSKsJ4CFMbEv3ZZSrua45aerkj1/blJGqHMZHqbu2E= X-Google-Smtp-Source: AGHT+IGRNq4KbIGiGU/JcAnL4FPrWK4QB3N2L+snibGDdv62nJxWztlJa8W/bj8PHOkWKrn8AOaR6w== X-Received: by 2002:a05:6512:1081:b0:530:e0fd:4a92 with SMTP id 2adb3069b0e04-5331c618ffemr5308462e87.0.1724145815612; Tue, 20 Aug 2024 02:23:35 -0700 (PDT) Received: from [192.168.1.4] (88-112-131-206.elisa-laajakaista.fi. [88.112.131.206]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5330d424d6csm1709160e87.267.2024.08.20.02.23.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Aug 2024 02:23:35 -0700 (PDT) Message-ID: <7d26a62b-b898-4737-bd53-f49821e3b471@linaro.org> Date: Tue, 20 Aug 2024 12:23:34 +0300 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/5] arm64: dts: qcom: sdm670: add camcc Content-Language: en-US To: Richard Acayan , Loic Poulain , Robert Foss , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Todor Tomov , Bryan O'Donoghue , Mauro Carvalho Chehab , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-media@vger.kernel.org References: <20240819221051.31489-7-mailingradian@gmail.com> <20240819221051.31489-11-mailingradian@gmail.com> From: Vladimir Zapolskiy In-Reply-To: <20240819221051.31489-11-mailingradian@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/20/24 01:10, Richard Acayan wrote: > The camera clock controller on SDM670 controls the clocks that drive the > camera subsystem. The clocks are the same as on SDM845. Add the camera > clock controller for SDM670. > > Reviewed-by: Bryan O'Donoghue > Signed-off-by: Richard Acayan > --- > arch/arm64/boot/dts/qcom/sdm670.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm670.dtsi b/arch/arm64/boot/dts/qcom/sdm670.dtsi > index 187c6698835d..ba93cef33dbb 100644 > --- a/arch/arm64/boot/dts/qcom/sdm670.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm670.dtsi > @@ -1400,6 +1400,16 @@ spmi_bus: spmi@c440000 { > #interrupt-cells = <4>; > }; > > + camcc: clock-controller@ad00000 { > + compatible = "qcom,sdm845-camcc"; Here it's wrong, and the compatible property value shall contain "qcom,sdm670-camcc", probably it could contain both values though. It may require to add a new compatible to dt documentation and, if needed, to the corresponding clock driver. > + reg = <0 0x0ad00000 0 0x10000>; > + clocks = <&rpmhcc RPMH_CXO_CLK>; > + clock-names = "bi_tcxo"; > + #clock-cells = <1>; > + #reset-cells = <1>; > + #power-domain-cells = <1>; > + }; > + > mdss: display-subsystem@ae00000 { > compatible = "qcom,sdm670-mdss"; > reg = <0 0x0ae00000 0 0x1000>; -- Best wishes, Vladimir