* Re: [PATCH] dt-bindings: mfd: Move embedded controllers to own directory
2025-08-21 6:28 [PATCH] dt-bindings: mfd: Move embedded controllers to own directory Krzysztof Kozlowski
@ 2025-08-21 6:37 ` Michael Walle
2025-08-21 9:57 ` Krzysztof Kozlowski
2025-08-21 13:24 ` Rob Herring (Arm)
2 siblings, 0 replies; 4+ messages in thread
From: Michael Walle @ 2025-08-21 6:37 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Benson Leung, Guenter Roeck, Tim Harvey, Lee Jones,
devicetree, chrome-platform, linux-kernel
Cc: Mathew McBride
[-- Attachment #1: Type: text/plain, Size: 1011 bytes --]
On Thu Aug 21, 2025 at 8:28 AM CEST, Krzysztof Kozlowski wrote:
> Move ChromeOS Embedded Controller, Gateworks System Controller and
> Kontron sl28cpld Board Management Controller to new subdirectory
> "embedded-controller" matching their purpose. MFD is coming from Linux
> and does not really fit the actual purpose of this hardware.
>
> Rename Gateworks GSC filename to match compatible, as preferred for
> bindings.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Not sure if I can even ack that, if not, disregard it:
Acked-by: Michael Walle <mwalle@kernel.org> # for sl28cpld
> ---
>
> Cc: Mathew McBride <matt@traverse.com.au>
>
> Lee,
> Can you take it via MFD?
That would be good, as I also have a new patch series (planned for
this week) for a sl28cpld compatible "sa67mcu" embedded controller,
which touches that file. As it also contains MFD patches, I'd expect
that the DT changes of that series also go through the MFD tree then.
-michael
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 297 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: mfd: Move embedded controllers to own directory
2025-08-21 6:28 [PATCH] dt-bindings: mfd: Move embedded controllers to own directory Krzysztof Kozlowski
2025-08-21 6:37 ` Michael Walle
@ 2025-08-21 9:57 ` Krzysztof Kozlowski
2025-08-21 13:24 ` Rob Herring (Arm)
2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2025-08-21 9:57 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Benson Leung,
Guenter Roeck, Tim Harvey, Michael Walle, Lee Jones, devicetree,
chrome-platform, linux-kernel
Cc: Mathew McBride
On 21/08/2025 08:28, Krzysztof Kozlowski wrote:
> Move ChromeOS Embedded Controller, Gateworks System Controller and
> Kontron sl28cpld Board Management Controller to new subdirectory
> "embedded-controller" matching their purpose. MFD is coming from Linux
> and does not really fit the actual purpose of this hardware.
>
> Rename Gateworks GSC filename to match compatible, as preferred for
> bindings.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Cc: Mathew McBride <matt@traverse.com.au>
>
> Lee,
> Can you take it via MFD?
> ---
> .../bindings/{mfd => embedded-controller}/google,cros-ec.yaml | 2 +-
> .../gateworks-gsc.yaml => embedded-controller/gw,gsc.yaml} | 2 +-
> .../{mfd => embedded-controller}/kontron,sl28cpld.yaml | 2 +-
I forgot to update references in other files (except maintainers). This
needs v2.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: mfd: Move embedded controllers to own directory
2025-08-21 6:28 [PATCH] dt-bindings: mfd: Move embedded controllers to own directory Krzysztof Kozlowski
2025-08-21 6:37 ` Michael Walle
2025-08-21 9:57 ` Krzysztof Kozlowski
@ 2025-08-21 13:24 ` Rob Herring (Arm)
2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring (Arm) @ 2025-08-21 13:24 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Conor Dooley, Guenter Roeck, Tim Harvey, Mathew McBride,
Lee Jones, Benson Leung, chrome-platform, Michael Walle,
devicetree, linux-kernel, Krzysztof Kozlowski
On Thu, 21 Aug 2025 08:28:41 +0200, Krzysztof Kozlowski wrote:
> Move ChromeOS Embedded Controller, Gateworks System Controller and
> Kontron sl28cpld Board Management Controller to new subdirectory
> "embedded-controller" matching their purpose. MFD is coming from Linux
> and does not really fit the actual purpose of this hardware.
>
> Rename Gateworks GSC filename to match compatible, as preferred for
> bindings.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Cc: Mathew McBride <matt@traverse.com.au>
>
> Lee,
> Can you take it via MFD?
> ---
> .../bindings/{mfd => embedded-controller}/google,cros-ec.yaml | 2 +-
> .../gateworks-gsc.yaml => embedded-controller/gw,gsc.yaml} | 2 +-
> .../{mfd => embedded-controller}/kontron,sl28cpld.yaml | 2 +-
> MAINTAINERS | 4 ++--
> 4 files changed, 5 insertions(+), 5 deletions(-)
> rename Documentation/devicetree/bindings/{mfd => embedded-controller}/google,cros-ec.yaml (99%)
> rename Documentation/devicetree/bindings/{mfd/gateworks-gsc.yaml => embedded-controller/gw,gsc.yaml} (98%)
> rename Documentation/devicetree/bindings/{mfd => embedded-controller}/kontron,sl28cpld.yaml (97%)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml:
Error in referenced schema matching $id: http://devicetree.org/schemas/mfd/google,cros-ec.yaml
Tried these paths (check schema $id if path is wrong):
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
/usr/local/lib/python3.13/dist-packages/dtschema/schemas/mfd/google,cros-ec.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/remoteproc/mtk,scp.example.dtb: scp@10500000 (mediatek,mt8192-scp): cros-ec-rpmsg: {'compatible': ['google,cros-ec-rpmsg'], 'mediatek,rpmsg-name': ['cros-ec-rpmsg']} should not be valid under {'description': "Can't find referenced schema: http://devicetree.org/schemas/mfd/google,cros-ec.yaml#"}
from schema $id: http://devicetree.org/schemas/remoteproc/mtk,scp.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/remoteproc/mtk,scp.example.dtb: scp@10500000 (mediatek,mt8192-scp): cros-ec-rpmsg: Unevaluated properties are not allowed ('compatible', 'mediatek,rpmsg-name' were unexpected)
from schema $id: http://devicetree.org/schemas/remoteproc/mtk,scp.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/remoteproc/mtk,scp.example.dtb: scp@10500000 (mediatek,mt8195-scp-dual): scp@0:cros-ec-rpmsg: {'compatible': ['google,cros-ec-rpmsg'], 'mediatek,rpmsg-name': ['cros-ec-rpmsg']} should not be valid under {'description': "Can't find referenced schema: http://devicetree.org/schemas/mfd/google,cros-ec.yaml#"}
from schema $id: http://devicetree.org/schemas/remoteproc/mtk,scp.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/remoteproc/mtk,scp.example.dtb: scp@10500000 (mediatek,mt8195-scp-dual): scp@0:cros-ec-rpmsg: Unevaluated properties are not allowed ('compatible', 'mediatek,rpmsg-name' were unexpected)
from schema $id: http://devicetree.org/schemas/remoteproc/mtk,scp.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/remoteproc/mtk,scp.example.dtb: scp@10500000 (mediatek,mt8195-scp-dual): scp@a0000:cros-ec-rpmsg: {'compatible': ['google,cros-ec-rpmsg'], 'mediatek,rpmsg-name': ['cros-ec-rpmsg']} should not be valid under {'description': "Can't find referenced schema: http://devicetree.org/schemas/mfd/google,cros-ec.yaml#"}
from schema $id: http://devicetree.org/schemas/remoteproc/mtk,scp.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/remoteproc/mtk,scp.example.dtb: scp@10500000 (mediatek,mt8195-scp-dual): scp@a0000:cros-ec-rpmsg: Unevaluated properties are not allowed ('compatible', 'mediatek,rpmsg-name' were unexpected)
from schema $id: http://devicetree.org/schemas/remoteproc/mtk,scp.yaml#
doc reference errors (make refcheckdocs):
Warning: Documentation/devicetree/bindings/pwm/google,cros-ec-pwm.yaml references a file that doesn't exist: Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
Warning: Documentation/devicetree/bindings/sound/google,cros-ec-codec.yaml references a file that doesn't exist: Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
Documentation/devicetree/bindings/pwm/google,cros-ec-pwm.yaml: Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
Documentation/devicetree/bindings/sound/google,cros-ec-codec.yaml: Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250821062840.9383-2-krzysztof.kozlowski@linaro.org
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
^ permalink raw reply [flat|nested] 4+ messages in thread