From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Brugger Subject: Re: [PATCH v1 2/5] dt-bindings: pwm: add a property "mediatek,num-pwms" Date: Fri, 18 Jan 2019 09:44:49 +0100 Message-ID: <7d387d2a-74f0-c6c7-aa2d-cf9b87579682@gmail.com> References: <7e1de17a43f2cde73aecd2773e2b3a5fdfd294f3.1547781007.git.ryder.lee@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <7e1de17a43f2cde73aecd2773e2b3a5fdfd294f3.1547781007.git.ryder.lee@mediatek.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Ryder Lee , Thierry Reding Cc: Sean Wang , Weijie Gao , linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org List-Id: devicetree@vger.kernel.org On 18/01/2019 04:24, Ryder Lee wrote: > This adds a property "mediatek,num-pwms" in example so that we could > set the number of PWM channels via device tree. > > Signed-off-by: Ryder Lee > Reviewed-by: Matthias Brugger > --- > Changes since v1: add a Reviewed-by tag. > --- > Documentation/devicetree/bindings/pwm/pwm-mediatek.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt b/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt > index 991728c..f9e2d1f 100644 > --- a/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt > +++ b/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt > @@ -20,6 +20,7 @@ Required properties: > - pinctrl-names: Must contain a "default" entry. > - pinctrl-0: One property must exist for each entry in pinctrl-names. > See pinctrl/pinctrl-bindings.txt for details of the property values. > + - mediatek,num-pwms: the number of PWM channels. > > Example: > pwm0: pwm@11006000 { > @@ -37,4 +38,5 @@ Example: > "pwm3", "pwm4", "pwm5"; > pinctrl-names = "default"; > pinctrl-0 = <&pwm0_pins>; > + mediatek,num-pwms = <5>; > }; > Wasn't there a comment in the last version to use num-pwms instead of mediatek,num-pwms? Uwe I think you requested that. Regards, Matthias