devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vladimir Zapolskiy <vz-ChpfBGZJDbMAvxtiuMwx3w@public.gmane.org>
To: Joachim Eastwood
	<manabian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	arnd-r2nGTMty4D4@public.gmane.org
Subject: Re: [PATCH 3/3] ARM: dts: lpc18xx: add boot rom node
Date: Fri, 7 Oct 2016 04:50:35 +0300	[thread overview]
Message-ID: <7d4f9e48-e93a-db9e-fba0-e1b64e7056d7@mleia.com> (raw)
In-Reply-To: <20160913195117.2887-4-manabian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Hi Joachim,

On 13.09.2016 22:51, Joachim Eastwood wrote:
> Add node for the boot ROM found on all NXP LPC18xx/43xx devices.
> 
> Signed-off-by: Joachim Eastwood <manabian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
>  arch/arm/boot/dts/lpc18xx.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/lpc18xx.dtsi b/arch/arm/boot/dts/lpc18xx.dtsi
> index 631e6f6c..9f94f3e 100644
> --- a/arch/arm/boot/dts/lpc18xx.dtsi
> +++ b/arch/arm/boot/dts/lpc18xx.dtsi
> @@ -81,6 +81,14 @@
>  			status = "disabled";
>  		};
>  
> +		boot_rom: firmware@10400000 {
> +			compatible = "nxp,lpc1850-boot-rom";
> +			reg = <0x10400000 0x10000>;
> +			syscon = <&creg>;
> +			nvmem-cells = <&part_id>;

nitpicking, this change has a compile time dependency on yours
"nvmem: add lpc18xx OTP memory driver" series, I haven't noticed
this info stated, but it may be an overlook on my part.

> +			nvmem-cell-names = "PartID";
> +		};
> +
>  		dmac: dma-controller@40002000 {
>  			compatible = "arm,pl080", "arm,primecell";
>  			arm,primecell-periphid = <0x00041080>;
> 

Tested-by: Vladimir Zapolskiy <vz-ChpfBGZJDbMAvxtiuMwx3w@public.gmane.org>
Reviewed-by: Vladimir Zapolskiy <vz-ChpfBGZJDbMAvxtiuMwx3w@public.gmane.org>

--
With best wishes,
Vladimir
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2016-10-07  1:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-13 19:51 [PATCH 0/3] firmware: add driver for lpc18xx boot ROM Joachim Eastwood
     [not found] ` <20160913195117.2887-1-manabian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-09-13 19:51   ` [PATCH 1/3] firmware: add lpc18xx boot rom driver Joachim Eastwood
     [not found]     ` <20160913195117.2887-2-manabian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-10-07  1:42       ` Vladimir Zapolskiy
     [not found]         ` <9fec6e3b-fcd9-2251-c4c9-5b3f4fdc3c70-ChpfBGZJDbMAvxtiuMwx3w@public.gmane.org>
2016-10-08 10:49           ` Joachim Eastwood
2016-09-13 19:51   ` [PATCH 2/3] firmware: dt: document lpc1850 boot ROM bindings Joachim Eastwood
     [not found]     ` <20160913195117.2887-3-manabian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-09-23 13:39       ` Rob Herring
2016-09-23 20:01         ` Joachim Eastwood
2016-09-13 19:51   ` [PATCH 3/3] ARM: dts: lpc18xx: add boot rom node Joachim Eastwood
     [not found]     ` <20160913195117.2887-4-manabian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-10-07  1:50       ` Vladimir Zapolskiy [this message]
     [not found]         ` <7d4f9e48-e93a-db9e-fba0-e1b64e7056d7-ChpfBGZJDbMAvxtiuMwx3w@public.gmane.org>
2016-10-08 10:28           ` Joachim Eastwood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7d4f9e48-e93a-db9e-fba0-e1b64e7056d7@mleia.com \
    --to=vz-chpfbgzjdbmavxtiumwx3w@public.gmane.org \
    --cc=arnd-r2nGTMty4D4@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=manabian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).