From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Pavel Machek <pavel@ucw.cz>, Sasha Levin <sashal@kernel.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Markuss Broks <markuss.broks@gmail.com>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH AUTOSEL 4.19 2/3] ARM: dts: exynos: Use Exynos5420 compatible for the MIPI video phy
Date: Mon, 27 Feb 2023 17:38:33 +0100 [thread overview]
Message-ID: <7d52af12-0ff8-4bea-22da-596e5bac02e3@linaro.org> (raw)
In-Reply-To: <Y/zZ/UcWyT2EWAiL@duo.ucw.cz>
On 27/02/2023 17:27, Pavel Machek wrote:
> Hi!
>
>> From: Markuss Broks <markuss.broks@gmail.com>
>>
>> [ Upstream commit 5d5aa219a790d61cad2c38e1aa32058f16ad2f0b ]
>>
>> For some reason, the driver adding support for Exynos5420 MIPI phy
>> back in 2016 wasn't used on Exynos5420, which caused a kernel panic.
>> Add the proper compatible for it.
>
> This is likely bad idea for 4.14, as that compatible is still in use:
I don't understand this. What does it mean? That compatible was used and
still is used somewhere... Just because incorrect compatible is used
somewhere is not really related whether it should be (or not) replaced
with correct compatible.
BTW you mentioned v4.14 but AUTOSEL is for v4.19.
>
> drivers/phy/samsung/phy-exynos-mipi-video.c: .compatible = "samsung,s5pv210-mipi-video-phy",
> arch/arm/boot/dts/exynos5420.dtsi: compatible = "samsung,s5pv210-mipi-video-phy";
> arch/arm/boot/dts/exynos3250.dtsi: compatible = "samsung,s5pv210-mipi-video-phy";
> arch/arm/boot/dts/exynos4.dtsi: compatible = "samsung,s5pv210-mipi-video-phy";
>
> phy-exynos-mipi-video.c lists other compatibles, too, but with
> different data.
Best regards,
Krzysztof
prev parent reply other threads:[~2023-02-27 16:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230226034424.776084-1-sashal@kernel.org>
2023-02-26 3:44 ` [PATCH AUTOSEL 4.19 2/3] ARM: dts: exynos: Use Exynos5420 compatible for the MIPI video phy Sasha Levin
2023-02-27 16:27 ` Pavel Machek
2023-02-27 16:38 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d52af12-0ff8-4bea-22da-596e5bac02e3@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=markuss.broks@gmail.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).