* [PATCH AUTOSEL 4.19 2/3] ARM: dts: exynos: Use Exynos5420 compatible for the MIPI video phy [not found] <20230226034424.776084-1-sashal@kernel.org> @ 2023-02-26 3:44 ` Sasha Levin 2023-02-27 16:27 ` Pavel Machek 0 siblings, 1 reply; 3+ messages in thread From: Sasha Levin @ 2023-02-26 3:44 UTC (permalink / raw) To: linux-kernel, stable Cc: Markuss Broks, Krzysztof Kozlowski, Sasha Levin, robh+dt, krzysztof.kozlowski+dt, devicetree, linux-arm-kernel, linux-samsung-soc From: Markuss Broks <markuss.broks@gmail.com> [ Upstream commit 5d5aa219a790d61cad2c38e1aa32058f16ad2f0b ] For some reason, the driver adding support for Exynos5420 MIPI phy back in 2016 wasn't used on Exynos5420, which caused a kernel panic. Add the proper compatible for it. Signed-off-by: Markuss Broks <markuss.broks@gmail.com> Link: https://lore.kernel.org/r/20230121201844.46872-2-markuss.broks@gmail.com Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Signed-off-by: Sasha Levin <sashal@kernel.org> --- arch/arm/boot/dts/exynos5420.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi index aaff158807613..99e2e0b0b9cd4 100644 --- a/arch/arm/boot/dts/exynos5420.dtsi +++ b/arch/arm/boot/dts/exynos5420.dtsi @@ -530,7 +530,7 @@ dp_phy: dp-video-phy { }; mipi_phy: mipi-video-phy { - compatible = "samsung,s5pv210-mipi-video-phy"; + compatible = "samsung,exynos5420-mipi-video-phy"; syscon = <&pmu_system_controller>; #phy-cells = <1>; }; -- 2.39.0 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH AUTOSEL 4.19 2/3] ARM: dts: exynos: Use Exynos5420 compatible for the MIPI video phy 2023-02-26 3:44 ` [PATCH AUTOSEL 4.19 2/3] ARM: dts: exynos: Use Exynos5420 compatible for the MIPI video phy Sasha Levin @ 2023-02-27 16:27 ` Pavel Machek 2023-02-27 16:38 ` Krzysztof Kozlowski 0 siblings, 1 reply; 3+ messages in thread From: Pavel Machek @ 2023-02-27 16:27 UTC (permalink / raw) To: Sasha Levin Cc: linux-kernel, stable, Markuss Broks, Krzysztof Kozlowski, robh+dt, krzysztof.kozlowski+dt, devicetree, linux-arm-kernel, linux-samsung-soc [-- Attachment #1: Type: text/plain, Size: 916 bytes --] Hi! > From: Markuss Broks <markuss.broks@gmail.com> > > [ Upstream commit 5d5aa219a790d61cad2c38e1aa32058f16ad2f0b ] > > For some reason, the driver adding support for Exynos5420 MIPI phy > back in 2016 wasn't used on Exynos5420, which caused a kernel panic. > Add the proper compatible for it. This is likely bad idea for 4.14, as that compatible is still in use: drivers/phy/samsung/phy-exynos-mipi-video.c: .compatible = "samsung,s5pv210-mipi-video-phy", arch/arm/boot/dts/exynos5420.dtsi: compatible = "samsung,s5pv210-mipi-video-phy"; arch/arm/boot/dts/exynos3250.dtsi: compatible = "samsung,s5pv210-mipi-video-phy"; arch/arm/boot/dts/exynos4.dtsi: compatible = "samsung,s5pv210-mipi-video-phy"; phy-exynos-mipi-video.c lists other compatibles, too, but with different data. Best regards, Pavel -- People of Russia, stop Putin before his war on Ukraine escalates. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 195 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH AUTOSEL 4.19 2/3] ARM: dts: exynos: Use Exynos5420 compatible for the MIPI video phy 2023-02-27 16:27 ` Pavel Machek @ 2023-02-27 16:38 ` Krzysztof Kozlowski 0 siblings, 0 replies; 3+ messages in thread From: Krzysztof Kozlowski @ 2023-02-27 16:38 UTC (permalink / raw) To: Pavel Machek, Sasha Levin Cc: linux-kernel, stable, Markuss Broks, robh+dt, krzysztof.kozlowski+dt, devicetree, linux-arm-kernel, linux-samsung-soc On 27/02/2023 17:27, Pavel Machek wrote: > Hi! > >> From: Markuss Broks <markuss.broks@gmail.com> >> >> [ Upstream commit 5d5aa219a790d61cad2c38e1aa32058f16ad2f0b ] >> >> For some reason, the driver adding support for Exynos5420 MIPI phy >> back in 2016 wasn't used on Exynos5420, which caused a kernel panic. >> Add the proper compatible for it. > > This is likely bad idea for 4.14, as that compatible is still in use: I don't understand this. What does it mean? That compatible was used and still is used somewhere... Just because incorrect compatible is used somewhere is not really related whether it should be (or not) replaced with correct compatible. BTW you mentioned v4.14 but AUTOSEL is for v4.19. > > drivers/phy/samsung/phy-exynos-mipi-video.c: .compatible = "samsung,s5pv210-mipi-video-phy", > arch/arm/boot/dts/exynos5420.dtsi: compatible = "samsung,s5pv210-mipi-video-phy"; > arch/arm/boot/dts/exynos3250.dtsi: compatible = "samsung,s5pv210-mipi-video-phy"; > arch/arm/boot/dts/exynos4.dtsi: compatible = "samsung,s5pv210-mipi-video-phy"; > > phy-exynos-mipi-video.c lists other compatibles, too, but with > different data. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-27 16:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230226034424.776084-1-sashal@kernel.org>
2023-02-26 3:44 ` [PATCH AUTOSEL 4.19 2/3] ARM: dts: exynos: Use Exynos5420 compatible for the MIPI video phy Sasha Levin
2023-02-27 16:27 ` Pavel Machek
2023-02-27 16:38 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).