From: Krzysztof Kozlowski <krzk@kernel.org>
To: marlonwu@126.com, robh@kernel.org, dmitry.torokhov@gmail.com,
krzk+dt@kernel.org
Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org,
MenglongWoo@aliyun.com
Subject: Re: [PATCH 2/2] ARM: dts: Add virtual GPIO input for VNC keyboard
Date: Tue, 29 Jul 2025 09:52:43 +0200 [thread overview]
Message-ID: <7d575315-f2b3-4d86-9069-e394489b6fd5@kernel.org> (raw)
In-Reply-To: <20250729064346.22834-3-marlonwu@126.com>
On 29/07/2025 08:43, marlonwu@126.com wrote:
> From: Menglong Wu <marlonwu@126.com>
>
> Implements a complete ANSI keyboard solution for VNC remote input
> on ARM devices by:
>
> 1. Adding a device tree include file (vnc-virtual-input.dtsi) that:
> - Defines a gpio-mockup controller with 104 virtual GPIOs
> (startingfrom 400)
> - Maps all standard keyboard keys
> (F1-F12, alphanumeric, modifiers, etc.)
> - Follows Linux input event codes for key mappings
>
> 2. Updating MAINTAINERS to track the new dtsi file
>
> The virtual GPIO approach allows embedded systems without physical
> keyboards to receive full keyboard input via VNC while avoiding
> conflicts with realGPIO numbering.
>
> Signed-off-by: Menglong Wu <marlonwu@126.com>
> ---
> MAINTAINERS | 1 +
> arch/arm/boot/dts/vnc-virtual-input.dtsi | 569 +++++++++++++++++++++++
This is a dead, no-op, impossible to test code.
Also, does not follow any upstream coding style.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-07-29 7:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-29 6:43 [PATCH 0/2] Register virtual GPIO keys for VNC marlonwu
2025-07-29 6:43 ` [PATCH 1/2] dt-bindings vnc virtual input marlonwu
2025-07-29 7:33 ` Krzysztof Kozlowski
2025-07-29 6:43 ` [PATCH 2/2] ARM: dts: Add virtual GPIO input for VNC keyboard marlonwu
2025-07-29 7:52 ` Krzysztof Kozlowski [this message]
2025-07-29 7:39 ` [PATCH 0/2] Register virtual GPIO keys for VNC Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d575315-f2b3-4d86-9069-e394489b6fd5@kernel.org \
--to=krzk@kernel.org \
--cc=MenglongWoo@aliyun.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=marlonwu@126.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox