From: Krzysztof Kozlowski <krzk@kernel.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Jason Chen <jason.z.chen@intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/4] media: dt-bindings: Add OmniVision OV08X40
Date: Sat, 28 Sep 2024 10:24:45 +0200 [thread overview]
Message-ID: <7d727b8e-d8d2-4c3d-a0ee-1db3f17fe5d1@kernel.org> (raw)
In-Reply-To: <86bf9cb5-a0bb-46d5-8deb-f0e8a86932e4@linaro.org>
On 27/09/2024 01:31, Bryan O'Donoghue wrote:
> On 26/09/2024 16:53, Sakari Ailus wrote:
>>> + - const: xvclk
>> This seems redundant.
>
> Right so you're saying you'd prefer something like this
>
> drivers/media/i2c/ov8865.c
>
> I can drop the dependency on "xvclk" as a dependency in this series.
Not sure what do you mean here. Drop the clock-names and
clock-frequency. Both are redundant. You should almost never have a
clock-frequency in your device bindings.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-09-28 8:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-26 15:46 [PATCH 0/4] ov08x40: Enable use of ov08x40 on Qualcomm X1E80100 CRD Bryan O'Donoghue
2024-09-26 15:46 ` [PATCH 1/4] media: ov08x40: Fix burst write sequence Bryan O'Donoghue
2024-09-26 15:46 ` [PATCH 2/4] media: dt-bindings: Add OmniVision OV08X40 Bryan O'Donoghue
2024-09-26 15:53 ` Sakari Ailus
2024-09-26 23:31 ` Bryan O'Donoghue
2024-09-28 8:24 ` Krzysztof Kozlowski [this message]
2024-09-26 21:04 ` Rob Herring
2024-09-26 15:46 ` [PATCH 3/4] media: ov08x40: Rename ext_clk to xvclk Bryan O'Donoghue
2024-09-26 15:46 ` [PATCH 4/4] media: ov08x40: Add OF probe support Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d727b8e-d8d2-4c3d-a0ee-1db3f17fe5d1@kernel.org \
--to=krzk@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jason.z.chen@intel.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).