From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D2701CAB1 for ; Wed, 17 Jul 2024 07:47:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721202471; cv=none; b=ZA5qFRLnwA55lfZwrQCgLT3AO+my5W2mWwBXwNVpKSApe7Jp+MEKiaRxN3XxIwJm0rDb3r+/hj649szcR+AAeWn10M40w/Nh1dDwX0NozW+VMh0lTxJgqC5dIcNy5p6cTzVTaFtRy6zAkv/r31sauYRfjB/pRcLy6Ho4E/0DSno= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721202471; c=relaxed/simple; bh=DqERjfqol+hKxZVExBS4af6VbJF00Z/314k2yNE8fOU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kem8B52ipFuyBY/ZS3n7u48PHRd93DQFcOkk8EK+Ppg4NxS7Wf/n3jDDU+41mZXjp4t9d+qFBvWEpc22cmIn1byNORbFAWYxbSVsa/l2Tb0481oPsgr/AJIszLyx1rH0286TcpyhZhDiv5hvcIByznctQFHTMpe8MFFM3naTBr4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=d6dtaHYJ; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="d6dtaHYJ" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-426636ef8c9so44225145e9.2 for ; Wed, 17 Jul 2024 00:47:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1721202467; x=1721807267; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pvQ7mUcEDAkd5SXE13W2JsLBSq8CV9Djj3677zFvYx4=; b=d6dtaHYJDruA0yJnEx6uLb/H9NVzERAS4Dmr85qHL9YeEN1J1zY227+X+Rrxo5MSHV YLxCmNfORxuXDfcE+nbsJBdIe531IFk9pQRAT8A1uhUZieGdVLAKlbUuC4BFvjTWmj9b jT7wdOBvMnzry0UkcP1AsmqhV2m94i+uqUTvakcPyKWgvUB0GNrKV0cfB/U5Bq2MClKY st4571GR0OuInyMNGiFuqswXNxF4VwSLR5Ok78+qVl0MW9SfpsgmKWq/5qonmSJfnKPr 9VAESMebyXbs1MhWeNjOmUeBBjSHnSyYHnlbjdPhp/k/LIvg53m9b721MuDK7KrxcKo6 L+hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721202467; x=1721807267; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pvQ7mUcEDAkd5SXE13W2JsLBSq8CV9Djj3677zFvYx4=; b=qXqPbe7Lcyr6xKJlo8eS7mGwAOY8rvb208SA9tboputDtTNjZQp3ZcBNiZZCB77siB VqDBWkvR+ZF5BMaKgdWrwIHQzMzL8F8kycZoenWpr5fxmZr2/00exKz1baUtKKZ82not MAqw2L2/eA+WMIjQ55xmJmklsJFtXQusxtCiUj15cCl9bd/a6fYtS06U+P29Ec0SDLxK svX82tUV+N+b8agDAX36eJxcssCzUeO/upkBcvQP9w/k9mjfhs9hGwtuI9hUfpxqgyXh vw1c3ZwriFREbgjQ1YAiuQ7OL2tmxwH+wILux78T4J4TC5+Ovxp25h8oIccRXDrsPvDJ Sc9Q== X-Gm-Message-State: AOJu0Yxc92GtSC0tTxYG8zoRU5BUsOuP+f6NComt9+3pIOkHKTTP1rBp 1vJhkc2WwRfo+KFhuUtxeXRSQQzGIz8STFqfJrd2BN1zNk6u/doFiM8WRwXStB0= X-Google-Smtp-Source: AGHT+IEGuVvZ44case4QSyMvRj6cX5xkzPcx+lS4rYQA4fq/bF4ojc304lVV4+Qj7wTa26bO8bS1UA== X-Received: by 2002:a05:600c:1d8c:b0:425:7c5f:1bac with SMTP id 5b1f17b1804b1-427c2cbdd5fmr7701125e9.21.1721202466683; Wed, 17 Jul 2024 00:47:46 -0700 (PDT) Received: from [192.168.50.4] ([82.78.167.171]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-427a5e9a809sm160194035e9.28.2024.07.17.00.47.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Jul 2024 00:47:46 -0700 (PDT) Message-ID: <7d99171f-746c-4eea-bf3e-d8f3954e4d8f@tuxon.dev> Date: Wed, 17 Jul 2024 10:47:45 +0300 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 02/11] mfd: renesas-vbattb: Add a MFD driver for the Renesas VBATTB IP Content-Language: en-US To: Krzysztof Kozlowski , lee@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, alexandre.belloni@bootlin.com, geert+renesas@glider.be, magnus.damm@gmail.com, mturquette@baylibre.com, sboyd@kernel.org, p.zabel@pengutronix.de Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, Claudiu Beznea References: <20240716103025.1198495-1-claudiu.beznea.uj@bp.renesas.com> <20240716103025.1198495-3-claudiu.beznea.uj@bp.renesas.com> From: claudiu beznea In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, Krzysztof, On 16.07.2024 22:29, Krzysztof Kozlowski wrote: > On 16/07/2024 12:30, Claudiu wrote: >> From: Claudiu Beznea >> >> Renesas VBATTB IP has logic to control the RTC clock, tamper detection >> and a small 128B memory. Add a MFD driver to do the basic initialization >> of the VBATTB IP for the inner components to work. >> >> Signed-off-by: Claudiu Beznea >> --- > > >> + >> +static struct platform_driver vbattb_driver = { >> + .probe = vbattb_probe, >> + .remove_new = vbattb_remove, >> + .driver = { >> + .name = "renesas-vbattb", >> + .of_match_table = vbattb_match, >> + }, >> +}; >> +module_platform_driver(vbattb_driver); >> + >> +MODULE_ALIAS("platform:renesas-vbattb"); > > You should not need MODULE_ALIAS() in normal cases. If you need it, > usually it means your device ID table is wrong (e.g. misses either > entries or MODULE_DEVICE_TABLE()). MODULE_ALIAS() is not a substitute > for incomplete ID table. It's not needed. I took another driver as reference and missed to removed it from here in the end. Thank you for your review, Claudiu Beznea > > >> +MODULE_AUTHOR("Claudiu Beznea "); >> +MODULE_DESCRIPTION("Renesas VBATTB driver"); >> +MODULE_LICENSE("GPL"); > > Best regards, > Krzysztof >