From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 073D4C352A1 for ; Wed, 7 Dec 2022 10:07:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229820AbiLGKHq (ORCPT ); Wed, 7 Dec 2022 05:07:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229954AbiLGKHo (ORCPT ); Wed, 7 Dec 2022 05:07:44 -0500 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9418063E1 for ; Wed, 7 Dec 2022 02:07:42 -0800 (PST) Received: by mail-lj1-x236.google.com with SMTP id f16so8658597ljc.8 for ; Wed, 07 Dec 2022 02:07:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2lgyDc2BPaf6a7xLJztu7FglI3cnhZOU9b/y2TvNFgc=; b=vRsLv/GaSy9EPmAQq+63dZ6M4t6p4/CzDF2JAjaJSIcxWJOx9uVeZqJVNVq3dmnpPb lBbab6edWfxx7MxVCDMbL855Z5mWItwy5YdIfEfZyiS/JHuT2O+8bt92/90S+I4d4l8V iFrpKD1UpAiPDqcnWIxRmPay3c38uIZ7FH1b8s6ecILw68jJqX4NunJSc1velN82iOav NUhsUSK7gdRRkiBhDUH99oazExjAQxTUARi1CHM2K0dmmwiheHUfoas2SOLG3QpcGJTO QqFBw3rMuSN7y7RbUu8bMOcFQHvG/oSb+scJ7gW2JFLzjvH+VqXs+Kj8KfPIvB7wpqr+ Fkkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2lgyDc2BPaf6a7xLJztu7FglI3cnhZOU9b/y2TvNFgc=; b=fweeAP2kZ7Te34VT3Gw6eGKgogi2mql0EoAIlo4ldLLiGIU0qjjwn8UcYisjlWClh1 35PSnTv+FFoENgP/PZ1a9lp4BLj6F2NAzqrgGJRATORypmAFhH+G78KP7GGUst/jnFz3 vOPRmbsxTF1BITOP0rCyPeGXA4OOzvLZmy5Oksoku3eB+kQX6WZpTZy8xj0Ee8K4qjPQ voYv6gFxY9KSO/XU5ggHEmPvNvcJEMF41XjfcAu9AE+bCyMU8thnNrYxNbhEPkZ9TBmK z26mQoYJF5GCy2kHePNzTpHO8A7n/YYXuYXOiDZNc02TPbDjEzCcdGVKSxeaWt7jvNTk rLTg== X-Gm-Message-State: ANoB5pnOTvG5PNcAypdBQ8808xTi4PDN+IOK3D61agz4wbBGHk7BTVpI l7RNA2RlM2QgZKu+KwfZwmhqvg== X-Google-Smtp-Source: AA0mqf7rtzVO4OcdPniGSM3lTHYW3jU+eQ+5NKwi22IsC1vflmvtS1Aibm/8Ce1hrOnOkE5hsrF3pw== X-Received: by 2002:a2e:9e11:0:b0:26e:3292:12ad with SMTP id e17-20020a2e9e11000000b0026e329212admr24627754ljk.271.1670407660835; Wed, 07 Dec 2022 02:07:40 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id v7-20020ac25927000000b004ab4ebb5d92sm2807906lfi.5.2022.12.07.02.07.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Dec 2022 02:07:40 -0800 (PST) Message-ID: <7deb14ee-aae1-b521-c75e-6e33cd052c44@linaro.org> Date: Wed, 7 Dec 2022 11:07:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH 4/5] staging: dt-bindings: regulator: adi,max77541.yaml Add MAX77541 Regulator bindings Content-Language: en-US To: Okan Sahin , outreachy@lists.linux.dev Cc: Lee Jones , Rob Herring , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Jonathan Cameron , Lars-Peter Clausen , Andy Shevchenko , Ramona Bolboaca , William Breathitt Gray , Marcelo Schmitt , Marcus Folkesson , Anand Ashok Dumbre , ChiYuan Huang , Caleb Connolly , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-iio@vger.kernel.org References: <20221207090906.5896-1-okan.sahin@analog.com> <20221207090906.5896-5-okan.sahin@analog.com> From: Krzysztof Kozlowski In-Reply-To: <20221207090906.5896-5-okan.sahin@analog.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 07/12/2022 10:08, Okan Sahin wrote: > This patch adds document the bindings for MAX77541 and MAX77540 > regulator drivers. Do not use "This commit/patch". https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > > Signed-off-by: Okan Sahin > --- > .../bindings/regulator/adi,max77541.yaml | 44 +++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 45 insertions(+) > create mode 100644 Documentation/devicetree/bindings/regulator/adi,max77541.yaml > > diff --git a/Documentation/devicetree/bindings/regulator/adi,max77541.yaml b/Documentation/devicetree/bindings/regulator/adi,max77541.yaml > new file mode 100644 > index 000000000000..1f828895ab3a > --- /dev/null > +++ b/Documentation/devicetree/bindings/regulator/adi,max77541.yaml > @@ -0,0 +1,44 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/regulator/adi,max77541.yaml# Filename matching compatible, so adi,max77541-regulator.yaml > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Buck Converter driver for MAX77540/MAX77541 Drop "driver" and any other references to Linux drivers. > + > +maintainers: > + - Okan Sahin > + > +description: | > + This is a part of device tree bindings for ADI MAX77540/MAX77541 > + > + The buck convertere is represented as a sub-node of the PMIC node on the device tree. Typo, converter > + > + The device has two buck regulators. > + See also Documentation/devicetree/bindings/mfd/adi,max77541.yaml for > + additional information and example. > + > +properties: > + compatible: > + enum: > + - adi,max77540-regulator > + - adi,max77541-regulator > + > +patternProperties: > + "^BUCK[12]$": Does not look like you tested the bindings. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). > + type: object > + $ref: regulator.yaml# > + additionalProperties: false > + description: | > + Buck regulator. > + > + properties: > + regulator-name: true > + regulator-always-on: true > + regulator-boot-on: true > + regulator-min-microvolt: > + minimum: 300000 > + regulator-max-microvolt: > + maximum: 5200000 > + > +additionalProperties: false > \ No newline at end of file Check your patches before sending... > diff --git a/MAINTAINERS b/MAINTAINERS > index 5704ed5afce3..8e5572b28a8c 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -12502,6 +12502,7 @@ M: Okan Sahin > L: linux-kernel@vger.kernel.org > S: Maintained > F: Documentation/devicetree/bindings/mfd/adi,max77541.yaml > +F: Documentation/devicetree/bindings/regulator/adi,max77541.yaml > F: drivers/mfd/max77541.c > F: drivers/regulator/max77541-regulator.c > F: include/linux/mfd/max77541.h Best regards, Krzysztof