* [PATCH] drivers: of: Fixed kernel doc warning
@ 2023-12-19 6:23 Muhammad Muzammil
2023-12-20 2:37 ` Randy Dunlap
2024-01-03 20:38 ` Rob Herring
0 siblings, 2 replies; 3+ messages in thread
From: Muhammad Muzammil @ 2023-12-19 6:23 UTC (permalink / raw)
To: robh+dt, frowand.list; +Cc: devicetree, linux-kernel, Muzammil Ashraf
From: Muzammil Ashraf <m.muzzammilashraf@gmail.com>
property.c:1220 : Fixed excess struct member definition warning
property.c:444 : Fixed missing a blank line after declarations
Signed-off-by: Muzammil Ashraf <m.muzzammilashraf@gmail.com>
---
drivers/of/property.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/of/property.c b/drivers/of/property.c
index afdaefbd03f6..641a40cf5cf3 100644
--- a/drivers/of/property.c
+++ b/drivers/of/property.c
@@ -441,6 +441,7 @@ int of_property_read_string(const struct device_node *np, const char *propname,
const char **out_string)
{
const struct property *prop = of_find_property(np, propname, NULL);
+
if (!prop)
return -EINVAL;
if (!prop->length)
@@ -1217,9 +1218,9 @@ static struct device_node *parse_##fname(struct device_node *np, \
*
* @parse_prop: function name
* parse_prop() finds the node corresponding to a supplier phandle
- * @parse_prop.np: Pointer to device node holding supplier phandle property
- * @parse_prop.prop_name: Name of property holding a phandle value
- * @parse_prop.index: For properties holding a list of phandles, this is the
+ * parse_prop.np: Pointer to device node holding supplier phandle property
+ * parse_prop.prop_name: Name of property holding a phandle value
+ * parse_prop.index: For properties holding a list of phandles, this is the
* index into the list
* @optional: Describes whether a supplier is mandatory or not
* @node_not_dev: The consumer node containing the property is never converted
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers: of: Fixed kernel doc warning
2023-12-19 6:23 [PATCH] drivers: of: Fixed kernel doc warning Muhammad Muzammil
@ 2023-12-20 2:37 ` Randy Dunlap
2024-01-03 20:38 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2023-12-20 2:37 UTC (permalink / raw)
To: Muhammad Muzammil, robh+dt, frowand.list; +Cc: devicetree, linux-kernel
On 12/18/23 22:23, Muhammad Muzammil wrote:
> From: Muzammil Ashraf <m.muzzammilashraf@gmail.com>
>
> property.c:1220 : Fixed excess struct member definition warning
> property.c:444 : Fixed missing a blank line after declarations
>
Nit: only one of those is a kernel-doc warning.
> Signed-off-by: Muzammil Ashraf <m.muzzammilashraf@gmail.com>
> ---
> drivers/of/property.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/of/property.c b/drivers/of/property.c
> index afdaefbd03f6..641a40cf5cf3 100644
> --- a/drivers/of/property.c
> +++ b/drivers/of/property.c
> @@ -441,6 +441,7 @@ int of_property_read_string(const struct device_node *np, const char *propname,
> const char **out_string)
> {
> const struct property *prop = of_find_property(np, propname, NULL);
> +
> if (!prop)
> return -EINVAL;
> if (!prop->length)
> @@ -1217,9 +1218,9 @@ static struct device_node *parse_##fname(struct device_node *np, \
> *
> * @parse_prop: function name
> * parse_prop() finds the node corresponding to a supplier phandle
> - * @parse_prop.np: Pointer to device node holding supplier phandle property
> - * @parse_prop.prop_name: Name of property holding a phandle value
> - * @parse_prop.index: For properties holding a list of phandles, this is the
> + * parse_prop.np: Pointer to device node holding supplier phandle property
> + * parse_prop.prop_name: Name of property holding a phandle value
> + * parse_prop.index: For properties holding a list of phandles, this is the
> * index into the list
Looks good. Thanks.
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>
> * @optional: Describes whether a supplier is mandatory or not
> * @node_not_dev: The consumer node containing the property is never converted
--
#Randy
https://people.kernel.org/tglx/notes-about-netiquette
https://subspace.kernel.org/etiquette.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers: of: Fixed kernel doc warning
2023-12-19 6:23 [PATCH] drivers: of: Fixed kernel doc warning Muhammad Muzammil
2023-12-20 2:37 ` Randy Dunlap
@ 2024-01-03 20:38 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2024-01-03 20:38 UTC (permalink / raw)
To: Muhammad Muzammil; +Cc: devicetree, robh+dt, linux-kernel, frowand.list
On Tue, 19 Dec 2023 11:23:17 +0500, Muhammad Muzammil wrote:
> From: Muzammil Ashraf <m.muzzammilashraf@gmail.com>
>
> property.c:1220 : Fixed excess struct member definition warning
> property.c:444 : Fixed missing a blank line after declarations
>
> Signed-off-by: Muzammil Ashraf <m.muzzammilashraf@gmail.com>
> ---
> drivers/of/property.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-01-03 20:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-19 6:23 [PATCH] drivers: of: Fixed kernel doc warning Muhammad Muzammil
2023-12-20 2:37 ` Randy Dunlap
2024-01-03 20:38 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).