From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63A43C00145 for ; Thu, 15 Dec 2022 09:04:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229566AbiLOJEF (ORCPT ); Thu, 15 Dec 2022 04:04:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48486 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229789AbiLOJEA (ORCPT ); Thu, 15 Dec 2022 04:04:00 -0500 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 506D83135B for ; Thu, 15 Dec 2022 01:03:59 -0800 (PST) Received: by mail-lf1-x134.google.com with SMTP id c1so14631464lfi.7 for ; Thu, 15 Dec 2022 01:03:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jqxdj5fkQ9n2cYs252oV4AVXARcQ/xHiN+6tj2DwePk=; b=Qk6ae4zTc3LXGtko9Wztdy21PIr2TF55TvkJJ7Yq2vFKuMnXlzlsHZ4ObXzy2MENUO vEWI7NKfeyMu+uDrlMUqmFEUnBg1vyu76gcXRhEcjwwQzN1rQCSyXRmfYMUq6NZSPgbn Q6FyFhhVcI5RbvVd3dPpamm9fFhexIkFvHBTz1OjswAYYYLcrHca/mCgL3KHWSkT0LDc 5gwLhc9IzB2bUA0AC4W+znO5y+fMKjBoY/BSz1x1wjx7LJIXbLqNBdxPk+M8JtAKIuB1 k62kTUNR58WPULlvIE2Js+BjVhOoERKnM/qRZITcFJO7/A52IuewBjCBwvwTOwdGLcT0 Nwjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jqxdj5fkQ9n2cYs252oV4AVXARcQ/xHiN+6tj2DwePk=; b=u+d8C2iBxzsgT84FU4+OV03P3JxJmJOEXaR9d7zT6xnRYkw56nEVD2deLs7ABSnbXA NyQZh2U9wRhgf63mmC8lNSvdGh57SGqSjnIKqQUsc7Sk96EKhUIdh4VWNxMUTAyc50pN mfdcPDiEJWcIybeQvbPSANi9R1iY5YzQkjH/d9FQm97Ye1Bkm2uGG2M1Uv6EzTbHJryv hEfs+nECtxtqXuouUh3kRrg6lavwF+tLGHNULCrg8LFyqFCn5DPZHv2OS6//69BQPSuK K90XdoSv184BSeC/RTRc0aMpj5G+EPB0yzWguHjLZ1v/68oQ1dyCFpwvaKLmqq0hAkj8 9Izw== X-Gm-Message-State: ANoB5pnNF9+kOwI+UXgv2c7yrs4UKwz3HpaQIk8GRUquaRGPIfre6UxG 8MePAJoFBTpiADene+w9RV2OpiGj0lWxWwII X-Google-Smtp-Source: AA0mqf6+hgKCqvG8MOaHrXDFYxCb6yCspua/Y4A0lxEvIcU/Em2K/ShTHloB+t+iJXrw3dU95EEFPg== X-Received: by 2002:ac2:5148:0:b0:4b5:830d:12ba with SMTP id q8-20020ac25148000000b004b5830d12bamr7119720lfd.14.1671095037655; Thu, 15 Dec 2022 01:03:57 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id k10-20020ac257ca000000b004b55075f813sm1095847lfo.227.2022.12.15.01.03.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Dec 2022 01:03:57 -0800 (PST) Message-ID: <7e67b2d1-394e-2353-df37-5ae3cac64b9c@linaro.org> Date: Thu, 15 Dec 2022 10:03:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v8 2/7] media: dt-binding: nuvoton: Add bindings for NPCM VCD and ECE engine Content-Language: en-US To: Marvin Lin , mchehab@kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: openbmc@lists.ozlabs.org, avifishman70@gmail.com, tmaimon77@gmail.com, tali.perry1@gmail.com, venture@google.com, yuenn@google.com, benjaminfair@google.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, kwliu@nuvoton.com, kflin@nuvoton.com References: <20221214092636.810883-1-milkfafa@gmail.com> <20221214092636.810883-3-milkfafa@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20221214092636.810883-3-milkfafa@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 14/12/2022 10:26, Marvin Lin wrote: > Add dt-binding document for Video Capture/Differentiation Engine (VCD) > and Encoding Compression Engine (ECE) present on Nuvoton NPCM SoCs. Subject: drop second, redundant "bindings for". > > Signed-off-by: Marvin Lin > --- > .../bindings/media/nuvoton,npcm-ece.yaml | 44 ++++++++++++ > .../bindings/media/nuvoton,npcm-vcd.yaml | 72 +++++++++++++++++++ > 2 files changed, 116 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/nuvoton,npcm-ece.yaml > create mode 100644 Documentation/devicetree/bindings/media/nuvoton,npcm-vcd.yaml > > diff --git a/Documentation/devicetree/bindings/media/nuvoton,npcm-ece.yaml b/Documentation/devicetree/bindings/media/nuvoton,npcm-ece.yaml > new file mode 100644 > index 000000000000..d12b76d137d9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/nuvoton,npcm-ece.yaml > @@ -0,0 +1,44 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > + Drop blank line. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/nuvoton,npcm-ece.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Nuvoton NPCM Encoding Compression Engine > + > +maintainers: > + - Joseph Liu > + - Marvin Lin > + > +description: | > + Video Encoding Compression Engine (ECE) present on Nuvoton NPCM SoCs. > + > +properties: > + compatible: > + enum: > + - nuvoton,npcm750-ece > + - nuvoton,npcm845-ece > + > + reg: > + maxItems: 1 > + > + resets: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - resets > + > +additionalProperties: false > + > +examples: > + - | > + #include > + > + ece: ece@f0820000 { If this is video codec, then generic node name: "video-codec". "ece" is specific, not generic. > + compatible = "nuvoton,npcm750-ece"; > + reg = <0xf0820000 0x2000>; > + resets = <&rstc NPCM7XX_RESET_IPSRST2 NPCM7XX_RESET_ECE>; > + }; > diff --git a/Documentation/devicetree/bindings/media/nuvoton,npcm-vcd.yaml b/Documentation/devicetree/bindings/media/nuvoton,npcm-vcd.yaml > new file mode 100644 > index 000000000000..2d8da8f36506 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/nuvoton,npcm-vcd.yaml > @@ -0,0 +1,72 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > + Drop blank line. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/nuvoton,npcm-vcd.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Nuvoton NPCM Video Capture/Differentiation Engine > + > +maintainers: > + - Joseph Liu > + - Marvin Lin > + > +description: | > + Video Capture/Differentiation Engine (VCD) present on Nuvoton NPCM SoCs. > + > +properties: > + compatible: > + enum: > + - nuvoton,npcm750-vcd > + - nuvoton,npcm845-vcd > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + resets: > + maxItems: 1 > + > + nuvoton,sysgcr: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: phandle to access GCR (Global Control Register) registers. > + > + nuvoton,sysgfxi: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: phandle to access GFXI (Graphics Core Information) registers. > + > + nuvoton,ece: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: phandle to access ECE (Encoding Compression Engine) registers. > + > + memory-region: > + description: > + CMA pool to use for buffers allocation instead of the default CMA pool. maxItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + - resets > + - nuvoton,sysgcr > + - nuvoton,sysgfxi > + - nuvoton,ece > + > +additionalProperties: false > + > Best regards, Krzysztof