From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49AF6C433FE for ; Sat, 9 Apr 2022 10:48:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241431AbiDIKu3 (ORCPT ); Sat, 9 Apr 2022 06:50:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240297AbiDIKu2 (ORCPT ); Sat, 9 Apr 2022 06:50:28 -0400 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C23F22B3A for ; Sat, 9 Apr 2022 03:48:21 -0700 (PDT) Received: by mail-ej1-x633.google.com with SMTP id l7so16401329ejn.2 for ; Sat, 09 Apr 2022 03:48:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=zurZzrPnoV4r9DOy+KZk14qxFnOBvVLhR9qywD2QyTw=; b=odUO6U5irUD1TkbGAOs9IgaVtCu9ZJQSdzKAbAtU03h2pKET2StPIxNP0ccPnw6ryi 7L7QpO3e2/HsMEJWXV0X9STvzCCGfy2/Z4+Dw9Ug89GBEHB+W6wSaFFDmkF0Z+OrdzDQ oqRCfKhYtQOMKBEQ/EHifuKnX7bKjrllz/fIYy1Xvsi4F/Z+aqZj864bj8pXz1fWKf7e 0sDo0lmj0IjbinYYlxcY1qNS5L8++7zZnS/J7TtRaTzf0rg/mWPfEAiObNqJAAHVl6wb Vgr+tqTCLMgh0oC3kuozx6TgQ5GQ2qNEvLfD1anUDzs+G7yqwhKZYaxxOUmwHFXm9Any Cv4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=zurZzrPnoV4r9DOy+KZk14qxFnOBvVLhR9qywD2QyTw=; b=aJhd6IkGBUrukOJo3QwZZ5IvfKx7LFONfA2Zpg8B804Nwcim4vvyrtWBjlA25KlwQQ ip1CZmCvNoycad04TQEW/pHRN07H+es2ghCJ3IclkQiho9XXsBbhfV/5vNW+o2rGAkcV nnjrP6+yp0t8Xlf9M10zerKVhAvhTHzFu+Tr+dIPzLDN1UDUMIWhwUOArlmYjfe7gdAc 7X3HaHmoTmihZnAzj+GBF09bWtFs4pyqC8TsTTr9TWgwx71FUm0v7Lg/BAGolBgIbFoW COg9/R7/F7OaTW6fsJEXczSQdEKk5fsf/uUm9as+rqWNotTepZnhnPUHSWBC1qiLiJlM NXvA== X-Gm-Message-State: AOAM530C6pNlZR5oczWSNcl6CfvVFVmV92Rk1iCOF6a85ZmEtyj6uf8g 55MlY98Hv0BDy+XC6IusI2Me+qJmYlIK1nDc X-Google-Smtp-Source: ABdhPJw9pBeXg2SGuQ2eXUyY6HU7X577pbo9P5dDrtLudpd5GXm2ecpBgXeFvECzMwpI0j1dbrfsyA== X-Received: by 2002:a17:907:1b27:b0:6d9:ceb6:7967 with SMTP id mp39-20020a1709071b2700b006d9ceb67967mr23101859ejc.186.1649501299954; Sat, 09 Apr 2022 03:48:19 -0700 (PDT) Received: from [192.168.0.188] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id jv20-20020a170907769400b006e7f859e683sm6045929ejc.19.2022.04.09.03.48.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 09 Apr 2022 03:48:19 -0700 (PDT) Message-ID: <7e6a0489-f90f-a362-e37b-b219fe2d71fe@linaro.org> Date: Sat, 9 Apr 2022 12:48:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v1 0/7] Add rtc refclk support for PolarFire SoC Content-Language: en-US To: Conor Dooley , Conor Dooley , sboyd@kernel.org, aou@eecs.berkeley.edu, paul.walmsley@sifive.com, palmer@rivosinc.com, a.zummo@towertech.it, alexandre.belloni@bootlin.com, robh+dt@kernel.org, krzk+dt@kernel.org, mturquette@baylibre.com Cc: daire.mcnamara@microchip.com, linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-riscv@lists.infradead.org References: <20220408143646.3693104-1-conor.dooley@microchip.com> <1fa15b36-7a84-e0ac-2c56-d6a2bec566ff@linaro.org> <98026c4a-a065-3965-27f0-71de29cdb264@conchuod.ie> From: Krzysztof Kozlowski In-Reply-To: <98026c4a-a065-3965-27f0-71de29cdb264@conchuod.ie> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 09/04/2022 09:14, Conor Dooley wrote: > > > On 08/04/2022 16:29, Conor Dooley wrote: >> >> >> On 08/04/2022 15:57, Krzysztof Kozlowski wrote: >>> On 08/04/2022 16:36, Conor Dooley wrote: >>>> Hey, >>>> As I mentioned in my fixes for 5.18 [0], found out that the reference >>>> clock for the rtc is actually missing from the clock driver (and the >>>> dt binding). >>>> >>>> Currently the mpfs clock driver uses a reference clock called the >>>> "msspll", set in the device tree, as the parent for the cpu/axi/ahb >>>> (config) clocks. The frequency of the msspll is determined by the FPGA >>>> bitstream & the bootloader configures the clock to match the bitstream. >>>> The real reference is provided by a 100 or 125 MHz off chip oscillator. >>>> >>>> However, the msspll clock is not actually the parent of all clocks on >>>> the system - the reference clock for the rtc/mtimer actually has the >>>> off chip oscillator as its parent. >>>> >>>> This series enables reading the rate of the msspll clock, converts >>>> the refclock in the device tree to the external reference & adds >>>> the missing rtc reference clock. >>>> >>>> I assume it is okay not to add fixes tags for the rtc dt binding? >>>> Since the clock was previously missing, the binding is wrong, but >>>> idk if that qualifies as a fix? >>> >>> Usually ABI breakage, even if accepted, should be be tagged as fix >>> because it is clearly then a break of other peoples' trees... >>> >> >> That means either a) do something messy in the clock driver or b) mark >> the whole series as fixes (and roll it into [0]). >> >> The second option seems far more sensible to me, do you agree? > > Having thought some more about it, patches 2, 3 and the rtc part of 7 > should be moved into [0] since they're fixing a binding that only > arrived in 5.18-rc1. > For the rest, make the second part of the reg optional and if it doesnt > exist just return prate for the msspll clock? Ah, so this got into v5.18-rc1? I think I missed that information from the patches description and focused on backporting to stables. Then indeed you could combine all fixes together, mark them with Fixes. Best regards, Krzysztof