From: Krzysztof Kozlowski <krzk@kernel.org>
To: Dale Whinham <daleyo@gmail.com>,
Johannes Berg <johannes@sipsolutions.net>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jeff Johnson <jjohnson@kernel.org>
Cc: "Jérôme de Bretagne" <jerome.debretagne@gmail.com>,
"Jeff Johnson" <jeff.johnson@oss.qualcomm.com>,
linux-wireless@vger.kernel.org, devicetree@vger.kernel.org,
ath12k@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 6/8] dt-bindings: wireless: ath12k: Add disable-rfkill property
Date: Mon, 1 Dec 2025 08:34:26 +0100 [thread overview]
Message-ID: <7ea43ef2-b453-46cf-a35e-ea11ca1dbe24@kernel.org> (raw)
In-Reply-To: <20251201011457.17422-7-daleyo@gmail.com>
On 01/12/2025 02:14, Dale Whinham wrote:
> From: Jérôme de Bretagne <jerome.debretagne@gmail.com>
>
> rfkill should be disabled according to the Surface Pro 11's DSDT.
>
> https://lore.kernel.org/all/20250113074810.29729-3-quic_lingbok@quicinc.com/
> has added support to read the ACPI bitflag when ACPI is supported.
It wasn't merged. If it was, reference commits, not random emails.
>
> Document the disable-rfkill property to expose one specific feature
> (DISABLE_RFKILL_BIT) for devices described with a DT, so that the
> feature can be disabled.
This is just a circular logic. Add property to have property in DT so
that you can use feature.
No, describe the hardware or actual problem instead.
You still need to answer Rob's questions.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-12-01 7:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-01 1:14 [PATCH v2 0/8] Microsoft Surface Pro 11 support Dale Whinham
2025-12-01 1:14 ` [PATCH v2 1/8] dt-bindings: arm: qcom: Document Microsoft Surface Pro 11 Dale Whinham
2025-12-01 2:17 ` Rob Herring (Arm)
2025-12-01 7:30 ` Krzysztof Kozlowski
2025-12-01 1:14 ` [PATCH v2 4/8] arm64: dts: qcom: Add support for " Dale Whinham
2025-12-01 15:35 ` Konrad Dybcio
2025-12-02 18:50 ` Jérôme de Bretagne
2025-12-03 10:56 ` Konrad Dybcio
2025-12-03 21:58 ` Jérôme de Bretagne
2025-12-04 9:02 ` Konrad Dybcio
2025-12-01 1:14 ` [PATCH v2 6/8] dt-bindings: wireless: ath12k: Add disable-rfkill property Dale Whinham
2025-12-01 2:17 ` Rob Herring (Arm)
2025-12-01 7:34 ` Krzysztof Kozlowski [this message]
2025-12-07 19:28 ` Jérôme de Bretagne
2025-12-08 2:20 ` Krzysztof Kozlowski
2025-12-01 1:14 ` [PATCH v2 8/8] arm64: dts: qcom: x1-microsoft-denali: Disable rfkill for wifi0 Dale Whinham
2025-12-01 7:35 ` Krzysztof Kozlowski
2025-12-01 12:27 ` [PATCH v2 0/8] Microsoft Surface Pro 11 support Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ea43ef2-b453-46cf-a35e-ea11ca1dbe24@kernel.org \
--to=krzk@kernel.org \
--cc=ath12k@lists.infradead.org \
--cc=conor+dt@kernel.org \
--cc=daleyo@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jeff.johnson@oss.qualcomm.com \
--cc=jerome.debretagne@gmail.com \
--cc=jjohnson@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).