From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: george chan <gchan9527@gmail.com>, Krzysztof Kozlowski <krzk@kernel.org>
Cc: Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
cros-qcom-dts-watchers@chromium.org,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFT v3 1/5] dt-bindings: media: camss: Add qcom,sc7180-camss
Date: Thu, 27 Jun 2024 16:40:24 +0100 [thread overview]
Message-ID: <7ea5890e-5c74-447c-903c-9d3e9aabb7e4@linaro.org> (raw)
In-Reply-To: <CADgMGStvxkaj_LxXLuwEUtm5dPT-MCr6aKp_DKZngHsRPTjmng@mail.gmail.com>
On 26/06/2024 10:04, george chan wrote:
> On Wed, Jun 26, 2024 at 4:58 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On 26/06/2024 10:38, george chan wrote:
>>> On Wed, Jun 26, 2024 at 4:17 PM george chan <gchan9527@gmail.com> wrote:
>>>>
>>>> On Wed, Jun 26, 2024 at 3:15 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>>>> Keep the list in "required:" in the same order as the list in "properties:".
>>>>
>>>> ok gotcha
>>> btw, i checked "required:" and "properties:" are aligned, both of
>>
>> No, they are not.
>>
>> Which is the first entry in "properties"?
>>
>> Which is the first entry in "required"?
>>
>> Please stop wasting reviewers time by disagreeing on every little piece
>> of this. The feedback was quite clear but somehow you do not read it and
>> respond with some inaccurate statements.
>>
>> Best regards,
>> Krzysztof
>>
>
> Then my apology. I might take a break here. Appreciated if some
> developer is willing to take over it too.
George are you resending this with Krzysztof's comments addressed ?
I'm trying to figure out what we are targeting for merge.
---
bod
next prev parent reply other threads:[~2024-06-27 15:40 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-24 12:13 [PATCH RFT v3 0/5] Add sc7180 camss subsys support George Chan via B4 Relay
2024-06-24 12:13 ` [PATCH RFT v3 1/5] dt-bindings: media: camss: Add qcom,sc7180-camss George Chan via B4 Relay
2024-06-25 23:32 ` Bryan O'Donoghue
2024-06-26 5:46 ` george chan
2024-06-26 6:11 ` Krzysztof Kozlowski
2024-06-26 6:46 ` george chan
2024-06-26 7:15 ` Krzysztof Kozlowski
2024-06-26 8:17 ` george chan
2024-06-26 8:38 ` george chan
2024-06-26 8:57 ` Krzysztof Kozlowski
2024-06-26 9:04 ` george chan
2024-06-27 15:40 ` Bryan O'Donoghue [this message]
2024-06-28 19:16 ` george chan
2024-06-26 9:17 ` Dmitry Baryshkov
2024-06-26 8:56 ` Krzysztof Kozlowski
2024-06-24 12:13 ` [PATCH RFT v3 2/5] media: camss: csiphy-3ph: Add Gen2 v1.2.2 two-phase MIPI CSI-2 DPHY init George Chan via B4 Relay
2024-06-25 23:34 ` Bryan O'Donoghue
2024-06-28 9:41 ` Bryan O'Donoghue
2024-06-24 12:13 ` [PATCH RFT v3 3/5] media: qcom: camss: Add sc7180 support George Chan via B4 Relay
2024-06-25 23:34 ` Bryan O'Donoghue
2024-06-24 12:13 ` [PATCH RFT v3 4/5] media: qcom: camss: Add sc7180 resources George Chan via B4 Relay
2024-06-25 23:39 ` Bryan O'Donoghue
2024-06-24 12:13 ` [PATCH RFT v3 5/5] arm64: dts: qcom: sc7180: camss: Add CAMSS block definition George Chan via B4 Relay
2024-06-25 23:49 ` Bryan O'Donoghue
2024-06-25 23:52 ` Bryan O'Donoghue
2024-06-26 5:53 ` george chan
2024-06-26 10:50 ` george chan
2024-06-24 13:50 ` [PATCH RFT v3 0/5] Add sc7180 camss subsys support Bryan O'Donoghue
2024-06-24 15:03 ` george chan
2024-06-25 16:57 ` Konrad Dybcio
2024-06-25 23:45 ` Bryan O'Donoghue
2024-06-26 5:49 ` george chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ea5890e-5c74-447c-903c-9d3e9aabb7e4@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=gchan9527@gmail.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=todor.too@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).