Re: [PATCH v10 3/4] arm64: dts: qcom: add base AIM300 dtsi

[Konrad Dybcio <konrad.dybcio@linaro.org>]

On 6/18/24 09:22, Tengfei Fan wrote:
> AIM300 Series is a highly optimized family of modules designed to
> support AIoT applications. It integrates QCS8550 SoC, UFS and PMIC
> chip etc.
> Here is a diagram of AIM300 SoM:
>            +----------------------------------------+
>            |AIM300 SoM                              |
>            |                                        |
>            |                           +-----+      |
>            |                      |--->| UFS |      |
>            |                      |    +-----+      |
>            |                      |                 |
>            |                      |                 |
>       3.7v |  +-----------------+ |    +---------+  |
>    ---------->|       PMIC      |----->| QCS8550 |  |
>            |  +-----------------+      +---------+  |
>            |                      |                 |
>            |                      |                 |
>            |                      |    +-----+      |
>            |                      |--->| ... |      |
>            |                           +-----+      |
>            |                                        |
>            +----------------------------------------+
> 
> Co-developed-by: Fenglin Wu <quic_fenglinw@quicinc.com>
> Signed-off-by: Fenglin Wu <quic_fenglinw@quicinc.com>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
> ---

[...]

> +&ufs_mem_hc {
> +	reset-gpios = <&tlmm 210 GPIO_ACTIVE_LOW>;
> +	vcc-supply = <&vreg_l17b_2p5>;
> +	vcc-max-microamp = <1300000>;
> +	vccq-supply = <&vreg_l1g_1p2>;
> +	vccq-max-microamp = <1200000>;
> +	vdd-hba-supply = <&vreg_l3g_1p2>;

These regulators should generally have:

regulator-allow-set-load;
regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
                            RPMH_REGULATOR_MODE_HPM>;

although the current setup you have never lets them exit HPM

Konrad