Re: [PATCH 1/2] arm64: dts: qcom: hamoa: Fix xbl_tmp_buffer_mem size

[Hans de Goede <johannes.goede@oss.qualcomm.com>]

Hi,

On 25-May-26 14:29, Konrad Dybcio wrote:
> On 5/25/26 1:47 PM, Hans de Goede wrote:
>> The EFI memtable (shown when booting with efi=debug) shows that the
>> xbl_tmp_buffer_mem region size is 0x1c0000 bytes large not 0xc00000 bytes:
>>
>> efi:   0x000082800000-0x0000829bffff [Reserved    |
>> efi:   0x0000829c0000-0x000083efffff [Conventional|
>>
>> This fix aligns the size with the EFI reported size and makes /proc/iomem
>> correctly show mem blocks matching the EFI memmap:
>>
>> 82800000-829bffff : reserved
>> 829c0000-83efffff : System RAM
>>
>> Instead of:
>>
>> 82800000-833fffff : reserved
>> 83400000-83efffff : System RAM
>>
>> before this change
>>
>> Signed-off-by: Hans de Goede <johannes.goede@oss.qualcomm.com>
>> ---
>>  arch/arm64/boot/dts/qcom/hamoa.dtsi | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/hamoa.dtsi b/arch/arm64/boot/dts/qcom/hamoa.dtsi
>> index de0f2346cb38..5a2e84365901 100644
>> --- a/arch/arm64/boot/dts/qcom/hamoa.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/hamoa.dtsi
>> @@ -582,7 +582,7 @@ tz_stat_mem: tz-stat@82700000 {
>>  		};
>>  
>>  		xbl_tmp_buffer_mem: xbl-tmp-buffer@82800000 {
>> -			reg = <0x0 0x82800000 0x0 0xc00000>;
>> +			reg = <0x0 0x82800000 0x0 0x1c0000>;
> 
> FWIW the reference memory map shows a contiguous block of:
> 
> 0x8280_0000 -> "no reclaim XBL scratch_buffer2"
> 0x829c_0000 -> "reclaimable XBL scratch_buffer"
> 0x83f0_0000-0x8400_0000 -> "no reclaim xbl scratch_buffer1"

Thanks, so the first part here 0x8280_0000 - 0x829c_0000
aligns with the EFI reservation and with the dts reservation
after my patch.

0x829c_0000 - 0x83f0_0000 being reclaimable matches with
both EFI + the dts (old and new with a different start)
having this as usable RAM.

The 0x83f0_0000-0x8400_0000 area seems to be marked as
reserved by neither EFI nor the current dts...

With the first part of the reference memory map aligning
with what EFI shows, I think this patch is correct.

I wonder if we should do anything about the 0x83f0_0000-0x8400_0000
range though ?

Regards,

Hans




> 
> Konrad