From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EF4EEE49A5 for ; Sat, 19 Aug 2023 10:42:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231463AbjHSKmd (ORCPT ); Sat, 19 Aug 2023 06:42:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231432AbjHSKmI (ORCPT ); Sat, 19 Aug 2023 06:42:08 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0A5041171 for ; Sat, 19 Aug 2023 03:16:00 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-99c136ee106so220106266b.1 for ; Sat, 19 Aug 2023 03:16:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692440159; x=1693044959; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=AdIuirefSx1BPzTeUZTmUG2GheoNdWtbM86n1SoSEV0=; b=r6QSLYT+OQuj79GrZJTT9vJZwVwFWNyiYLS35jM8XQAzls4ZidjKqo3XE7B37q7xY0 aVTpm5XiZpK/P/KDRZvqEGx1clFnesPMRQKHDKTE3zY9PY9B4nNMwZmaRLt56Seu6ab2 26cs+1hrFHx4hAqTDnFClI9Udcg8Y9TVnwjxI2fiqZzI40/fO82fKeXFRfp74Rdp5B/g gXNPhLAXPDmeQbceL/lbhh0zcXqp8lrOkLalPT+CN/w94BUIX9Ccc/Q5ZRPmRoJQyh4s cG5Be6REVcucqZMHr7bBg44F6lmS9J+YUdo6mjyFr3CYTLC0J71p/n7T+OHcT7IO3eh5 Ca0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692440159; x=1693044959; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AdIuirefSx1BPzTeUZTmUG2GheoNdWtbM86n1SoSEV0=; b=YBAp5p+15SHzbhbsyJmsfprk1RRr8C7YUcviH8PMxvJlerkxy8iUb2ZqOOSzCQPrKm Wng4FBskKs2bcTxnpIzQpgdse+A/z+yxMC+PCcxSdCyXOvjJbWGsZ5QggUisrjJrhALR nSHzS98nKWfl64T5pgQgvNH4EX4wMwBIfRVPI66xjVAov260/m/k6gDg7r0p15jyriD2 wyU7vAZYJklMXts7o5ST6wGjTdnbSzY1STqnE3n2yPAEW6nBk+junLk/Ox1pvNH0VJM2 a/UaDgXzdNC6w3t/m4/CbuXttCgI9jMFxU4VTBttlymJtZMMBNMMafP/Uj9SICZ1u2Ac PJCw== X-Gm-Message-State: AOJu0YzbKUlZrECaM49mOMqaTVKs6bTx9r0ebR74vWXdXFhn6kkdekz7 FxLHDFULiB3GldFqLjwwPiIByQ== X-Google-Smtp-Source: AGHT+IGe8g81n1uQKahgkBJPCWcocD1AFWqZDAUIlbISlaV75NpgBM8WNKA8nPtS9Uqat3y/fgm7LQ== X-Received: by 2002:a17:906:30c3:b0:99b:f3ef:f084 with SMTP id b3-20020a17090630c300b0099bf3eff084mr1178608ejb.66.1692440159140; Sat, 19 Aug 2023 03:15:59 -0700 (PDT) Received: from [192.168.0.22] ([77.252.47.198]) by smtp.gmail.com with ESMTPSA id a6-20020a170906368600b0099bc038eb2bsm2452762ejc.58.2023.08.19.03.15.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 19 Aug 2023 03:15:58 -0700 (PDT) Message-ID: <7ec61967-c899-4ebf-abde-3c1c5576d54f@linaro.org> Date: Sat, 19 Aug 2023 12:15:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH] dt-bindings: pinctrl: aspeed: Allow only defined pin mux node properties Content-Language: en-US To: Rob Herring , Andrew Jeffery , Linus Walleij , Krzysztof Kozlowski , Conor Dooley , Joel Stanley Cc: linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230819010907.916061-1-robh@kernel.org> From: Krzysztof Kozlowski In-Reply-To: <20230819010907.916061-1-robh@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 19/08/2023 03:09, Rob Herring wrote: > The Aspeed pinctrl bindings are missing an additionalProperties/ > unevaluatedProperties schemas on the child pin mux nodes which means any > undefined properties are allowed. In addition, using > 'additionalProperties' for child nodes with any name works better than a > pattern matching everything with an if/then schema to select nodes only. > > With 'additionalProperties' added, 'pins' and 'bias-disable' > properties need to be added as they were not defined. A $ref to > pinmux-node.yaml which defines the common property types was also > missing. > > Signed-off-by: Rob Herring > --- > Really 'pins' should have some constraints, but I don't know what the > possible values are. Happy to add if someone can tell me what. > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof