From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A11D1C83F12 for ; Tue, 29 Aug 2023 09:33:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232544AbjH2Jcd (ORCPT ); Tue, 29 Aug 2023 05:32:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234880AbjH2JcM (ORCPT ); Tue, 29 Aug 2023 05:32:12 -0400 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2FB2BCD9 for ; Tue, 29 Aug 2023 02:31:45 -0700 (PDT) Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-4ffae5bdc9aso6614322e87.1 for ; Tue, 29 Aug 2023 02:31:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693301498; x=1693906298; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=Ac6xqVgSskbwf+6SFx252FM1re6neKrPp+nbe33qmqk=; b=sMt8FogipfV40ZJ0kVIacpgxgR0aLO7WAv6xB5Hh1O5yCe9iGO1h/pivrQAY/VOqkn Q95EVL22BhWl1ZKU+EEn0fggXzJ0/Bco3sOYlweLnyQC4cX60I34KXygTmcrylsmM0PY LKckbEt33wz6mv9wa8Kl0j2NB39/SYQT0nALjpFMQzslNU2INY3mVWw9ZP9pidQV0rSd 8IzOFXWefH/7rDZGgnzopZVn0Gr4PqwTWMD3yJmEGLf1H/c/Ldf+aqwdYcSe1SdFo5+L JUUp3XJ+7XPiDKk4+tYiQvzGp4LEv+n58BOG8xa1U2Hg6YMAg1Ca3HgYUCik58DmgOyF YCDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693301498; x=1693906298; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ac6xqVgSskbwf+6SFx252FM1re6neKrPp+nbe33qmqk=; b=lLozSQelF9gaXN7xrkP3ld9OSAqUd93Ou/BMGwGCytzVxWjwiCGI9R7HYWWJvxHNX3 o0iyCgEsFIsEmcOpFuBzybFZWLwLkiB0cdUW6HMtTfrEmj4pEGUQ21KVisWv68VLF/n9 SDYAgBG0+kWLucI2cQYAH/cgQnUi2No1M4efjUsYYS1tLcFdTcTsbVEksMq7RedhKJKU 0jg+oEWMPp8RgXFsDrcUfaIQb2VBaQuSK+FGIZ+cFPpMJbCU3tkQ1oiddVX9iCX0alrz L+f5pFszVekCnVU39vI5VNsnrFwJhhr4zC+pizplObgoB3/QYOlAouQY12Q95wr47nvV 5qDQ== X-Gm-Message-State: AOJu0YznlNV+4R9s24qxJBAUI9XTOCy9RfiDYR1oXHpUuDSQJlMwKa78 yxjKfZGElPcq5f4lRzS3JAh+yQ== X-Google-Smtp-Source: AGHT+IG5GaoltkaSnPoIGiS46RWBV3F2tskphsVOJLvNIjlOmoXNR8DJalLo+GUytEuPS1sXXvoPlA== X-Received: by 2002:a05:6512:3d0f:b0:500:b9f3:1dc4 with SMTP id d15-20020a0565123d0f00b00500b9f31dc4mr3855419lfv.68.1693301497780; Tue, 29 Aug 2023 02:31:37 -0700 (PDT) Received: from ?IPV6:2001:14ba:a0db:1f00::8a5? (dzdqv0yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a0db:1f00::8a5]) by smtp.gmail.com with ESMTPSA id c3-20020ac244a3000000b0050087b72169sm1868261lfm.24.2023.08.29.02.31.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Aug 2023 02:31:37 -0700 (PDT) Message-ID: <7ec87a0f-3404-46b3-be18-e7af870e6411@linaro.org> Date: Tue, 29 Aug 2023 12:31:36 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 1/4] phy: qcom: m31: Fix indentation issues To: Varadarajan Narayanan , agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, catalin.marinas@arm.com, will@kernel.org, vkoul@kernel.org, kishon@kernel.org, arnd@arndb.de, geert+renesas@glider.be, nfraprado@collabora.com, rafal@milecki.pl, peng.fan@nxp.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org References: <6087788f2e2a8e88a0cf3df64d20abbada17cdd0.1693296360.git.quic_varada@quicinc.com> Content-Language: en-GB From: Dmitry Baryshkov In-Reply-To: <6087788f2e2a8e88a0cf3df64d20abbada17cdd0.1693296360.git.quic_varada@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 29/08/2023 11:37, Varadarajan Narayanan wrote: > Fix incorrect indentation > > Signed-off-by: Varadarajan Narayanan > --- > v10: > Restore register success print per Dmitry's comment > v9: > Fix line break alignment > Remove register success print > v8 version of the driver has been picked up for merge. > (https://lore.kernel.org/linux-arm-msm/169226613917.81413.1200008047604336868.b4-ty@kernel.org/) > v8: > Change commit subject and message per review comments > Don't include of_platform.h > Change struct init coding style > GENMASK -> BIT for one define > v6: > Kconfig:Add COMPILE_TEST and remove USB_GADGET from 'depends' > Change 'selects' USB_PHY -> GENERIC_PHY > Driver: Use correct headers > const int -> unsigned int for 'nregs' in private data > Use generic names for clk, phy in m31 phy structure > Init register details directly instead of using macro > Use dev_err_probe in the error paths of driver probe > v5: > Kconfig and Makefile:- place snippet according to sorted order > Use generic phy instead of usb-phy > Use ARRAY_SIZE for reg init instead of blank last entry > Fix copyright year > > v4: > Remove unused enum > Error handling for devm_clk_get > v1: > Combine driver, makefile and kconfig into 1 patch > Remove 'qscratch' region and its usage. The controller driver takes care > of those settings > Use compatible/data to handle ipq5332 init > Drop the default case > Get resources by index instead of name as there is only one resource > Add clock > Fix review comments in the driver > --- > drivers/phy/qualcomm/phy-qcom-m31.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry