From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A965FC001DE for ; Mon, 31 Jul 2023 08:49:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231998AbjGaItC (ORCPT ); Mon, 31 Jul 2023 04:49:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229843AbjGaIs0 (ORCPT ); Mon, 31 Jul 2023 04:48:26 -0400 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDDD9172C for ; Mon, 31 Jul 2023 01:46:44 -0700 (PDT) Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-3fb4146e8ceso39343505e9.0 for ; Mon, 31 Jul 2023 01:46:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690793203; x=1691398003; h=content-transfer-encoding:in-reply-to:organization:references:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=wr9S1xevkiceWDkqzJOGXDauW47kODXtzJg0v0eVCYQ=; b=Fk8MgaPoFog3wIA3AJUKoUQceKgnRMQRHry3wmSVur7INMe7B2zyLfuQIc5HDSTuPj AtRU+XI7m8jAzTyoL1ZFpeGk19OGWmEFBbbhW3j2evZ+Y/L7TdrXBM7aOaJ3i2b6blDv fbm88HFPhW/6QQqAj4VsH7mYdO2HNe4Bt9bN8PWCDeBU4O+3JZmdOKEkVgn3dWAlBEUy qfRto9lbq5TKDd1K4sX/7XyHztv3NQaxRlnb09svePujAmMXKmAthtVf1S7ZBUXce/HH O1+iRm3V/RyM7+TmIUPymkTtXmIkqvQkvet5NCtBsIC1fH0LRBech3gu2/t73GHzi3h5 vVHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690793203; x=1691398003; h=content-transfer-encoding:in-reply-to:organization:references:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wr9S1xevkiceWDkqzJOGXDauW47kODXtzJg0v0eVCYQ=; b=M39txu4JQ4NU6xkPsBEO2YCq6ZrxfxKxws1q/CA75L9dL63Trv4u2kZ5qygBjM+mYF ESazT8BD4WFyBhn0gXufGRmLwX9XETSBhoGtZH9Jzh1V7DlTzrOHLqmhoVUbyf81qGgg 3vFJV3EpJNngJ/tV33QMzBy9Ydn+Wgu5tGXbyrB4+InffICzkS4hk7fUgD9ID2bY7oEo bDC9s9Z45Wucu+681t64PHZPy1oMVm8F1PxGml2VfoWY1/CXVVyoJJQIeGVrtb2Et7t2 Q5WAJh70nmCZ7+YPQ/0xYnhr5eHOp/r3he2mgy25jG67ZnI12PIUkgzstjnoqKazLt29 utpg== X-Gm-Message-State: ABy/qLb2KG1nid182vWcyrv9VIidecIY1PE5AuiKqS5pRvyDcNwFXXJc iPpnhjcLIfh8s694tAIRVmBDDA== X-Google-Smtp-Source: APBJJlGReOaWf7EDwA4liFEYkK+faS6psAGzATwisa4wFGMbpJ2OF/FRsZPrmGGGYkW1JAMOFAF8Pg== X-Received: by 2002:a5d:63c8:0:b0:317:6be9:538a with SMTP id c8-20020a5d63c8000000b003176be9538amr5711448wrw.20.1690793203393; Mon, 31 Jul 2023 01:46:43 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:14b8:9aa7:6bf0:256d? ([2a01:e0a:982:cbb0:14b8:9aa7:6bf0:256d]) by smtp.gmail.com with ESMTPSA id d12-20020a5d644c000000b003142e438e8csm12443440wrw.26.2023.07.31.01.46.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Jul 2023 01:46:42 -0700 (PDT) Message-ID: <7ecdb9c9-6620-67b5-be46-a36490e7ba33@linaro.org> Date: Mon, 31 Jul 2023 10:46:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH] arm64: dts: amlogic: meson-g12b-bananapi: switch to enable-gpios Content-Language: en-US To: Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230725142703.157547-1-krzysztof.kozlowski@linaro.org> Organization: Linaro Developer Services In-Reply-To: <20230725142703.157547-1-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 25/07/2023 16:27, Krzysztof Kozlowski wrote: > The recommended name for enable GPIOs property in regulator-gpio is > enable-gpios. This is also required by bindings: > > meson-g12b-bananapi-cm4-cm4io.dtb: regulator-vddio-c: Unevaluated properties are not allowed ('enable-gpio' was unexpected) > > Signed-off-by: Krzysztof Kozlowski > --- > arch/arm64/boot/dts/amlogic/meson-g12b-bananapi-cm4.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-bananapi-cm4.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-bananapi-cm4.dtsi > index 97e522921b06..86adc1423385 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-g12b-bananapi-cm4.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-bananapi-cm4.dtsi > @@ -56,7 +56,7 @@ vddio_c: regulator-vddio-c { > regulator-min-microvolt = <1800000>; > regulator-max-microvolt = <3300000>; > > - enable-gpio = <&gpio_ao GPIOAO_3 GPIO_OPEN_DRAIN>; > + enable-gpios = <&gpio_ao GPIOAO_3 GPIO_OPEN_DRAIN>; > enable-active-high; > regulator-always-on; > Reviewed-by: Neil Armstrong