From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BFFF1D154 for ; Tue, 19 Dec 2023 15:42:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="elhVP3EN" Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-50e3901c2e2so2927669e87.0 for ; Tue, 19 Dec 2023 07:42:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1703000536; x=1703605336; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ePnuuavbZlgpn7c7K6BItpG53K0ha+PBqw8kQdsmfgE=; b=elhVP3ENfRpiDDKECqCeHkRorOMrfeMzyMsEZA/7PxImwHB7hRU1dBLoDmeza4mEpm WByuLtto9PtouYFgwybiSHRyQiOkcMLg9cRtJmde6XTKZPLhUhsH6M3qrQB+yCjAc3mM lItrOA8GmIXpgr1UzFb5zhxzLF4Mkh/k43Pwlfh0uCOJaPc+4dKp9WLqaAzFUuEGaB0g GitCfBUIeue43O7eJCIiZLxAu6LELVhK3DUeSx3Z11WepfNGLvplcTETGPFKB09OghEg 0lOTYK67Lm7xwI8j22tDUBEJiXAL7+po+wUP/Ep1YwqvEkg/8xJ42FxGNFgXRlXUJsaR 2r/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703000536; x=1703605336; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ePnuuavbZlgpn7c7K6BItpG53K0ha+PBqw8kQdsmfgE=; b=wHdxOKZDGkCN3KCSBQ4kB7hBjiAYLeM8oTahIv2o4i3upniahNRI3l3rQd+5ntjJie 7BZX67vUV4FXvB7dH6cdWgcLpRRq2sLIKCER0yuLwRPV8Escfnsqq6mrlw6pSxuBFJ95 9sVHs9n1MScK839LgHAkSRcg1XNtoycisOZCkSk1lqdzPwrKEl+09M+LggFkzvT9/pmE BNsLWnr46vUuo0NeSP0ptD0sqVbKjsqCl7LiFsO/UH7vVnL5EhsL/MOHpJZCWE8mcCyG 8X9DniFcnQugrXR/7/Yx19/MMxUWTzijP4hfBI72OPFfjMMEs+tGQH0kyMPD4mGjkw6a svsw== X-Gm-Message-State: AOJu0YzKb9kCrAx3UvOII/SUCYX5nh/MCkhFOI2GTfE/mf5gHiiWxDK2 dyI6diwKqbiOW+dDpKKv3yudgQ== X-Google-Smtp-Source: AGHT+IHUtm8vktwGXSu3deyhyGTckpUiZK0Ub6K/iwBNjg5UTVGqlu07SLh3VSQiXsV9loDjoGxKJA== X-Received: by 2002:a05:6512:4005:b0:50b:f0df:57bb with SMTP id br5-20020a056512400500b0050bf0df57bbmr10322799lfb.49.1703000536227; Tue, 19 Dec 2023 07:42:16 -0800 (PST) Received: from [192.168.1.20] ([178.197.218.27]) by smtp.gmail.com with ESMTPSA id d23-20020a50fe97000000b005534057c72dsm2557106edt.18.2023.12.19.07.42.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Dec 2023 07:42:15 -0800 (PST) Message-ID: <7edab40c-1ac2-4044-9337-9f26e80024a1@linaro.org> Date: Tue, 19 Dec 2023 16:42:12 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] dts: iot2050: Support IOT2050-SM variant Content-Language: en-US To: Jan Kiszka , Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bao Cheng Su , Chao Zeng Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Li Hua Qian References: <11e0b0c8b828254567a8ff89820c067cacad2150.1702917360.git.jan.kiszka@siemens.com> <8b3daa3c-dbf8-4286-b04e-011cd9b0efa5@linaro.org> <4c31adc5-3fc5-47bc-9766-6d3d1eeddb65@siemens.com> <3d2662be-3a55-4390-bd2a-cfa5cc53510f@linaro.org> <62be89bb-1ae1-4bf6-9f9e-b6eb68e6504d@siemens.com> <29c030e1-c493-4521-b5e8-db3f484eefb8@siemens.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <29c030e1-c493-4521-b5e8-db3f484eefb8@siemens.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 19/12/2023 16:40, Jan Kiszka wrote: > On 19.12.23 16:39, Krzysztof Kozlowski wrote: >> On 19/12/2023 16:37, Jan Kiszka wrote: >>>>>> >>>>>> You have label for that... Somehow all these nodes are half-baked, >>>>>> without all the expected properties and now you call node name as ABI. >>>>>> The node name is not the ABI. >>>>> >>>>> Well, existing userspace uses those names, and adding the properties >>>>> would break that interface. Now, does Linux do that? >>>> >>>> I don't think you understood the concept. There is no change for >>>> userspace. Same interface, same names. No ABI break. >>> >>> I do understand the impact very well: >>> open("/sys/class/leds/user-led1-red") has to work for all the variants, >>> consistently and backward-compatible for userspace. >> >> And it will. The name is the same. > > Nope, it's not - I tried that already :) > > root@iot2050-debian:~# ls -l /sys/class/leds/ > total 0 > lrwxrwxrwx 1 root root 0 Dec 19 09:49 green:indicator -> ../../devices/platform/leds/leds/green:indicator And how does your DTS look like? Because I also tried and it is exactly the same. Best regards, Krzysztof