From: Alex Bee <knaerzche@gmail.com>
To: Conor Dooley <conor@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: clock: rk3128: Add HCLK_SFC
Date: Wed, 5 Jun 2024 21:35:26 +0200 [thread overview]
Message-ID: <7ee2d114-f8a8-4f67-9b50-aa7ad5b46c7f@gmail.com> (raw)
In-Reply-To: <20240605-crummy-racoon-fadc5a6f5d25@spud>
Am 05.06.24 um 19:58 schrieb Conor Dooley:
> On Wed, Jun 05, 2024 at 07:21:52PM +0200, Alex Bee wrote:
>> Add a clock id for SFC's AHB clock.
>>
>> Signed-off-by: Alex Bee <knaerzche@gmail.com>
>> ---
>> NB: I've added the new id at the top of existing HCLK's, since adding it at
>> the bottom would change CLK_NR_CLKS and therefore the ABI and there is
>> plenty of "free" ids between PCLK_MIPIPHY and HCLK_SPDIF.
> We've removed a bunch of things like "CLK_NR_CLKS" from bindings before
> and advocate against adding them. Patches like this being the reason
> why..
Yeah, sure ... I thought removing it would be little out of scope for this
series. But as we are already having a helper for finding the "max id" for
Rockchip clocks, I'll resend and remove that annoying macro and add the new
id at the bottom of the existing (where it belongs).
Alex
next prev parent reply other threads:[~2024-06-05 19:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-05 17:21 [PATCH 0/3] Add SFC support for RK3128 Alex Bee
2024-06-05 17:21 ` [PATCH 1/3] dt-bindings: clock: rk3128: Add HCLK_SFC Alex Bee
2024-06-05 17:56 ` Conor Dooley
2024-06-05 17:58 ` Conor Dooley
2024-06-05 19:35 ` Alex Bee [this message]
2024-06-05 17:21 ` [PATCH 2/3] clk: rockchip: Add HCLK_SFC for RK3128 Alex Bee
2024-06-05 17:21 ` [PATCH 3/3] ARM: dts: rockchip: Add SFC " Alex Bee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ee2d114-f8a8-4f67-9b50-aa7ad5b46c7f@gmail.com \
--to=knaerzche@gmail.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox