devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jun Li <jun.li@nxp.com>, "Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"krzysztof.kozlowski+dt@linaro.org" 
	<krzysztof.kozlowski+dt@linaro.org>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH] dt-bindings: usb: typec-tcpci: convert to DT schema format
Date: Wed, 29 Mar 2023 09:24:38 +0200	[thread overview]
Message-ID: <7eebc72a-a657-ca67-2c59-60f8e633b878@linaro.org> (raw)
In-Reply-To: <PA4PR04MB9640866667BFFF292F06388589899@PA4PR04MB9640.eurprd04.prod.outlook.com>

On 29/03/2023 09:16, Jun Li wrote:
> 
> Per spec below, TCPCI does need interrupt for alert, but no limit on the number.
> 
> "The TCPC uses I2C to communicate with the TCPM. The TCPC is an I2C slave
> with Alert# signal for requesting attention."
> 
>> no supplies and no additional GPIOs (like reset
>> GPIO)?
> 
> Those are out of scope of spec, I think it can be added as optional.
> 
>>
>> Because this is what this binding is saying.
>>
>>> fully compliance with tcpci spec, if change it to be only specific to
>>> nxp,ptn5110, my understanding is then other chips need duplicate a
>>> binding doc even common tcpci binding and driver is enough for them.
>>
>> Depends. Usually we have common schema used by actual device schemas. If
>> TCPCI-compliant device cannot have additional properties,
> 
> My understanding was TCPCI-compliant device can have additional optional
> properties.

Then I propose to rename it to device-matching name (nxp,ptn5110.yaml).
Except interrupt and connector, there is nothing here which describes
actual standard or common class. These can easily be moved to shared
binding later. I can easily imagine TCPCI devices with a bit different
interface and different properties.

Best regards,
Krzysztof


      reply	other threads:[~2023-03-29  7:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-23  6:58 [PATCH] dt-bindings: usb: typec-tcpci: convert to DT schema format Peng Fan (OSS)
2023-03-27  7:41 ` Krzysztof Kozlowski
2023-03-28  9:24   ` Jun Li
2023-03-28 10:43     ` Krzysztof Kozlowski
2023-03-29  7:16       ` Jun Li
2023-03-29  7:24         ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7eebc72a-a657-ca67-2c59-60f8e633b878@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jun.li@nxp.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=peng.fan@nxp.com \
    --cc=peng.fan@oss.nxp.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).