From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE3E5C74A5B for ; Wed, 29 Mar 2023 07:24:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229935AbjC2HY4 (ORCPT ); Wed, 29 Mar 2023 03:24:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229959AbjC2HYp (ORCPT ); Wed, 29 Mar 2023 03:24:45 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E62183C31 for ; Wed, 29 Mar 2023 00:24:41 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id h11so11962492lfu.8 for ; Wed, 29 Mar 2023 00:24:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680074680; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=TGS6b5YXn10NcJ5QUB50Aod9B0bqHGHbyiKTOZ3Udps=; b=X3DWfUaGLZ+qgDV7Ty2iJJ2VSoKD4XrKrqluyWJzr4xuawtqqDJMFcoCuyTx9Q19YY n2FkaaO4kjFdjdZCGDhZbE2kueqbR4c7UQnQsyZYajhIfwPTCIhyBTxv5vcPMPqxydU0 rcVTlDKqFK2YR4OOQf4f1zft7AtS625bU0l8NCogV5GHeHH9VZ5ju31ttXnSyEMs5fcl Tm2q92dnKc9ZdF95KALp7db/8SYHbPAP9/tp67bCzmMZHj5HN4B1Mvr+BpeqZ8nMGJ3S y3ThvnD+STqrtDhlsybPmMkmXqmK5qkeYCGZRMu4Y+/ku6nRRWsa+vqmM4pkIyKLU8FV Gv+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680074680; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TGS6b5YXn10NcJ5QUB50Aod9B0bqHGHbyiKTOZ3Udps=; b=plqzB3RX879KPZU4ZxFHPTS4mEFjV7n8opnsGI+quYUR4/zONpkQk1seYJKu4shjCv 2LsDwQYJ0R2FEu3ha2r0ay9DpC/bPt6Vh1n0FUGtv5RscQQ3UfXDm64/iO8erXBzsu4a Hl9xw+75aX2rQqGGzubQyC28x5byGO5s1q/9h9W9bCOpW0RLRsInajeNd3/rY1NWovI0 4YH1Lu2yo2JF/buljAjUG6ppzXMar9DgN/QWWFcgFGc0RZa8KJSGY0V0MzSmAGGU4dBO GS2js0fmZRCl37U2s13ii8ztYjYrWFQapHmt5dcW3zBuMGbf+4f38iYVteNB4pgF1Sa+ J/Yg== X-Gm-Message-State: AAQBX9dEKd8pi2aVXWDZYECojxYkoXM2f9xr8TTzNMPyGNGL8D+bwjhT GSowO3YCm/GAPHThqHOQaCtugw== X-Google-Smtp-Source: AKy350aF6HDKGWSyijeHG5aujpZZx7FNjGf8c7Gy0NPPvWJoyS5Xi1axkQ9kLVhlUUNEBU4qvhm6nA== X-Received: by 2002:ac2:5591:0:b0:4ea:e2f8:5edf with SMTP id v17-20020ac25591000000b004eae2f85edfmr5222614lfg.33.1680074679959; Wed, 29 Mar 2023 00:24:39 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id s12-20020ac25fec000000b004dda80cabf0sm5371135lfg.172.2023.03.29.00.24.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Mar 2023 00:24:39 -0700 (PDT) Message-ID: <7eebc72a-a657-ca67-2c59-60f8e633b878@linaro.org> Date: Wed, 29 Mar 2023 09:24:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH] dt-bindings: usb: typec-tcpci: convert to DT schema format Content-Language: en-US To: Jun Li , "Peng Fan (OSS)" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "gregkh@linuxfoundation.org" Cc: "linux-usb@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Peng Fan References: <20230323065824.3857573-1-peng.fan@oss.nxp.com> <5675373c-af4f-906f-9906-7853a85f8ed6@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 29/03/2023 09:16, Jun Li wrote: > > Per spec below, TCPCI does need interrupt for alert, but no limit on the number. > > "The TCPC uses I2C to communicate with the TCPM. The TCPC is an I2C slave > with Alert# signal for requesting attention." > >> no supplies and no additional GPIOs (like reset >> GPIO)? > > Those are out of scope of spec, I think it can be added as optional. > >> >> Because this is what this binding is saying. >> >>> fully compliance with tcpci spec, if change it to be only specific to >>> nxp,ptn5110, my understanding is then other chips need duplicate a >>> binding doc even common tcpci binding and driver is enough for them. >> >> Depends. Usually we have common schema used by actual device schemas. If >> TCPCI-compliant device cannot have additional properties, > > My understanding was TCPCI-compliant device can have additional optional > properties. Then I propose to rename it to device-matching name (nxp,ptn5110.yaml). Except interrupt and connector, there is nothing here which describes actual standard or common class. These can easily be moved to shared binding later. I can easily imagine TCPCI devices with a bit different interface and different properties. Best regards, Krzysztof