From: "Rafał Miłecki" <zajec5@gmail.com>
To: Florian Fainelli <florian.fainelli@broadcom.com>,
Pavel Machek <pavel@ucw.cz>, Rob Herring <robh+dt@kernel.org>
Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
"Florian Fainelli" <f.fainelli@gmail.com>,
linux-arm-kernel@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com,
"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH 2/2] leds: bcm63xxx: add support for BCM63xxx controller
Date: Wed, 24 Nov 2021 09:11:43 +0100 [thread overview]
Message-ID: <7ef000b2-2247-2d38-2973-10e017a3dfb3@gmail.com> (raw)
In-Reply-To: <02a2dbb7-6ae0-af28-e852-ee66bb3d66f1@broadcom.com>
On 22.11.2021 23:04, Florian Fainelli wrote:
> On 11/15/21 1:11 AM, Rafał Miłecki wrote:
>> From: Rafał Miłecki <rafal@milecki.pl>
>>
>> It's a new controller used on BCM4908, some BCM68xx and some BCM63xxx
>> SoCs.
>>
>> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
>
> Same comment as the binding, please s/bcm63xxx/bcm63xx/ for matchign
> existing drivers/patterns.
>
> [snip]
>
>> +
>> +#define BCM63XXX_MAX_LEDS 32> +
>> +#define BCM63XXX_GLB_CTRL 0x00
>> +#define BCM63XXX_MASK 0x04
>
> This define appears unused.
Just like few other registers. I think it's still worth to define all hw
registers.
next prev parent reply other threads:[~2021-11-24 8:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 9:11 [PATCH 1/2] dt-bindings: leds: add Broadcom's BCM63xxx controller Rafał Miłecki
2021-11-15 9:11 ` [PATCH 2/2] leds: bcm63xxx: add support for " Rafał Miłecki
2021-11-22 22:04 ` Florian Fainelli
2021-11-24 8:11 ` Rafał Miłecki [this message]
2021-11-22 21:51 ` [PATCH 1/2] dt-bindings: leds: add Broadcom's " Florian Fainelli
2021-11-22 22:00 ` Rafał Miłecki
2021-11-23 22:17 ` Florian Fainelli
2021-11-23 22:19 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ef000b2-2247-2d38-2973-10e017a3dfb3@gmail.com \
--to=zajec5@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rafal@milecki.pl \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).