From: <Conor.Dooley@microchip.com>
To: <krzysztof.kozlowski@linaro.org>, <Conor.Dooley@microchip.com>,
<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
<paul.walmsley@sifive.com>, <palmer@dabbelt.com>,
<aou@eecs.berkeley.edu>, <devicetree@vger.kernel.org>,
<linux-riscv@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] riscv: dts: align gpio-key node names with dtschema
Date: Mon, 27 Jun 2022 06:52:03 +0000 [thread overview]
Message-ID: <7ef4cc22-6125-d3be-b88d-1202b46ef523@microchip.com> (raw)
In-Reply-To: <9dbe7dc9-aac9-7d1b-eccf-5d4c8683065b@linaro.org>
On 27/06/2022 07:48, Krzysztof Kozlowski wrote:
> On 26/06/2022 22:56, Conor.Dooley@microchip.com wrote:
>>
>>
>> On 24/06/2022 18:08, Krzysztof Kozlowski wrote:
>>> The node names should be generic and DT schema expects certain pattern
>>> (e.g. with key/button/switch).
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
>>
>> Are you planning to change them all & then change the pattern
>> property to complain if "key" is missing?
>
> Yes, I put the link to original patchset doing this:
>
>> Thanks,
>> Conor.
>>
>>>
>>> ---
>>>
>>> See: https://lore.kernel.org/all/20220616005224.18391-1-krzysztof.kozlowski@linaro.org/
>
> Specifically one of the first patches:
> https://lore.kernel.org/all/20220616005333.18491-1-krzysztof.kozlowski@linaro.org/
>
Ah my bad, I had a quick look and didn't see it.
I blame a long day of traveling!
Thanks,
Conor.
next prev parent reply other threads:[~2022-06-27 6:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 17:08 [PATCH] riscv: dts: align gpio-key node names with dtschema Krzysztof Kozlowski
2022-06-26 20:56 ` Conor.Dooley
2022-06-27 6:48 ` Krzysztof Kozlowski
2022-06-27 6:52 ` Conor.Dooley [this message]
2022-07-04 16:12 ` Conor.Dooley
2022-07-14 22:03 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ef4cc22-6125-d3be-b88d-1202b46ef523@microchip.com \
--to=conor.dooley@microchip.com \
--cc=aou@eecs.berkeley.edu \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox