From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Barnabás Czémán" <barnabas.czeman@mainlining.org>,
"Georgi Djakov" <djakov@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
Vladimir Lypak <vladimir.lypak@gmail.com>
Subject: Re: [PATCH 2/2] interconnect: qcom: Add MSM8953 driver
Date: Thu, 27 Jun 2024 09:54:18 +0200 [thread overview]
Message-ID: <7f278851-8c7b-4bb7-a967-fff477dc26eb@kernel.org> (raw)
In-Reply-To: <20240626-msm8953-interconnect-v1-2-eeb31a2231b0@mainlining.org>
On 26/06/2024 22:35, Barnabás Czémán wrote:
> From: Vladimir Lypak <vladimir.lypak@gmail.com>
Thank you for your patch. There is something to discuss/improve.
> +
> +static const struct regmap_config msm8953_bimc_regmap_config = {
> + .fast_io = true,
> + .max_register = 0x5a000,
> + .reg_bits = 32,
> + .reg_stride = 4,
> + .val_bits = 32,
> +};
> +
> +static const struct qcom_icc_desc msm8953_bimc = {
> + .type = QCOM_ICC_BIMC,
> + .bus_clk_desc = &bimc_clk,
> + .nodes = msm8953_bimc_nodes,
> + .num_nodes = ARRAY_SIZE(msm8953_bimc_nodes),
> + .qos_offset = 0x8000,
> + .regmap_cfg = &msm8953_bimc_regmap_config
> +};
> +
> +static struct qcom_icc_node *msm8953_pcnoc_nodes[] = {
This should be '* const '
Best regards,
Krzysztof
prev parent reply other threads:[~2024-06-27 7:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-26 20:35 [PATCH 0/2] Add interconnect driver for MSM8953/SDM450/SDM632 Barnabás Czémán
2024-06-26 20:35 ` [PATCH 1/2] dt-bindings: interconnect: qcom: Add Qualcomm MSM8953 NoC Barnabás Czémán
2024-06-27 7:52 ` Krzysztof Kozlowski
2024-06-26 20:35 ` [PATCH 2/2] interconnect: qcom: Add MSM8953 driver Barnabás Czémán
2024-06-27 7:54 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f278851-8c7b-4bb7-a967-fff477dc26eb@kernel.org \
--to=krzk@kernel.org \
--cc=barnabas.czeman@mainlining.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh@kernel.org \
--cc=vladimir.lypak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).