From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Cc: linux-watchdog@vger.kernel.org, wim@linux-watchdog.org,
linux@roeck-us.net, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com,
arinc.unal@arinc9.com, tsbogend@alpha.franken.de,
p.zabel@pengutronix.de, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-mips@vger.kernel.org
Subject: Re: [PATCH v6 3/3] watchdog: mt7621-wdt: avoid ralink architecture dependent code
Date: Tue, 14 Feb 2023 10:33:29 +0100 [thread overview]
Message-ID: <7f2e556c-ee11-fe4e-f4d6-94c761f976d0@linaro.org> (raw)
In-Reply-To: <CAMhs-H_Cd9F+UWWe+dAA89r_huX_srtsgjh1qus93nGehQN1AQ@mail.gmail.com>
On 14/02/2023 09:54, Sergio Paracuellos wrote:
>>> return 0;
>>> @@ -143,6 +147,10 @@ static int mt7621_wdt_probe(struct platform_device *pdev)
>>> if (!drvdata)
>>> return -ENOMEM;
>>>
>>> + drvdata->sysc = syscon_regmap_lookup_by_compatible("mediatek,mt7621-sysc");
>>> + if (IS_ERR(drvdata->sysc))
>>> + return PTR_ERR(drvdata->sysc);
>>
>> This should be the backup/error path for original code using syscon
>> property. Looking up by compatible is really not portable/re-usable.
>
> I can change the code in the way you are pointing out here but...
> Why is it not re-usable? Compatible is not supposed to be changed
> since in other cases the DTB ABI will be broken. I am totally lost
> about what is an ABI breakage, then.
How do you use it on other platform?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-02-14 9:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 20:05 [PATCH v6 0/3] watchdog: mt7621-wdt: avoid globals and arch dependencies Sergio Paracuellos
2023-02-13 20:05 ` [PATCH v6 1/3] mips: dts: ralink: mt7621: rename watchdog node from 'wdt' into 'watchdog' Sergio Paracuellos
2023-02-13 20:05 ` [PATCH v6 2/3] watchdog: mt7621-wdt: avoid static global declarations Sergio Paracuellos
2023-02-13 20:05 ` [PATCH v6 3/3] watchdog: mt7621-wdt: avoid ralink architecture dependent code Sergio Paracuellos
2023-02-14 8:31 ` Krzysztof Kozlowski
2023-02-14 8:54 ` Sergio Paracuellos
2023-02-14 9:33 ` Krzysztof Kozlowski [this message]
2023-02-14 9:50 ` Sergio Paracuellos
2023-02-14 9:54 ` Krzysztof Kozlowski
2023-02-14 12:10 ` Guenter Roeck
2023-02-14 12:15 ` Krzysztof Kozlowski
2023-02-14 15:07 ` Guenter Roeck
2023-02-16 8:20 ` Krzysztof Kozlowski
2023-02-14 8:12 ` [PATCH v6 0/3] watchdog: mt7621-wdt: avoid globals and arch dependencies Arınç ÜNAL
2023-02-14 8:31 ` Arınç ÜNAL
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f2e556c-ee11-fe4e-f4d6-94c761f976d0@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=arinc.unal@arinc9.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=sergio.paracuellos@gmail.com \
--cc=tsbogend@alpha.franken.de \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).