From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DD0BC7EE23 for ; Fri, 26 May 2023 23:30:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231519AbjEZXax (ORCPT ); Fri, 26 May 2023 19:30:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230466AbjEZXax (ORCPT ); Fri, 26 May 2023 19:30:53 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2EB7618D for ; Fri, 26 May 2023 16:30:50 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-4f4b80bf93aso1407199e87.0 for ; Fri, 26 May 2023 16:30:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685143848; x=1687735848; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=+M2DJSnDqWWPeYg5/WUCxic9WjBCf1zdNnp12o5U7f8=; b=fM29H5ZBRNCUDmA3EedA1+baSwOKI6DmGr1QhsFZmO9QuUr24riFfFiiiKDr4v2mxX ZqbXqJDGGuVEic3mUguoYn/2atvtXfjloY8TsZqLCehBPHzjMjhs8bNnhpki4DZcFQJt MhZALj2SDT1tM1r288fkm1WMavJVLPIJlysc4pNqP6aKa0L6eZZXh3iNOPXngsQ+jX23 1in6q00RbW0mPxgKFAXTANwAiIe2spvnxr6cvMKtvjlO8loUyuL0LiOZimPbisO7QuVy rTuGiYLjvCTGi1Rl1WnxJMLUIpQzOiDVNIVs4K0SPEZBvzGUzfkQV4dJWlYKXC+dsE2L GHlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685143848; x=1687735848; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+M2DJSnDqWWPeYg5/WUCxic9WjBCf1zdNnp12o5U7f8=; b=C/zA4+h0/T9XwUX/QLd7M/e0nEE7syIqm0TdLc1GSWBZjZaq47sEuCzyIeCOLP8CTR U/hgGxpYv6BwQCX3Z51gSOaNHycL7L7oq6lG6s/E4Wy+VyVRXaOVyDgEsQ+8ClhsSiwq kuweYdnRdBx/Sh0Olyhy+vcYuGqU3bR2UGebxPDvi/J7TOQweoofxa7FNXPj8QG/cd3m 4anBHSIMD1vgSqF5tb/Tnooil8HHHP9NFuFeD2G8H7/YHHpOoIBdwErwthQ3i0Fgv/3e AYzVLOUIE0DudfgouS8Ur75UEgPTCOvHWPHgOLQcd36IznQTEC0LRhwjxKTLk58JjNks sa9w== X-Gm-Message-State: AC+VfDxjelndgXD2I/+JQEJu+W33yaLSR7lW+dlltGzUFnKS1QSVUBVk +pjju2xAzzgPiA1xXz7Z/S1mxA== X-Google-Smtp-Source: ACHHUZ66BaAb39CSpLT2wJ8xQepZ7pM+VPEpmbazF2GkTgNf19TdqBSREDx4j07NmBHcHTfdO2RRZg== X-Received: by 2002:ac2:4e62:0:b0:4f4:b806:4b5f with SMTP id y2-20020ac24e62000000b004f4b8064b5fmr672955lfs.57.1685143848444; Fri, 26 May 2023 16:30:48 -0700 (PDT) Received: from [192.168.1.101] (abyj77.neoplus.adsl.tpnet.pl. [83.9.29.77]) by smtp.gmail.com with ESMTPSA id r2-20020ac24d02000000b004f3b520e0adsm828207lfi.107.2023.05.26.16.30.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 May 2023 16:30:48 -0700 (PDT) Message-ID: <7f40f870-c11f-3105-f016-445a22fe258f@linaro.org> Date: Sat, 27 May 2023 01:30:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Content-Language: en-US To: Rudraksha Gupta , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: david@ixit.cz, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230524230459.120681-1-guptarud@gmail.com> <20230524230459.120681-4-guptarud@gmail.com> From: Konrad Dybcio Subject: Re: [PATCH 4/5] ARM: Blindly copy the usb node from apq8064.dtsi In-Reply-To: <20230524230459.120681-4-guptarud@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 25.05.2023 01:04, Rudraksha Gupta wrote: > apq8064 and msm8960 are extremely similar SoCs. Therefore copying this > from the apq8064 dtsi file should not be a problem. Tested this on the > Samsung Galaxy Express and this works. > > Signed-off-by: Rudraksha Gupta > --- Well admitting to this upfront doesn't sound very good :P Please reword the message to something like: ARM: dts: qcom-msm8960: Add USB Add the required nodes to support USB on MSM8960. As it's very similar to APQ8064, the setup is almost identical As for the contents itself, I tried taking a brief peek into the swamp that are the msm-3.0 boardfiles, but I barely managed to escape before getting drawn into the quicksands of 13yo legacy.. I am however inclined to believe that the setup may in fact be identical(or close to) on these two SoCs.. Konrad > arch/arm/boot/dts/qcom-msm8960.dtsi | 33 +++++++++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom-msm8960.dtsi b/arch/arm/boot/dts/qcom-msm8960.dtsi > index a4d8dd2d24a6..b11e606440cd 100644 > --- a/arch/arm/boot/dts/qcom-msm8960.dtsi > +++ b/arch/arm/boot/dts/qcom-msm8960.dtsi > @@ -3,6 +3,7 @@ > > #include > #include > +#include > #include > #include > #include > @@ -370,5 +371,37 @@ gsbi1_spi: spi@16080000 { > status = "disabled"; > }; > }; > + > + usb1: usb@12500000 { > + compatible = "qcom,ci-hdrc"; > + reg = <0x12500000 0x200>, > + <0x12500200 0x200>; > + interrupts = ; > + clocks = <&gcc USB_HS1_XCVR_CLK>, <&gcc USB_HS1_H_CLK>; > + clock-names = "core", "iface"; > + assigned-clocks = <&gcc USB_HS1_XCVR_CLK>; > + assigned-clock-rates = <60000000>; > + resets = <&gcc USB_HS1_RESET>; > + reset-names = "core"; > + phy_type = "ulpi"; > + ahb-burst-config = <0>; > + phys = <&usb_hs1_phy>; > + phy-names = "usb-phy"; > + status = "disabled"; > + #reset-cells = <1>; > + > + ulpi { > + usb_hs1_phy: phy { > + compatible = "qcom,usb-hs-phy-msm8960", > + "qcom,usb-hs-phy"; > + clocks = <&sleep_clk>, <&cxo_board>; > + clock-names = "sleep", "ref"; > + resets = <&usb1 0>; > + reset-names = "por"; > + #phy-cells = <0>; > + }; > + }; > + }; > + > }; > };